kernel/linux.git/tools/testing/selftests/ptp/testptp.c, branch linux-4.16.yLinux kernel stable tree (mirror)https://git.radix-linux.su/kernel/linux.git/atom?h=linux-4.16.y2018-01-04T13:57:10+00:00posix-timers: Prevent UB from shifting negative signed value2018-01-04T13:57:10+00:00Nick Desaulniersnick.desaulniers@gmail.com2017-12-29T03:11:36+00:00urn:sha1:29f1b2b0fecfae69e31833836f1da3136696eee5
Shifting a negative signed number is undefined behavior. Looking at the
macros MAKE_PROCESS_CPUCLOCK and FD_TO_CLOCKID, it seems that the
subexpression:
(~(clockid_t) (pid) << 3)
where clockid_t resolves to a signed int, which once negated, is
undefined behavior to shift the value of if the results thus far are
negative.
It was further suggested to make these macros into inline functions.
Suggested-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Nick Desaulniers <nick.desaulniers@gmail.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Dimitri Sivanich <sivanich@hpe.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-kselftest@vger.kernel.org
Cc: Shuah Khan <shuah@kernel.org>
Cc: Deepa Dinamani <deepa.kernel@gmail.com>
Link: https://lkml.kernel.org/r/1514517100-18051-1-git-send-email-nick.desaulniers@gmail.com
selftests: move ptp tests from Documentation/ptp2016-09-20T15:54:38+00:00Shuah Khanshuahkh@osg.samsung.com2016-09-13T17:30:03+00:00urn:sha1:8dbbf854202610a033a0788c33d8feb1548d3eeb
Remove ptp from Makefile to move the test to selftests. Update ptp Makefile
to work under selftests. ptp will not be run as part of selftests suite and
will not be included in install targets. They can be built separately for
now.
Acked-by: Jonathan Corbet <corbet@lwn.net>
Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>