kernel/linux.git/tools/testing/selftests/net/lib.sh, branch v6.19.11

selftests: net: lib: Fix jq parsing error

2026-02-26T23:01:29+00:00

[ Upstream commit 10ec0fc0ccc525abc807b0ca8ad5a26a0bd56361 ] The testcase failed as below: $./vlan_bridge_binding.sh ... + adf_ip_link_set_up d1 + local name=d1 + shift + ip_link_is_up d1 + ip_link_has_flag d1 UP + local name=d1 + shift + local flag=UP + shift ++ ip -j link show d1 ++ jq --arg flag UP 'any(.[].flags.[]; . == $flag)' jq: error: syntax error, unexpected '[', expecting FORMAT or QQSTRING_START (Unix shell quoting issues?) at , line 1: any(.[].flags.[]; . == $flag) jq: 1 compile error Remove the extra dot (.) after flags array to fix this. Fixes: 4baa1d3a5080 ("selftests: net: lib: Add ip_link_has_flag()") Signed-off-by: Yue Haibing Reviewed-by: Petr Machata Link: https://patch.msgid.link/20260211022146.190948-1-yuehaibing@huawei.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin

selftests: net: lib: tc_rule_stats_get(): Don't hard-code array index

2025-12-11T08:53:15+00:00

Flower is commonly used to match on packets in many bash-based selftests. A dump of a flower filter including statistics looks something like this: [ { "protocol": "all", "pref": 49152, "kind": "flower", "chain": 0 }, { ... "options": { ... "actions": [ { ... "stats": { "bytes": 0, "packets": 0, "drops": 0, "overlimits": 0, "requeues": 0, "backlog": 0, "qlen": 0 } } ] } } ] The JQ query in the helper function tc_rule_stats_get() assumes this form and looks for the second element of the array. However, a dump of a u32 filter looks like this: [ { "protocol": "all", "pref": 49151, "kind": "u32", "chain": 0 }, { "protocol": "all", "pref": 49151, "kind": "u32", "chain": 0, "options": { "fh": "800:", "ht_divisor": 1 } }, { ... "options": { ... "actions": [ { ... "stats": { "bytes": 0, "packets": 0, "drops": 0, "overlimits": 0, "requeues": 0, "backlog": 0, "qlen": 0 } } ] } }, ] There's an extra element which the JQ query ends up choosing. Instead of hard-coding a particular index, look for the entry on which a selector .options.actions yields anything. Signed-off-by: Petr Machata Reviewed-by: Ido Schimmel Link: https://patch.msgid.link/12982a44471c834511a0ee6c1e8f57e3a5307105.1765289566.git.petrm@nvidia.com Signed-off-by: Jakub Kicinski

selftests: net: lib: Do not overwrite error messages

2025-11-18T03:32:12+00:00

ret_set_ksft_status() calls ksft_status_merge() with the current return status and the last one. It treats a non-zero return code from ksft_status_merge() as an indication that the return status was overwritten by the last one and therefore overwrites the return message with the last one. Currently, ksft_status_merge() returns a non-zero return code even if the current return status and the last one are equal. This results in return messages being overwritten which is counter-productive since we are more interested in the first failure message and not the last one. Fix by changing ksft_status_merge() to only return a non-zero return code if the current return status was actually changed. Add a test case which checks that the first error message is not overwritten. Before: # ./lib_sh_test.sh [...] TEST: RET tfail2 tfail -> fail [FAIL] retmsg=tfail expected tfail2 [...] # echo $? 1 After: # ./lib_sh_test.sh [...] TEST: RET tfail2 tfail -> fail [ OK ] [...] # echo $? 0 Fixes: 596c8819cb78 ("selftests: forwarding: Have RET track kselftest framework constants") Reviewed-by: Petr Machata Signed-off-by: Ido Schimmel Link: https://patch.msgid.link/20251116081029.69112-1-idosch@nvidia.com Signed-off-by: Jakub Kicinski

selftests: net: lib: Rename bridge_vlan_add() to adf_*

2025-09-27T00:48:39+00:00

Rename this function to mark it as autodefer. For details, see the discussion in the cover letter. Signed-off-by: Petr Machata Reviewed-by: Simon Horman Link: https://patch.msgid.link/93526ce79e635a3ec34753c796edf0c96711547d.1758821127.git.petrm@nvidia.com Signed-off-by: Jakub Kicinski

selftests: net: lib: Rename ip_route_add() to adf_*

2025-09-27T00:48:39+00:00

Rename this function to mark it as autodefer. For details, see the discussion in the cover letter. Signed-off-by: Petr Machata Reviewed-by: Simon Horman Link: https://patch.msgid.link/403143183373419e4a31df4665d6bfaa273eb761.1758821127.git.petrm@nvidia.com Signed-off-by: Jakub Kicinski

selftests: net: lib: Rename ip_addr_add() to adf_*

2025-09-27T00:48:38+00:00

Rename this function to mark it as autodefer. For details, see the discussion in the cover letter. Signed-off-by: Petr Machata Reviewed-by: Simon Horman Link: https://patch.msgid.link/706327a5db660c7f18ba9fbfba7ce913da065e3e.1758821127.git.petrm@nvidia.com Signed-off-by: Jakub Kicinski

selftests: net: lib: Rename ip_link_set_down() to adf_*

2025-09-27T00:48:38+00:00

Rename this function to mark it as autodefer. For details, see the discussion in the cover letter. Signed-off-by: Petr Machata Reviewed-by: Simon Horman Link: https://patch.msgid.link/e5bf4cb3405fb50fe6e217a04268952e97410dc2.1758821127.git.petrm@nvidia.com Signed-off-by: Jakub Kicinski

selftests: net: lib: Rename ip_link_set_up() to adf_*

2025-09-27T00:48:37+00:00

Rename this function to mark it as autodefer. For details, see the discussion in the cover letter. Signed-off-by: Petr Machata Reviewed-by: Simon Horman Link: https://patch.msgid.link/475716ef792f5bd42e5c8ef1c3e287b1294f1630.1758821127.git.petrm@nvidia.com Signed-off-by: Jakub Kicinski

selftests: net: lib: Rename ip_link_set_addr() to adf_*

2025-09-27T00:48:37+00:00

Rename this function to mark it as autodefer. For details, see the discussion in the cover letter. Signed-off-by: Petr Machata Reviewed-by: Simon Horman Link: https://patch.msgid.link/5318e90f7f491f9f397ac221a8b47fdbedd0d3b2.1758821127.git.petrm@nvidia.com Signed-off-by: Jakub Kicinski

selftests: net: lib: Rename ip_link_set_master() to adf_*

2025-09-27T00:48:37+00:00

Rename this function to mark it as autodefer. For details, see the discussion in the cover letter. Signed-off-by: Petr Machata Reviewed-by: Simon Horman Link: https://patch.msgid.link/53ce64231faa1396a968b2869af5f1c0aebec2c9.1758821127.git.petrm@nvidia.com Signed-off-by: Jakub Kicinski