kernel/linux.git/sound/drivers/vx, branch v6.12.80Linux kernel stable tree (mirror)https://git.radix-linux.su/kernel/linux.git/atom?h=v6.12.802024-08-08T05:47:23+00:00ALSA: vx_core: Use standard print API2024-08-08T05:47:23+00:00Takashi Iwaitiwai@suse.de2024-08-07T13:34:01+00:00urn:sha1:41abc8056dd3125d4a9b7ac0f4087dfb67580d95
Use the standard print API with dev_*() instead of the old house-baked
one. It gives better information and allows dynamically control of
debug prints.
The commented old debug prints are dropped, too.
Reviewed-by: Jaroslav Kysela <perex@perex.cz>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20240807133452.9424-12-tiwai@suse.de
ALSA: vx_core: Drop unused dev field2024-08-08T05:47:23+00:00Takashi Iwaitiwai@suse.de2024-08-07T13:34:00+00:00urn:sha1:b426b3ba9f6fe17990893c5324727dd217d420b6
The vx_core.dev field has never been set but referred incorrectly at
firmware loading. Pass the proper device pointer from card->dev at
request_firmware(), and drop the unused dev field from vx_core, too.
Reviewed-by: Jaroslav Kysela <perex@perex.cz>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20240807133452.9424-11-tiwai@suse.de
ALSA: drivers: Use *-y instead of *-objs in Makefile2024-05-08T16:17:57+00:00Takashi Iwaitiwai@suse.de2024-05-07T13:55:06+00:00urn:sha1:4d256122945ec26623260babdeda90ab0796ecea
*-objs suffix is reserved rather for (user-space) host programs while
usually *-y suffix is used for kernel drivers (although *-objs works
for that purpose for now).
Let's correct the old usages of *-objs in Makefiles.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Jaroslav Kysela <perex@perex.cz>
Link: https://lore.kernel.org/r/20240507135513.14919-7-tiwai@suse.de
ALSA: vx: Drop superfluous GFP setup2022-08-24T06:00:26+00:00Takashi Iwaitiwai@suse.de2022-08-23T11:57:36+00:00urn:sha1:a5ed0c547d50d30a60d67b0911b4ec2c85c54310
The extra setup with GFP_DMA32 is superfluous for this driver. The
whole operation is a simple copy loop, and there is no memory address
restriction at all. Drop the useless GFP setup.
Link: https://lore.kernel.org/r/20220823115740.14123-2-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
ALSA: vx: Manage vx_core object with devres2021-07-19T14:17:09+00:00Takashi Iwaitiwai@suse.de2021-07-15T07:59:11+00:00urn:sha1:a033954140ac43a8ce0eab469229a107cfee1c87
The firmware data are also released automatically.
Link: https://lore.kernel.org/r/20210715075941.23332-50-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
ALSA: vx: Fix assignment in if condition2021-06-09T15:30:31+00:00Takashi Iwaitiwai@suse.de2021-06-08T14:05:34+00:00urn:sha1:ed1567c106726d0629c461053e2bc2e9365de9aa
VX driver helper code contains lots of assignments in if condition,
which is a bad coding style that may confuse readers and occasionally
lead to bugs.
This patch is merely for coding-style fixes, no functional changes.
Link: https://lore.kernel.org/r/20210608140540.17885-61-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
ALSA: vx: fix kernel-doc warning2021-03-03T08:25:05+00:00Pierre-Louis Bossartpierre-louis.bossart@linux.intel.com2021-03-02T21:54:28+00:00urn:sha1:60fd71150391cf6be0276f3be1e71f7196547302
make W=1 warning:
sound/drivers/vx/vx_core.c:410: warning: expecting prototype for
snd_vx_boot_xilinx(). Prototype was for snd_vx_load_boot_image()
instead
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20210302215430.87309-2-pierre-louis.bossart@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
ALSA: vx: Use roundup() instead of open-coding it2020-12-25T08:11:53+00:00Lars-Peter Clausenlars@metafoo.de2020-12-23T17:22:23+00:00urn:sha1:af102a88ade2aca4b5c38843fbdc05d9f85b7723
Use roundup() instead of open-coding it. This documents intent
and makes it more clear what is going on for the casual reviewer.
Generated using the following the Coccinelle semantic patch.
// <smpl>
@@
expression x, y;
@@
-((((x) + (y) - 1) / (y)) * y)
+roundup(x, y)
// </smpl>
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Link: https://lore.kernel.org/r/20201223172229.781-12-lars@metafoo.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
ALSA: vx: vx_pcm: remove redundant assignment2020-09-03T07:28:01+00:00Pierre-Louis Bossartpierre-louis.bossart@linux.intel.com2020-09-02T21:21:33+00:00urn:sha1:b248b9dd5975c1e16b7918c1dc7eaef7eccfde5f
Fix cppcheck warning:
sound/drivers/vx/vx_pcm.c:63:7: style: Variable 'buf' is assigned a
value that is never used. [unreadVariable]
buf = (unsigned char *)runtime->dma_area;
^
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20200902212133.30964-19-pierre-louis.bossart@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
ALSA: vx: vx_pcm: remove redundant assignment2020-09-03T07:27:56+00:00Pierre-Louis Bossartpierre-louis.bossart@linux.intel.com2020-09-02T21:21:32+00:00urn:sha1:e408ab068aeca958b83bb6e5ca724356f8c7d78e
Fix cppcheck warning:
sound/drivers/vx/vx_pcm.c:539:30: style: Variable
'chip->playback_pipes[audio]' is reassigned a value before the old one
has been used. [redundantAssignment]
chip->playback_pipes[audio] = pipe;
^
sound/drivers/vx/vx_pcm.c:533:31: note: chip->playback_pipes[audio] is
assigned
chip->playback_pipes[audio] = pipe;
^
sound/drivers/vx/vx_pcm.c:539:30: note: chip->playback_pipes[audio] is
overwritten
chip->playback_pipes[audio] = pipe;
^
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20200902212133.30964-18-pierre-louis.bossart@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>