kernel/linux.git/sound/core/seq, branch v6.18.21Linux kernel stable tree (mirror)https://git.radix-linux.su/kernel/linux.git/atom?h=v6.18.212025-09-17T12:14:12+00:00ALSA: seq: Fix KCSAN data-race warning at snd_seq_fifo_poll_wait()2025-09-17T12:14:12+00:00Takashi Iwaitiwai@suse.de2025-09-17T12:13:27+00:00urn:sha1:1f9fc89cbbe8a7a8648ea2f827f7d8590e62e52c
snd_seq_fifo_poll_wait() evaluates f->cells without locking after
poll_wait(), and KCSAN doesn't like it as it appears to be a
data-race. Although this doesn't matter much in practice as the value
is volatile, it's still better to address it for the mind piece.
Wrap it with f->lock spinlock for avoiding the potential data race.
Reported-by: syzbot+c3dbc239259940ededba@syzkaller.appspotmail.com
Link: https://syzkaller.appspot.com/bug?extid=c3dbc239259940ededba
Signed-off-by: Takashi Iwai <tiwai@suse.de>
ALSA: seq: oss/rw: Cleanup with guard2025-08-29T09:52:36+00:00Takashi Iwaitiwai@suse.de2025-08-27T08:05:17+00:00urn:sha1:da24e6b3c251d6ef6964b78f198f6dfd5385d372
Replace the manual spin lock/unlock pairs with guard() for code
simplification.
Only code refactoring, and no behavior change.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20250827080520.7544-12-tiwai@suse.de
ALSA: seq: oss/synth: Clean up with guard and auto cleanup2025-08-29T09:52:36+00:00Takashi Iwaitiwai@suse.de2025-08-27T08:05:16+00:00urn:sha1:80ccbe91adab52a2b9a0e8b31663d4ec2a914a77
Use the auto-cleanup for the refcount management of seq_oss_synth
object. The explicit call of snd_use_lock_free() is dropped by the
magic __free(seq_oss_synth) attribute.
Along with that, replace the manual mutex and spin locks with
guard().
Only code refactoring, and no behavior change.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20250827080520.7544-11-tiwai@suse.de
ALSA: seq: oss/midi: Cleanup with guard and auto-cleanup2025-08-29T09:52:36+00:00Takashi Iwaitiwai@suse.de2025-08-27T08:05:15+00:00urn:sha1:895a46e034f9aa11779c66f0bb41c51f50b265ef
Use the auto-cleanup for the refcount management of seq_oss_midi
object. The explicit call of snd_use_lock_free() is dropped by the
magic __free(seq_oss_midi) attribute.
Along with that, replace the manual mutex and spin locks with
guard().
Only code refactoring, and no behavior change.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20250827080520.7544-10-tiwai@suse.de
ALSA: seq: oss: Clean up core code with guard()2025-08-29T09:52:36+00:00Takashi Iwaitiwai@suse.de2025-08-27T08:05:14+00:00urn:sha1:1291fc664d2320af332e0f6b3c28a1a4e125fee9
Replace the manual mutex lock/unlock pairs with guard() for code
simplification.
Only code refactoring, and no behavior change.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20250827080520.7544-9-tiwai@suse.de
ALSA: seq: Clean up fifo locking with guard2025-08-29T09:52:36+00:00Takashi Iwaitiwai@suse.de2025-08-27T08:05:13+00:00urn:sha1:9314e34e37292f2d3d43dcc8a7f54366b4c0811d
Yet more cleanup, now for seq_fifo.c about its refcount calls; the
manual refcount calls (either snd_use_lock_*() or snd_seq_fifo_lock())
are replaced with guard(snd_seq_fifo).
Only code refactoring, and no behavior change.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20250827080520.7544-8-tiwai@suse.de
ALSA: seq: Clean up queue locking with auto cleanup2025-08-29T09:52:35+00:00Takashi Iwaitiwai@suse.de2025-08-27T08:05:12+00:00urn:sha1:04a86185b7853971786d1d4b375b5544edd8d44d
Yet more cleanup with the auto-cleanup macro: now we replace the
queuefree() calls with the magic pointer attribute
__free(snd_seq_queue).
Only code refactoring, and no behavior change.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20250827080520.7544-7-tiwai@suse.de
ALSA: seq: Clean up port locking with auto cleanup2025-08-29T09:52:35+00:00Takashi Iwaitiwai@suse.de2025-08-27T08:05:11+00:00urn:sha1:0869afc958a05e8413dfac3c4a6a456bc0b2fd66
Like the previous change in seq_clientmgr.c, introduce a new
auto-cleanup macro for the snd_seq_port_unlock(), and apply it
appropriately.
Only code refactoring, and no behavior change.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20250827080520.7544-6-tiwai@suse.de
ALSA: seq: Use auto-cleanup for client refcounting2025-08-29T09:52:35+00:00Takashi Iwaitiwai@suse.de2025-08-27T08:05:10+00:00urn:sha1:99e16633958b50ab4f9b6d171aca2c7be7bcab8c
The current code manages the refcount of client in a way like:
snd_seq_client *client;
client = clientptr(id);
....
snd_seq_client_unlock(client);
Now we introduce an auto-cleanup macro to manage the unlock
implicitly, namely, the above will be replaced like:
snd_seq_client *client __free(snd_seq_client) = NULL;
client = clientptr(id);
and we can forget the unref call.
A part of the code in snd_seq_deliver_single_event() is factored out
to a function, so that the auto-cleanups can be applied cleanly.
This also allows us to replace some left mutex lock/unlock with
guard(), and also reduce scoped_guard() to the normal guard(), too.
Only code refactoring, and no behavior change.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20250827080520.7544-5-tiwai@suse.de
ALSA: seq: Use guard() for mutex and rwsem locks2025-08-29T09:52:35+00:00Takashi Iwaitiwai@suse.de2025-08-27T08:05:09+00:00urn:sha1:d7cd16143bd8796f526806bfced721bd00dbb43e
There are a few manual calls of mutex and rwsem lock/unlock pairs in
seq_clientmngr.c, and those can be replaced nicely with guard().
Only code refactoring, and no behavior change.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20250827080520.7544-4-tiwai@suse.de