kernel/linux.git/scripts/kconfig/parser.y, branch linux-6.9.yLinux kernel stable tree (mirror)https://git.radix-linux.su/kernel/linux.git/atom?h=linux-6.9.y2024-03-28T02:02:13+00:00kconfig: do not reparent the menu inside a choice block2024-03-28T02:02:13+00:00Masahiro Yamadamasahiroy@kernel.org2024-03-23T08:51:01+00:00urn:sha1:7e3465f63a0a70641ed8e49f9d40ee613f7da586
The boolean 'choice' is used to list exclusively selected config
options.
You must not add a dependency between choice members, because such a
dependency would create an invisible entry.
In the following test case, it is impossible to choose 'C'.
[Test Case 1]
choice
prompt "Choose one, but how to choose C?"
config A
bool "A"
config B
bool "B"
config C
bool "C"
depends on A
endchoice
Hence, Kconfig shows the following error message:
Kconfig:1:error: recursive dependency detected!
Kconfig:1: choice <choice> contains symbol C
Kconfig:10: symbol C is part of choice A
Kconfig:4: symbol A is part of choice <choice>
For a resolution refer to Documentation/kbuild/kconfig-language.rst
subsection "Kconfig recursive dependency limitations"
However, Kconfig does not report anything for the following similar code:
[Test Case 2]
choice
prompt "Choose one, but how to choose B?"
config A
bool "A"
config B
bool "B"
depends on A
config C
bool "C"
endchoice
This is because menu_finalize() reparents the menu tree when an entry
depends on the preceding one.
With reparenting, the menu tree:
choice
|- A
|- B
\- C
... will be transformed into the following structure:
choice
|- A
| \- B
\- C
Consequently, Kconfig considers only 'A' and 'C' as choice members.
This behavior is awkward. The second test case should be an error too.
This commit stops reparenting inside a choice.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
kconfig: check prompt for choice while parsing2024-03-18T17:30:51+00:00Masahiro Yamadamasahiroy@kernel.org2024-03-10T13:45:15+00:00urn:sha1:4957515b9c3aa3d32a1ee44ab77f0a44f29263dc
This can be checked on-the-fly.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
kconfig: remove named choice support2024-03-10T04:29:48+00:00Masahiro Yamadamasahiroy@kernel.org2024-03-03T04:00:35+00:00urn:sha1:c83f020973bc72d9eec65474d8c47495191aef20
Commit 5a1aa8a1aff6 ("kconfig: add named choice group") did not provide
enough explanation regarding its benefits. A use case was found in
another project [1] sometime later, this feature has never been used in
the kernel.
[1]: https://lore.kernel.org/all/201012150034.01356.yann.morin.1998@anciens.enib.fr/
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
kconfig: use generic macros to implement symbol hashtable2024-02-20T11:47:45+00:00Masahiro Yamadamasahiroy@kernel.org2024-02-11T12:41:05+00:00urn:sha1:91b69454f93d1c905f3a56bb39856db9a220c791
Use helper macros in hashtable.h for generic hashtable implementation.
We can git rid of the hash head index of for_all_symbols().
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
kconfig: print recursive dependency errors in the parsed order2024-02-20T11:47:45+00:00Masahiro Yamadamasahiroy@kernel.org2024-02-11T12:41:04+00:00urn:sha1:cc25cfc563adc48c84f1eec6432b369bcab73ca6
for_all_symbols() iterates in the symbol hash table. The order of
iteration depends on the hash table implementation.
If you use it for printing errors, they are shown in random order.
For example, the order of following test input and the corresponding
error do not match:
- scripts/kconfig/tests/err_recursive_dep/Kconfig
- scripts/kconfig/tests/err_recursive_dep/expected_stderr
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
kconfig: do not delay the cur_filename update2024-02-19T09:20:40+00:00Masahiro Yamadamasahiroy@kernel.org2024-02-02T15:58:12+00:00urn:sha1:d3e4a68fe20f3c05de77f5e300e3d76a9f68d942
Currently, cur_filename is updated at the first token of each statement.
However, this seems unnecessary based on my understanding; the parser
can use the same variable as the lexer tracks.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
kconfig: associate struct menu with file name directly2024-02-19T09:20:40+00:00Masahiro Yamadamasahiroy@kernel.org2024-02-02T15:58:09+00:00urn:sha1:40bab83a6595b3ab8afcfdb57903470f64fdbdb9
struct menu is linked to struct file for diagnostic purposes.
It is always used to retrieve the file name through menu->file->name.
Associate struct menu with the file name directly.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
kconfig: remove zconf_curname() and zconf_lineno()2024-02-19T09:20:40+00:00Masahiro Yamadamasahiroy@kernel.org2024-02-02T15:58:08+00:00urn:sha1:1d7c4f10baacbc658918f7ddec31e1d1962df6fc
Now zconf_curname() and zconf_lineno() are so simple that they just
return cur_filename, cur_lineno, respectively.
Remove these functions, and then use cur_filename and cur_lineno
directly.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
kconfig: split preprocessor prototypes into preprocess.h2024-02-19T09:20:40+00:00Masahiro Yamadamasahiroy@kernel.org2024-02-02T15:58:06+00:00urn:sha1:d3d16228a520ce49884d3bb90b67c12726c63020
These are needed only for the parse stage. Move the prototypes into
a separate header to make sure they are not used after that.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
kconfig: call env_write_dep() right after yyparse()2024-02-19T09:20:40+00:00Masahiro Yamadamasahiroy@kernel.org2024-02-02T15:58:05+00:00urn:sha1:56e634b06fd554b819ac9c45fc77a41500861ced
This allows preprocess.c to free up all of its resources when the parse
stage is finished. It also ensures conf_write_autoconf_cmd() produces
consistent results even if called multiple times for any reason.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>