kernel/linux.git/samples/configfs, branch v6.12.80

samples: configfs: add missing MODULE_DESCRIPTION() macro

2024-07-10T12:59:01+00:00

make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in samples/configfs/configfs_sample.o Add the missing invocation of the MODULE_DESCRIPTION() macro. Signed-off-by: Jeff Johnson Nacked-by: Christoph Hellwig Link: https://lore.kernel.org/r/20240601-md-samples-configfs-v1-1-83ef2d3c0088@quicinc.com Signed-off-by: Greg Kroah-Hartman

treewide: remove editor modelines and cruft

2021-05-07T07:26:34+00:00

The section "19) Editor modelines and other cruft" in Documentation/process/coding-style.rst clearly says, "Do not include any of these in source files." I recently receive a patch to explicitly add a new one. Let's do treewide cleanups, otherwise some people follow the existing code and attempt to upstream their favoriate editor setups. It is even nicer if scripts/checkpatch.pl can check it. If we like to impose coding style in an editor-independent manner, I think editorconfig (patch [1]) is a saner solution. [1] https://lore.kernel.org/lkml/20200703073143.423557-1-danny@kdrag0n.dev/ Link: https://lkml.kernel.org/r/20210324054457.1477489-1-masahiroy@kernel.org Signed-off-by: Masahiro Yamada Acked-by: Geert Uytterhoeven Reviewed-by: Miguel Ojeda [auxdisplay] Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds

samples: configfs: prefer pr_err() over bare printk(KERN_ERR

2020-10-07T13:46:22+00:00

pr_*() printing helpers are preferred over using bare printk(). Signed-off-by: Bartosz Golaszewski Signed-off-by: Christoph Hellwig

samples: configfs: don't use spaces before tabs

2020-10-07T13:46:22+00:00

The copyright notice alarms checkpatch.pl of usin spaces before tabs. Fix this. Signed-off-by: Bartosz Golaszewski Signed-off-by: Christoph Hellwig

samples: configfs: consolidate local variables of the same type

2020-10-07T13:46:21+00:00

Move local variables of the same type into a single line for better readability. Signed-off-by: Bartosz Golaszewski Signed-off-by: Christoph Hellwig

samples: configfs: don't reinitialize variables which are already zeroed

2020-10-07T13:45:00+00:00

The structure containing the storeme field is allocated using kzalloc(). There's no need to set it to 0 again. Signed-off-by: Bartosz Golaszewski Signed-off-by: Christoph Hellwig

samples: configfs: replace simple_strtoul() with kstrtoint()

2020-10-07T13:44:59+00:00

simple_strtoul() is deprecated. Use kstrtoint(). Signed-off-by: Bartosz Golaszewski Signed-off-by: Christoph Hellwig

samples: configfs: fix alignment in item struct

2020-10-07T13:44:59+00:00

Aling the assignment of a static structure's field to be consistent with all other instances. Signed-off-by: Bartosz Golaszewski Signed-off-by: Christoph Hellwig

samples: configfs: drop unnecessary ternary operators

2020-10-07T13:44:51+00:00

Checking pointers for NULL value before passing them to container_of() is pointless because even if we return NULL from the ternary operator, none of the users checks the returned value but they instead dereference it unconditionally. AFAICT this cannot really happen either. Simplify the code by removing the ternary operators from to_childless() et al. Signed-off-by: Bartosz Golaszewski Signed-off-by: Christoph Hellwig

samples: configfs: remove redundant newlines

2020-10-07T13:43:56+00:00

There's no need for suplemental newlines in the source file - especially since the examples are well divided with comments already. Signed-off-by: Bartosz Golaszewski Signed-off-by: Christoph Hellwig