Linux kernel stable tree (mirror) https://git.radix-linux.su/kernel/linux.git/atom?h=v6.6.131 2022-02-23T12:29:15+00:00 2022-02-23T12:29:15+00:00 Matt Johnston matt@codeconstruct.com.au 2022-02-22T04:17:38+00:00 urn:sha1:dc121c0084910db985cf1c8ba6fce5d8c307cc02 Previously there was a race that could allow the mctp_dev refcount to hit zero: rcu_read_lock(); mdev = __mctp_dev_get(dev); // mctp_unregister() happens here, mdev->refs hits zero mctp_dev_hold(dev); rcu_read_unlock(); Now we make __mctp_dev_get() take the hold itself. It is safe to test against the zero refcount because __mctp_dev_get() is called holding rcu_read_lock and mctp_dev uses kfree_rcu(). Reported-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Matt Johnston <matt@codeconstruct.com.au> Signed-off-by: David S. Miller <davem@davemloft.net> 2021-11-29T13:00:09+00:00 Jeremy Kerr jk@codeconstruct.com.au 2021-11-29T02:16:52+00:00 urn:sha1:d8519565447078f141c58ba4193d820f2cdf1914 In our test device, we're currently freeing skbs in the transmit path with kfree(), rather than kfree_skb(). This change uses the correct kfree_skb() instead. Fixes: ded21b722995 ("mctp: Add test utils") Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au> Signed-off-by: David S. Miller <davem@davemloft.net> 2021-10-03T13:35:41+00:00 Jeremy Kerr jk@codeconstruct.com.au 2021-10-03T03:17:05+00:00 urn:sha1:ded21b72299529cc143a4213ea0ec4b0c620b8eb Add a new object for shared test utilities Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au> Signed-off-by: David S. Miller <davem@davemloft.net> 2021-10-01T13:59:33+00:00 David S. Miller davem@davemloft.net 2021-10-01T13:56:52+00:00 urn:sha1:b022f8866ea5014d39ae569897c271e41f5c9799 This reverts commit 4f42ad2011d2fcbd89f5cdf56121271a8cd5ee5d, reversing changes made to ea2dd331bfaaeba74ba31facf437c29044f7d4cb. These chanfges break the build when mctp is modular. Signed-off-by: David S. Miller <davem@davemloft.net> 2021-10-01T13:19:00+00:00 Jeremy Kerr jk@codeconstruct.com.au 2021-10-01T08:18:41+00:00 urn:sha1:077b6d52df6dba4f371768428fa9a50d8b6485e7 Add a new object for shared test utilities Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au> Signed-off-by: David S. Miller <davem@davemloft.net>