kernel/linux.git/net/mac80211/key.c, branch v6.6Linux kernel stable tree (mirror)https://git.radix-linux.su/kernel/linux.git/atom?h=v6.62023-10-11T14:36:14+00:00wifi: mac80211: fix error path key leak2023-10-11T14:36:14+00:00Johannes Bergjohannes.berg@intel.com2023-10-05T21:09:18+00:00urn:sha1:02e0e426a2fb1446ebd7bc0eccfb48aedefb966b
In the previous key leak fix for the other error
paths, I meant to unify all of them to the same
place, but used the wrong label, which I noticed
when doing the merge into wireless-next. Fix it.
Fixes: d097ae01ebd4 ("wifi: mac80211: fix potential key leak")
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
wifi: mac80211: fix potential key leak2023-09-25T06:40:07+00:00Johannes Bergjohannes.berg@intel.com2023-09-19T06:34:16+00:00urn:sha1:d097ae01ebd48adc028aebcf760117a5317975dc
When returning from ieee80211_key_link(), the key needs to
have been freed or successfully installed. This was missed
in a number of error paths, fix it.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
wifi: mac80211: fix potential key use-after-free2023-09-25T06:40:04+00:00Johannes Bergjohannes.berg@intel.com2023-09-19T06:34:15+00:00urn:sha1:31db78a4923ef5e2008f2eed321811ca79e7f71b
When ieee80211_key_link() is called by ieee80211_gtk_rekey_add()
but returns 0 due to KRACK protection (identical key reinstall),
ieee80211_gtk_rekey_add() will still return a pointer into the
key, in a potential use-after-free. This normally doesn't happen
since it's only called by iwlwifi in case of WoWLAN rekey offload
which has its own KRACK protection, but still better to fix, do
that by returning an error code and converting that to success on
the cfg80211 boundary only, leaving the error for bad callers of
ieee80211_gtk_rekey_add().
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Fixes: fdf7cb4185b6 ("mac80211: accept key reinstall without changing anything")
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
wifi: mac80211: Do not include crypto/algapi.h2023-08-24T06:42:36+00:00Herbert Xuherbert@gondor.apana.org.au2023-08-23T10:32:25+00:00urn:sha1:8da1985ff75226fd758ef379f9dd98986c811704
The header file crypto/algapi.h is for internal use only. Use the
header file crypto/utils.h instead.
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Link: https://lore.kernel.org/r/E1qYlA0-006vFr-Ts@formenos.hmeau.com
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
wifi: mac80211: mark keys as uploaded when added by the driver2023-06-21T12:14:14+00:00Yedidya Benshimolyedidya.ben.shimol@intel.com2023-06-21T11:44:36+00:00urn:sha1:f52a0b408ed144afa42b45f078a28542e711551b
When the driver has some form of GTK rekeying offload, e.g. during
WoWLAN, mac80211 can assume that keys that the driver adds for
that are already present in the hardware acceleration. Mark them
accordingly.
Signed-off-by: Yedidya Benshimol <yedidya.ben.shimol@intel.com>
Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>
Link: https://lore.kernel.org/r/20230621144414.bc78c7ff2a3d.I5e313d69e2b6a7a4766ef82d0faa122dd4c1c46d@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
wifi: mac80211: implement link switching2022-09-06T08:17:20+00:00Johannes Bergjohannes.berg@intel.com2022-09-02T14:12:56+00:00urn:sha1:3d901102922723eedce6ef10ebd03315a7abb8a5
Implement an API function and debugfs file to switch
active links.
Also provide an async version of the API so drivers
can call it in arbitrary contexts, e.g. while in the
authorized callback.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
wifi: mac80211: isolate driver from inactive links2022-09-06T08:12:44+00:00Johannes Bergjohannes.berg@intel.com2022-09-02T14:12:42+00:00urn:sha1:efe9c2bfd1a82894e455514a68dc794556fbd463
In order to let the driver select active links and properly
make multi-link connections, as a first step isolate the
driver from inactive links, and set the active links to be
only the association link for client-side interfaces. For
AP side nothing changes since APs always have to have all
their links active.
To simplify things, update the for_each_sta_active_link()
API to include the appropriate vif pointer.
This also implies not allocating a chanctx for an inactive
link, which requires a few more changes.
Since we now no longer try to program multiple links to the
driver, remove the check in the MLME code.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
wifi: mac80211: fix potential deadlock in ieee80211_key_link()2022-08-29T09:48:59+00:00Sun Kesunke32@huawei.com2022-08-27T02:24:52+00:00urn:sha1:7c13844c3b7662976270996552eee3a0849afc3f
Add the missing unlock before return in the error handling case.
Fixes: ccdde7c74ffd ("wifi: mac80211: properly implement MLO key handling")
Signed-off-by: Sun Ke <sunke32@huawei.com>
Link: https://lore.kernel.org/r/20220827022452.823381-1-sunke32@huawei.com
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
wifi: mac80211: properly implement MLO key handling2022-08-25T08:41:07+00:00Johannes Bergjohannes.berg@intel.com2022-08-17T09:17:01+00:00urn:sha1:ccdde7c74ffd7e8bdd3cf685bbfa41231c8e3131
Implement key installation and lookup (on TX and RX)
for MLO, so we can use multiple GTKs/IGTKs/BIGTKs.
Co-authored-by: Ilan Peer <ilan.peer@intel.com>
Signed-off-by: Ilan Peer <ilan.peer@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
wifi: mac80211: reorg some iface data structs for MLD2022-06-20T10:55:06+00:00Johannes Bergjohannes.berg@intel.com2022-05-16T13:00:15+00:00urn:sha1:bfd8403adddd09f32033a14bf25be398291e7881
Start reorganizing interface related data structures toward
MLD. The most complex part here is for the keys, since we
have to split the various kinds of GTKs off to the link but
still need to use (for WEP) the other keys as a fallback
even for multicast frames.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>