kernel/linux.git/net/ethtool/plca.c, branch v6.6.132Linux kernel stable tree (mirror)https://git.radix-linux.su/kernel/linux.git/atom?h=v6.6.1322023-10-03T14:18:58+00:00ethtool: plca: fix plca enable data type while parsing the value2023-10-03T14:18:58+00:00Parthiban VeerasooranParthiban.Veerasooran@microchip.com2023-09-08T04:45:48+00:00urn:sha1:8957261cd8149ed9d0738c01c0320bcbff989407
The ETHTOOL_A_PLCA_ENABLED data type is u8. But while parsing the
value from the attribute, nla_get_u32() is used in the plca_update_sint()
function instead of nla_get_u8(). So plca_cfg.enabled variable is updated
with some garbage value instead of 0 or 1 and always enables plca even
though plca is disabled through ethtool application. This bug has been
fixed by parsing the values based on the attributes type in the policy.
Fixes: 8580e16c28f3 ("net/ethtool: add netlink interface for the PLCA RS")
Signed-off-by: Parthiban Veerasooran <Parthiban.Veerasooran@microchip.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20230908044548.5878-1-Parthiban.Veerasooran@microchip.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
ethtool: netlink: always pass genl_info to .prepare_data2023-08-15T22:01:03+00:00Jakub Kicinskikuba@kernel.org2023-08-14T21:47:23+00:00urn:sha1:f946270d05c26044c67511ef5a9d91e06962d79f
We had a number of bugs in the past because developers forgot
to fully test dumps, which pass NULL as info to .prepare_data.
.prepare_data implementations would try to access info->extack
leading to a null-deref.
Now that dumps and notifications can access struct genl_info
we can pass it in, and remove the info null checks.
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com> # pause
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Link: https://lore.kernel.org/r/20230814214723.2924989-11-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
ethtool: netlink: convert commands to common SET2023-01-27T12:24:32+00:00Jakub Kicinskikuba@kernel.org2023-01-25T23:05:19+00:00urn:sha1:04007961bfaf76894b65de2af67f96d9d1fa82cf
Convert all SET commands where new common code is applicable.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
plca.c: fix obvious mistake in checking retval2023-01-14T05:42:53+00:00Piergiorgio Berutopiergiorgio.beruto@gmail.com2023-01-13T13:26:35+00:00urn:sha1:28dbf774bc879c1841d58cb711aaea6198955b95
Revert a wrong fix that was done during the review process. The
intention was to substitute "if(ret < 0)" with "if(ret)".
Unfortunately, the intended fix did not meet the code.
Besides, after additional review, it was decided that "if(ret < 0)"
was actually the right thing to do.
Fixes: 8580e16c28f3 ("net/ethtool: add netlink interface for the PLCA RS")
Signed-off-by: Piergiorgio Beruto <piergiorgio.beruto@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/f2277af8951a51cfee2fb905af8d7a812b7beaf4.1673616357.git.piergiorgio.beruto@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ethtool: add netlink interface for the PLCA RS2023-01-11T08:35:02+00:00Piergiorgio Berutopiergiorgio.beruto@gmail.com2023-01-09T16:59:39+00:00urn:sha1:8580e16c28f3f1a1bee87de115157161577334b4
Add support for configuring the PLCA Reconciliation Sublayer on
multi-drop PHYs that support IEEE802.3cg-2019 Clause 148 (e.g.,
10BASE-T1S). This patch adds the appropriate netlink interface
to ethtool.
Signed-off-by: Piergiorgio Beruto <piergiorgio.beruto@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>