kernel/linux.git/lib/dim/net_dim.c, branch v5.4.107Linux kernel stable tree (mirror)https://git.radix-linux.su/kernel/linux.git/atom?h=v5.4.1072019-07-25T18:34:39+00:00lib/dim: Fix -Wunused-const-variable warnings2019-07-25T18:34:39+00:00Leon Romanovskyleonro@mellanox.com2019-07-23T07:22:48+00:00urn:sha1:f8be17b81d44aed1f9ea68c3fc70f501c9616e2d
DIM causes to the following warnings during kernel compilation
which indicates that tx_profile and rx_profile are supposed to
be declared in *.c and not in *.h files.
In file included from ./include/rdma/ib_verbs.h:64,
from ./include/linux/mlx5/device.h:37,
from ./include/linux/mlx5/driver.h:51,
from ./include/linux/mlx5/vport.h:36,
from drivers/infiniband/hw/mlx5/ib_virt.c:34:
./include/linux/dim.h:326:1: warning: _tx_profile_ defined but not used [-Wunused-const-variable=]
326 | tx_profile[DIM_CQ_PERIOD_NUM_MODES][NET_DIM_PARAMS_NUM_PROFILES] = {
| ^~~~~~~~~~
./include/linux/dim.h:320:1: warning: _rx_profile_ defined but not used [-Wunused-const-variable=]
320 | rx_profile[DIM_CQ_PERIOD_NUM_MODES][NET_DIM_PARAMS_NUM_PROFILES] = {
| ^~~~~~~~~~
Fixes: 4f75da3666c0 ("linux/dim: Move implementation to .c files")
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Acked-by: Saeed Mahameed <saeedm@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
linux/dim: Move implementation to .c files2019-06-25T20:46:39+00:00Tal Gilboatalgi@mellanox.com2019-01-10T15:33:17+00:00urn:sha1:4f75da3666c0c572967729a2401ac650be5581b6
Moved all logic from dim.h and net_dim.h to dim.c and net_dim.c.
This is both more structurally appealing and would allow to only
expose externally used functions.
Signed-off-by: Tal Gilboa <talgi@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>