kernel/linux.git/io_uring/slist.h, branch v6.12.80Linux kernel stable tree (mirror)https://git.radix-linux.su/kernel/linux.git/atom?h=v6.12.802023-03-09T17:10:58+00:00io_uring: silence variable ‘prev’ set but not used warning2023-03-09T17:10:58+00:00Jens Axboeaxboe@kernel.dk2023-03-09T16:51:13+00:00urn:sha1:fa780334a8c392d959ae05eb19f2410b3a1e6cb0
If io_uring.o is built with W=1, it triggers a warning:
io_uring/io_uring.c: In function ‘__io_submit_flush_completions’:
io_uring/io_uring.c:1502:40: warning: variable ‘prev’ set but not used [-Wunused-but-set-variable]
1502 | struct io_wq_work_node *node, *prev;
| ^~~~
which is due to the wq_list_for_each() iterator always keeping a 'prev'
variable. Most users need this to remove an entry from a list, for
example, but __io_submit_flush_completions() never does that.
Add a basic helper that doesn't track prev instead, and use that in
that function.
Reported-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Reviewed-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
io_uring: remove unused wq_list_merge2023-02-22T16:57:23+00:00Pavel Begunkovasml.silence@gmail.com2023-02-22T14:32:43+00:00urn:sha1:9a1563d1720680bdc1d702486b7b73f51c079b32
There are no users of wq_list_merge, kill it.
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/5f9ad0301949213230ad9000a8359d591aae615a.1677002255.git.asml.silence@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
io_uring: move list helpers to a separate file2022-07-25T00:39:15+00:00Pavel Begunkovasml.silence@gmail.com2022-06-21T09:09:01+00:00urn:sha1:a6b21fbb4ce3c4976ba478a9f0f10d4163038478
It's annoying to have io-wq.h as a dependency every time we want some of
struct io_wq_work_list helpers, move them into a separate file.
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/c1d891ce12b30767d1d2a3b7db2ca3abc1ecc4a2.1655802465.git.asml.silence@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>