kernel/linux.git/include/net/inetpeer.h, branch v3.10.47

net: fix inet_getid() and ipv6_select_ident() bugs

2014-06-26T19:12:38+00:00

[ Upstream commit 39c36094d78c39e038c1e499b2364e13bce36f54 ] I noticed we were sending wrong IPv4 ID in TCP flows when MTU discovery is disabled. Note how GSO/TSO packets do not have monotonically incrementing ID. 06:37:41.575531 IP (id 14227, proto: TCP (6), length: 4396) 06:37:41.575534 IP (id 14272, proto: TCP (6), length: 65212) 06:37:41.575544 IP (id 14312, proto: TCP (6), length: 57972) 06:37:41.575678 IP (id 14317, proto: TCP (6), length: 7292) 06:37:41.575683 IP (id 14361, proto: TCP (6), length: 63764) It appears I introduced this bug in linux-3.1. inet_getid() must return the old value of peer->ip_id_count, not the new one. Lets revert this part, and remove the prevention of a null identification field in IPv6 Fragment Extension Header, which is dubious and not even done properly. Fixes: 87c48fa3b463 ("ipv6: make fragment identifications less predictable") Signed-off-by: Eric Dumazet Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman

ipv4: Maintain redirect and PMTU info in struct rtable again.

2012-07-11T05:40:14+00:00

Maintaining this in the inetpeer entries was not the right way to do this at all. Signed-off-by: David S. Miller

tcp: Move timestamps from inetpeer to metrics cache.

2012-07-11T05:40:08+00:00

With help from Lin Ming. Signed-off-by: David S. Miller

inet: Avoid potential NULL peer dereference.

2012-06-11T11:13:57+00:00

We handle NULL in rt{,6}_set_peer but then our caller will try to pass that NULL pointer into inet_putpeer() which isn't ready for it. Fix this by moving the NULL check one level up, and then remove the now unnecessary NULL check from inetpeer_ptr_set_peer(). Reported-by: Eric Dumazet Signed-off-by: David S. Miller

inet: Add family scope inetpeer flushes.

2012-06-11T09:09:10+00:00

This implementation can deal with having many inetpeer roots, which is a necessary prerequisite for per-FIB table rooted peer tables. Each family (AF_INET, AF_INET6) has a sequence number which we bump when we get a family invalidation request. Each peer lookup cheaply checks whether the flush sequence of the root we are using is out of date, and if so flushes it and updates the sequence number. Signed-off-by: David S. Miller

inet: Hide route peer accesses behind helpers.

2012-06-11T09:08:47+00:00

We encode the pointer(s) into an unsigned long with one state bit. The state bit is used so we can store the inetpeer tree root to use when resolving the peer later. Later the peer roots will be per-FIB table, and this change works to facilitate that. Signed-off-by: David S. Miller

inet: Pass inetpeer root into inet_getpeer*() interfaces.

2012-06-10T02:12:36+00:00

Otherwise we reference potentially non-existing members when ipv6 is disabled. Signed-off-by: David S. Miller

inet: Consolidate inetpeer_invalidate_tree() interfaces.

2012-06-09T23:32:41+00:00

We only need one interface for this operation, since we always know which inetpeer root we want to flush. Signed-off-by: David S. Miller

inet: Initialize per-netns inetpeer roots in net/ipv{4,6}/route.c

2012-06-09T23:27:05+00:00

Instead of net/ipv4/inetpeer.c Signed-off-by: David S. Miller

inetpeer: add parameter net for inet_getpeer_v4,v6

2012-06-08T21:27:23+00:00

add struct net as a parameter of inet_getpeer_v[4,6], use net to replace &init_net. and modify some places to provide net for inet_getpeer_v[4,6] Signed-off-by: Gao feng Signed-off-by: David S. Miller