kernel/linux.git/include/net/devlink.h, branch v5.16.1

ethtool: don't drop the rtnl_lock half way thru the ioctl

2021-11-01T13:26:07+00:00

devlink compat code needs to drop rtnl_lock to take devlink->lock to ensure correct lock ordering. This is problematic because we're not strictly guaranteed that the netdev will not disappear after we re-lock. It may open a possibility of nested ->begin / ->complete calls. Instead of calling into devlink under rtnl_lock take a ref on the devlink instance and make the call after we've dropped rtnl_lock. We (continue to) assume that netdevs have an implicit reference on the devlink returned from ndo_get_devlink_port Note that ndo_get_devlink_port will now get called under rtnl_lock. That should be fine since none of the drivers seem to be taking serious locks inside ndo_get_devlink_port. Signed-off-by: Jakub Kicinski Reviewed-by: Leon Romanovsky Signed-off-by: David S. Miller

devlink: expose get/put functions

2021-11-01T13:26:07+00:00

Allow those who hold implicit reference on a devlink instance to try to take a full ref on it. This will be used from netdev code which has an implicit ref because of driver call ordering. Note that after recent changes devlink_unregister() may happen before netdev unregister, but devlink_free() should still happen after, so we are safe to try, but we can't just refcount_inc() and assume it's not zero. Signed-off-by: Jakub Kicinski Reviewed-by: Leon Romanovsky Signed-off-by: David S. Miller

devlink: Delete obsolete parameters publish API

2021-10-22T23:15:41+00:00

The change of devlink_register() to be last devlink command together with delayed notification logic made the publish API to be obsolete. Signed-off-by: Leon Romanovsky Signed-off-by: Jakub Kicinski

devlink: Delete reload enable/disable interface

2021-10-12T23:29:17+00:00

Commit a0c76345e3d3 ("devlink: disallow reload operation during device cleanup") added devlink_reload_{enable,disable}() APIs to prevent reload operation from racing with device probe/dismantle. After recent changes to move devlink_register() to the end of device probe and devlink_unregister() to the beginning of device dismantle, these races can no longer happen. Reload operations will be denied if the devlink instance is unregistered and devlink_unregister() will block until all in-flight operations are done. Therefore, remove these devlink_reload_{enable,disable}() APIs. Signed-off-by: Leon Romanovsky Signed-off-by: Jakub Kicinski

devlink: Allow control devlink ops behavior through feature mask

2021-10-12T23:29:17+00:00

Introduce new devlink call to set feature mask to control devlink behavior during device initialization phase after devlink_alloc() is already called. This allows us to set reload ops based on device property which is not known at the beginning of driver initialization. For the sake of simplicity, this API lacks any type of locking and needs to be called before devlink_register() to make sure that no parallel access to the ops is possible at this stage. Signed-off-by: Leon Romanovsky Signed-off-by: Jakub Kicinski

devlink: Move netdev_to_devlink helpers to devlink.c

2021-10-12T23:29:16+00:00

Both netdev_to_devlink and netdev_to_devlink_port are used in devlink.c only, so move them in order to reduce their scope. Signed-off-by: Leon Romanovsky Signed-off-by: Jakub Kicinski

devlink: Reduce struct devlink exposure

2021-10-12T23:29:16+00:00

The declaration of struct devlink in general header provokes the situation where internal fields can be accidentally used by the driver authors. In order to reduce such possible situations, let's reduce the namespace exposure of struct devlink. Signed-off-by: Leon Romanovsky Signed-off-by: Jakub Kicinski

devlink: Delete not used port parameters APIs

2021-09-24T13:12:56+00:00

There is no in-kernel users for the devlink port parameters API, so let's remove it. Signed-off-by: Leon Romanovsky Signed-off-by: David S. Miller

devlink: Make devlink_register to be void

2021-09-22T13:15:12+00:00

devlink_register() can't fail and always returns success, but all drivers are obligated to check returned status anyway. This adds a lot of boilerplate code to handle impossible flow. Make devlink_register() void and simplify the drivers that use that API call. Signed-off-by: Leon Romanovsky Acked-by: Simon Horman Acked-by: Vladimir Oltean # dsa Reviewed-by: Jiri Pirko Signed-off-by: David S. Miller

devlink: Delete not-used devlink APIs

2021-09-17T13:19:39+00:00

Devlink core exported generously the functions calls that were used by netdevsim tests or not used at all. Delete such APIs with one exception - devlink_alloc_ns(). That function should be spared from deleting because it is a special form of devlink_alloc() needed for the netdevsim. Signed-off-by: Leon Romanovsky Acked-by: Jakub Kicinski Reviewed-by: Jiri Pirko Signed-off-by: David S. Miller