kernel/linux.git/include/linux/sunrpc/svc.h, branch v6.4.11

SUNRPC: Relocate svc_free_res_pages()

2023-04-26T13:05:01+00:00

Clean-up: There doesn't seem to be a reason why this function is stuck in a header. One thing it prevents is the convenient addition of tracing. Moving it to a source file also makes the rq_respages clean-up logic easier to find. Reviewed-by: Calum Mackay Signed-off-by: Chuck Lever

SUNRPC: Ignore return value of ->xpo_sendto

2023-04-26T13:05:01+00:00

Clean up: All callers of svc_process() ignore its return value, so svc_process() can safely be converted to return void. Ditto for svc_send(). The return value of ->xpo_sendto() is now used only as part of a trace event. Signed-off-by: Chuck Lever

NFSD: Watch for rq_pages bounds checking errors in nfsd_splice_actor()

2023-04-26T13:05:01+00:00

There have been several bugs over the years where the NFSD splice actor has attempted to write outside the rq_pages array. This is a "should never happen" condition, but if for some reason the pipe splice actor should attempt to walk past the end of rq_pages, it needs to terminate the READ operation to prevent corruption of the pointer addresses in the fields just beyond the array. A server crash is thus prevented. Since the code is not behaving, the READ operation returns -EIO to the client. None of the READ payload data can be trusted if the splice actor isn't operating as expected. Suggested-by: Jeff Layton Signed-off-by: Chuck Lever Reviewed-by: Jeff Layton

SUNRPC: Replace pool stats with per-CPU variables

2023-02-20T14:20:32+00:00

Eliminate the use of bus-locked operations in svc_xprt_enqueue(), which is a hot path. Replace them with per-cpu variables to reduce cross-CPU memory bus traffic. Signed-off-by: Chuck Lever

SUNRPC: Use per-CPU counters to tally server RPC counts

2023-02-20T14:20:32+00:00

- Improves counting accuracy - Reduces cross-CPU memory traffic Signed-off-by: Chuck Lever

SUNRPC: Set rq_accept_statp inside ->accept methods

2023-02-20T14:20:31+00:00

To navigate around the space that svcauth_gss_accept() reserves for the RPC payload body length and sequence number fields, svcauth_gss_release() does a little dance with the reply's accept_stat, moving the accept_stat value in the response buffer down by two words. Instead, let's have the ->accept() methods each set the proper final location of the accept_stat to avoid having to move things. Reviewed-by: Jeff Layton Signed-off-by: Chuck Lever

SUNRPC: Refactor RPC server dispatch method

2023-02-20T14:20:31+00:00

Currently, svcauth_gss_accept() pre-reserves response buffer space for the RPC payload length and GSS sequence number before returning to the dispatcher, which then adds the header's accept_stat field. The problem is the accept_stat field is supposed to go before the length and seq_num fields. So svcauth_gss_release() has to relocate the accept_stat value (see svcauth_gss_prepare_to_wrap()). To enable these fields to be added to the response buffer in the correct (final) order, the pointer to the accept_stat has to be made available to svcauth_gss_accept() so that it can set it before reserving space for the length and seq_num fields. As a first step, move the pointer to the location of the accept_stat field into struct svc_rqst. Reviewed-by: Jeff Layton Signed-off-by: Chuck Lever

SUNRPC: Remove no-longer-used helper functions

2023-02-20T14:20:31+00:00

The svc_get/put helpers are no longer used. Reviewed-by: Jeff Layton Signed-off-by: Chuck Lever

SUNRPC: Convert unwrap data paths to use xdr_stream for replies

2023-02-20T14:20:28+00:00

We're now moving svcxdr_init_encode() to /before/ the flavor's ->accept method has set rq_auth_slack. Add a helper that can set rq_auth_slack /after/ svcxdr_init_encode() has been called. Reviewed-by: Jeff Layton Signed-off-by: Chuck Lever

sunrpc: svc: Remove an unused static function svc_ungetu32()

2022-12-10T15:59:30+00:00

The svc_ungetu32 function is not used, you could remove it. Signed-off-by: Li zeming Signed-off-by: Chuck Lever