kernel/linux.git/include/linux/nfs_page.h, branch v5.10.257

NFS: Fix a race when updating an existing write

2025-09-04T12:41:42+00:00

commit 76d2e3890fb169168c73f2e4f8375c7cc24a765e upstream. After nfs_lock_and_join_requests() tests for whether the request is still attached to the mapping, nothing prevents a call to nfs_inode_remove_request() from succeeding until we actually lock the page group. The reason is that whoever called nfs_inode_remove_request() doesn't necessarily have a lock on the page group head. So in order to avoid races, let's take the page group lock earlier in nfs_lock_and_join_requests(), and hold it across the removal of the request in nfs_inode_remove_request(). Reported-by: Jeff Layton Tested-by: Joe Quanaim Tested-by: Andrew Steffen Reviewed-by: Jeff Layton Fixes: bd37d6fce184 ("NFSv4: Convert nfs_lock_and_join_requests() to use nfs_page_find_head_request()") Cc: stable@vger.kernel.org Signed-off-by: Greg Kroah-Hartman Signed-off-by: Trond Myklebust

nfs: fold nfs_page_group_lock_subrequests into nfs_lock_and_join_requests

2025-09-04T12:41:42+00:00

commit 25edbcac6e32eab345e470d56ca9974a577b878b upstream. Fold nfs_page_group_lock_subrequests into nfs_lock_and_join_requests to prepare for future changes to this code, and move the helpers to write.c as well. Signed-off-by: Christoph Hellwig Reviewed-by: Sagi Grimberg Signed-off-by: Anna Schumaker Signed-off-by: Trond Myklebust Signed-off-by: Greg Kroah-Hartman

NFS: Use the correct commit info in nfs_join_page_group()

2023-10-10T19:53:24+00:00

[ Upstream commit b193a78ddb5ee7dba074d3f28dc050069ba083c0 ] Ensure that nfs_clear_request_commit() updates the correct counters when it removes them from the commit list. Fixes: ed5d588fe47f ("NFS: Try to join page groups before an O_DIRECT retransmission") Signed-off-by: Trond Myklebust Signed-off-by: Anna Schumaker Signed-off-by: Sasha Levin

pNFS/flexfiles: Fix array overflow when flexfiles mirroring is enabled

2020-11-30T15:52:22+00:00

If the flexfiles mirroring is enabled, then the read code expects to be able to set pgio->pg_mirror_idx to point to the data server that is being used for this particular read. However it does not change the pg_mirror_count because we only need to send a single read. Signed-off-by: Trond Myklebust Signed-off-by: Anna Schumaker

NFS: Try to join page groups before an O_DIRECT retransmission

2020-04-01T17:37:57+00:00

If we have to retransmit requests, try to join their page groups first. Signed-off-by: Trond Myklebust

NFS: Refactor nfs_lock_and_join_requests()

2020-04-01T17:37:56+00:00

Refactor nfs_lock_and_join_requests() in order to separate out the subrequest merging into its own function nfs_lock_and_join_group() that can be used by O_DIRECT. Signed-off-by: Trond Myklebust

NFS: Clean up nfs_lock_and_join_requests()

2020-04-01T17:37:56+00:00

Clean up nfs_lock_and_join_requests() to simplify the calculation of the range covered by the page group, taking into account the presence of mirrors. Signed-off-by: Trond Myklebust

NFS: Fix races nfs_page_group_destroy() vs nfs_destroy_unlinked_subrequests()

2020-04-01T17:34:28+00:00

When a subrequest is being detached from the subgroup, we want to ensure that it is not holding the group lock, or in the process of waiting for the group lock. Fixes: 5b2b5187fa85 ("NFS: Fix nfs_page_group_destroy() and nfs_lock_and_join_requests() race cases") Signed-off-by: Trond Myklebust

NFS: Remove redundant open context from nfs_page

2019-04-25T18:18:15+00:00

The lock context already references and tracks the open context, so take the opportunity to save some space in struct nfs_page. Signed-off-by: Trond Myklebust Signed-off-by: Anna Schumaker

NFS: Add a helper to return a pointer to the open context of a struct nfs_page

2019-04-25T18:18:15+00:00

Add a helper for when we remove the explicit pointer to the open context. Signed-off-by: Trond Myklebust Signed-off-by: Anna Schumaker