Linux kernel stable tree (mirror) https://git.radix-linux.su/kernel/linux.git/atom?h=v3.4.90 2013-12-12T06:34:12+00:00 2013-12-12T06:34:12+00:00 Tom Lendacky thomas.lendacky@amd.com 2013-12-05T19:09:53+00:00 urn:sha1:4062191e84141d4549a38a25de09f886e2e344d8 commit 389a5390583a18e45bc4abd4439291abec5e7a63 upstream. Now that scatterwalk_sg_chain sets the chain pointer bit the sg_page call in scatterwalk_sg_next hits a BUG_ON when CONFIG_DEBUG_SG is enabled. Use sg_chain_ptr instead of sg_page on a chain entry. Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 2013-12-12T06:34:10+00:00 Tom Lendacky thomas.lendacky@amd.com 2013-11-12T17:46:10+00:00 urn:sha1:941f77dc3c2b264051fba4726461fec919822041 commit 41da8b5adba77e22584f8b45f9641504fa885308 upstream. The scatterwalk_crypto_chain function invokes the scatterwalk_sg_chain function to chain two scatterlists, but the chain pointer indication bit is not set. When the resulting scatterlist is used, for example, by sg_nents to count the number of scatterlist entries, a segfault occurs because sg_nents does not follow the chain pointer to the chained scatterlist. Update scatterwalk_sg_chain to set the chain pointer indication bit as is done by the sg_chain function. Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 2012-03-20T13:48:16+00:00 Cong Wang amwang@redhat.com 2011-11-25T15:14:17+00:00 urn:sha1:f0dfc0b0b7f3d961da8a98bcfccc8be9107a848b Signed-off-by: Cong Wang <amwang@redhat.com> 2010-12-02T06:47:15+00:00 Steffen Klassert steffen.klassert@secunet.com 2010-11-22T10:25:50+00:00 urn:sha1:079f2f7485648c1397a35575fae45908a0db5ba6 A lot of crypto algorithms implement their own chaining function. So add a generic one that can be used from all the algorithms that need scatterlist chaining. Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2008-05-01T10:22:28+00:00 Herbert Xu herbert@gondor.apana.org.au 2008-04-29T13:53:52+00:00 urn:sha1:8ec970d8561abb5645d4602433b772e268c96d05 When I backed out of using the generic sg chaining (as it isn't currently portable) and introduced scatterwalk_sg_chain/scatterwalk_sg_next I left out the sg_is_last check in the latter. This causes it to potentially dereference beyond the end of the sg array. As most uses of scatterwalk_sg_next are bound by an overall length, this only affected the chaining code in authenc and eseqiv. Thanks to Patrick McHardy for identifying this problem. This patch also clears the "last" bit on the head of the chained list as it's no longer last. This also went missing in scatterwalk_sg_chain and is present in sg_chain. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2008-01-10T21:16:59+00:00 Herbert Xu herbert@gondor.apana.org.au 2007-12-24T00:54:24+00:00 urn:sha1:1c5dfe6a959b79215c0f73d793169a7d5755900e As Andrew Morton correctly points out, we need to explicitly include sched.h as we use the function cond_resched in crypto/scatterwalk.h. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2008-01-10T21:16:33+00:00 Herbert Xu herbert@gondor.apana.org.au 2007-12-05T09:59:25+00:00 urn:sha1:b2ab4a57b018aafbba35bff088218f5cc3d2142e Unfortunately the generic chaining hasn't been ported to all architectures yet, and notably not s390. So this patch restores the chainging that we've been using previously which does work everywhere. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2008-01-10T21:16:32+00:00 Herbert Xu herbert@gondor.apana.org.au 2007-12-07T10:52:49+00:00 urn:sha1:42c271c6c538857cb13c5ead5184d264d745f675 The scatterwalk infrastructure is used by algorithms so it needs to move out of crypto for future users that may live in drivers/crypto or asm/*/crypto. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>