kernel/linux.git/include/crypto/internal/skcipher.h, branch v6.19.11

Revert "crypto: scatterwalk - Move skcipher walk and use it for memcpy_sglist"

2025-11-22T02:04:50+00:00

This reverts commit 0f8d42bf128d349ad490e87d5574d211245e40f1, with the memcpy_sglist() part dropped. Now that memcpy_sglist() no longer uses the skcipher_walk code, the skcipher_walk code can be moved back to where it belongs. Signed-off-by: Eric Biggers Signed-off-by: Herbert Xu

crypto: scatterwalk - Move skcipher walk and use it for memcpy_sglist

2025-04-28T11:45:26+00:00

Move the generic part of skcipher walk into scatterwalk, and use it to implement memcpy_sglist. This makes memcpy_sglist do the right thing when two distinct SG lists contain identical subsets (e.g., the AD part of AEAD). Signed-off-by: Herbert Xu

crypto: skcipher - Realign struct skcipher_walk to save 8 bytes

2025-04-16T07:36:24+00:00

Reduce skcipher_walk's struct size by 8 bytes by realigning its members. pahole output before: /* size: 120, cachelines: 2, members: 13 */ /* sum members: 108, holes: 2, sum holes: 8 */ /* padding: 4 */ /* last cacheline: 56 bytes */ and after: /* size: 112, cachelines: 2, members: 13 */ /* padding: 4 */ /* last cacheline: 48 bytes */ No functional changes intended. Signed-off-by: Thorsten Blum Signed-off-by: Herbert Xu

crypto: skcipher - Make skcipher_walk src.virt.addr const

2025-03-15T08:21:22+00:00

Mark the src.virt.addr field in struct skcipher_walk as a pointer to const data. This guarantees that the user won't modify the data which should be done through dst.virt.addr to ensure that flushing is done when necessary. Signed-off-by: Herbert Xu

crypto: skcipher - Eliminate duplicate virt.addr field

2025-03-15T08:21:22+00:00

Reuse the addr field from struct scatter_walk for skcipher_walk. Keep the existing virt.addr fields but make them const for the user to access the mapped address. Signed-off-by: Herbert Xu

crypto: skcipher - Use restrict rather than hand-rolling accesses

2025-03-02T07:21:47+00:00

Rather than accessing 'alg' directly to avoid the aliasing issue which leads to unnecessary reloads, use the __restrict keyword to explicitly tell the compiler that there is no aliasing. This generates equivalent if not superior code on x86 with gcc 12. Note that in skcipher_walk_virt the alg assignment is moved after might_sleep_if because that function is a compiler barrier and forces a reload. Signed-off-by: Herbert Xu

crypto: skcipher - document skcipher_walk_done() and rename some vars

2025-01-14T03:38:32+00:00

skcipher_walk_done() has an unusual calling convention, and some of its local variables have unclear names. Document it and rename variables to make it a bit clearer what is going on. No change in behavior. Signed-off-by: Eric Biggers Signed-off-by: Herbert Xu

crypto: skcipher - remove support for physical address walks

2024-12-14T09:21:43+00:00

Since the physical address support in skcipher_walk is not used anymore, remove all the code associated with it. This includes: - The skcipher_walk_async() and skcipher_walk_complete() functions; - The SKCIPHER_WALK_PHYS flag and everything conditional on it; - The buffers, phys, and virt.page fields in struct skcipher_walk; - struct skcipher_walk_buffer. As a result, skcipher_walk now just supports virtual addresses. Physical address support in skcipher_walk is unneeded because drivers that need physical addresses just use the scatterlists directly. Signed-off-by: Eric Biggers Signed-off-by: Herbert Xu

crypto: skcipher - Remove obsolete skcipher_alg helpers

2023-10-13T10:27:27+00:00

As skcipher spawn users can no longer assume the spawn is of type struct skcipher_alg, these helpers are no longer used. Remove them. Signed-off-by: Herbert Xu

crypto: skcipher - Add crypto_spawn_skcipher_alg_common

2023-10-13T10:27:26+00:00

As skcipher spawns can be of two different types (skcipher vs. lskcipher), only the common fields can be accessed. Add a helper to return the common algorithm object. Signed-off-by: Herbert Xu