kernel/linux.git/fs/squashfs/namei.c, branch linux-4.4.y

Squashfs: fix corruption checks in squashfs_lookup()

2013-09-06T03:57:53+00:00

The dir_count and size fields when read from disk are sanity checked for correctness. However, the sanity checks only check the values are not greater than expected. As dir_count and size were incorrectly defined as signed ints, this can lead to corrupted values appearing as negative which are not trapped. Signed-off-by: Phillip Lougher

Squashfs: fix corruption check in get_dir_index_using_name()

2013-09-06T03:57:52+00:00

Patch "Squashfs: sanity check information from disk" from Dan Carpenter adds a missing check for corruption in the "size" field while reading the directory index from disk. It, however, sets err to -EINVAL, this value is not used later, and so setting it is completely redundant. So remove it. Errors in reading the index are deliberately non-fatal. If we get an error in reading the index we just return the part of the index we have managed to read - the index isn't essential, just quicker. Signed-off-by: Phillip Lougher

Squashfs: sanity check information from disk

2013-08-29T00:23:29+00:00

We read the size of the name from the disk, but a larger name than expected would cause memory corruption. Signed-off-by: Dan Carpenter Signed-off-by: Phillip Lougher

stop passing nameidata to ->lookup()

2012-07-14T12:34:32+00:00

Just the flags; only NFS cares even about that, but there are legitimate uses for such argument. And getting rid of that completely would require splitting ->lookup() into a couple of methods (at least), so let's leave that alone for now... Signed-off-by: Al Viro

Squashfs: remove redundant length initialisation in squashfs_lookup

2012-03-10T03:01:01+00:00

Signed-off-by: Phillip Lougher

Squashfs: use define instead of constant

2012-03-10T03:00:54+00:00

Its better to use defined name instead of constant Signed-off-by: Ajeet Yadav Signed-off-by: Phillip Lougher

make d_splice_alias(ERR_PTR(err), dentry) = ERR_PTR(err)

2011-07-20T05:44:26+00:00

... and simplify the living hell out of callers Signed-off-by: Al Viro

deuglify squashfs_lookup()

2011-07-20T05:44:24+00:00

d_splice_alias(NULL, dentry) is equivalent to d_add(dentry, NULL), NULL so no need for that if (inode) ... in there (or ERR_PTR(0), for that matter) Signed-off-by: Al Viro

Squashfs: update email address

2011-05-26T09:49:11+00:00

My existing email address may stop working in a month or two, so update email to one that will continue working. Signed-off-by: Phillip Lougher

Squashfs: handle corruption of directory structure

2011-03-16T01:04:18+00:00

Handle the rare case where a directory metadata block is uncompressed and corrupted, leading to a kernel oops in directory scanning (memcpy). Normally corruption is detected at the decompression stage and dealt with then, however, this will not happen if: - metadata isn't compressed (users can optionally request no metadata compression), or - the compressed metadata block was larger than the original, in which case the uncompressed version was used, or - the data was corrupt after decompression This patch fixes this by adding some sanity checks against known maximum values. Signed-off-by: Phillip Lougher