kernel/linux.git/fs/reiserfs/fix_node.c, branch v6.12.80

reiserfs: Replace one-element array with flexible-array member

2023-07-12T19:09:46+00:00

One-element arrays are deprecated, and we are replacing them with flexible array members instead. So, replace one-element array with flexible-array member in direntry_uarea structure, and refactor the rest of the code, accordingly. Worth mentioning is that before these changes, the original implementation was returning two-too many bytes in function direntry_create_vi(): fs/reiserfs/item_ops.c:464: int size = sizeof(struct direntry_uarea); ... fs/reiserfs/item_ops.c-490- size += (dir_u->entry_count * sizeof(short)); ... fs/reiserfs/item_ops.c-517- return size; Link: https://github.com/KSPP/linux/issues/79 Link: https://github.com/KSPP/linux/issues/290 Reviewed-by: Kees Cook Signed-off-by: Gustavo A. R. Silva

reiserfs: delete duplicated words

2020-08-05T08:29:57+00:00

Delete repeated words in fs/reiserfs/. {from, not, we, are} Link: https://lore.kernel.org/r/20200805024925.12281-1-rdunlap@infradead.org Signed-off-by: Randy Dunlap To: linux-fsdevel@vger.kernel.org Cc: Jan Kara Cc: Jeff Mahoney Cc: Andrew Morton Cc: reiserfs-devel@vger.kernel.org Signed-off-by: Jan Kara

fs/reiserfs/fix_node.c: remove set but not used variables

2019-09-26T00:51:40+00:00

fs/reiserfs/fix_node.c: In function get_num_ver: fs/reiserfs/fix_node.c:379:6: warning: variable cur_free set but not used [-Wunused-but-set-variable] fs/reiserfs/fix_node.c: In function dc_check_balance_internal: fs/reiserfs/fix_node.c:1737:6: warning: variable maxsize set but not used [-Wunused-but-set-variable] Link: http://lkml.kernel.org/r/1566379929-118398-7-git-send-email-zhengbin13@huawei.com Signed-off-by: zhengbin Reported-by: Hulk Robot Cc: Jan Kara Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds

reiserfs: balance_leaf refactor, move state variables into tree_balance

2014-05-07T16:31:06+00:00

This patch pushes the rest of the state variables in balance_leaf into the tree_balance structure so we can use them when we split balance_leaf into separate functions. Signed-off-by: Jeff Mahoney Signed-off-by: Jan Kara

reiserfs: cleanup, remove unnecessary parens

2014-05-06T21:18:16+00:00

The reiserfs code is littered with extra parens in places where the authors may not have been certain about precedence of & vs ->. This patch cleans them out. Signed-off-by: Jeff Mahoney Signed-off-by: Jan Kara

reiserfs: cleanup, remove leading whitespace from labels

2014-05-06T21:18:09+00:00

This patch moves reiserfs closer to adhering to the style rules by removing leading whitespace from labels. Signed-off-by: Jeff Mahoney Signed-off-by: Jan Kara

reiserfs: cleanup, remove sb argument from journal_mark_dirty

2014-05-06T21:10:37+00:00

journal_mark_dirty doesn't need a separate sb argument; It's provided by the transaction handle. Signed-off-by: Jeff Mahoney Signed-off-by: Jan Kara

reiserfs: cleanup, reformat comments to normal kernel style

2014-05-06T20:52:19+00:00

This patch reformats comments in the reiserfs code to fit in 80 columns and to follow the style rules. There is no functional change but it helps make my eyes bleed less. Signed-off-by: Jeff Mahoney Signed-off-by: Jan Kara

reiserfs: cleanup, rename key and item accessors to more friendly names

2014-05-06T20:51:44+00:00

This patch does a quick search and replace: B_N_PITEM_HEAD() -> item_head() B_N_PDELIM_KEY() -> internal_key() B_N_PKEY() -> leaf_key() B_N_PITEM() -> item_body() And the item_head version: B_I_PITEM() -> ih_item_body() I_ENTRY_COUNT() -> ih_entry_count() And the treepath variants: get_ih() -> tp_item_head() PATH_PITEM_HEAD() -> tp_item_head() get_item() -> tp_item_body() ... which makes the code much easier on the eyes. I've also removed a few unused macros. Checkpatch will complain about the 80 character limit for do_balan.c. I've addressed that in a later patchset to split up balance_leaf(). Signed-off-by: Jeff Mahoney Signed-off-by: Jan Kara

reiserfs: locking, handle nested locks properly

2013-08-08T21:34:46+00:00

The reiserfs write lock replaced the BKL and uses similar semantics. Frederic's locking code makes a distinction between when the lock is nested and when it's being acquired/released, but I don't think that's the right distinction to make. The right distinction is between the lock being released at end-of-use and the lock being released for a schedule. The unlock should return the depth and the lock should restore it, rather than the other way around as it is now. This patch implements that and adds a number of places where the lock should be dropped. Signed-off-by: Jeff Mahoney