kernel/linux.git/fs/lockd/xdr.c, branch v7.1

lockd: Add LOCKD_SHARE_SVID constant for DOS sharing mode

2026-03-30T01:25:09+00:00

Replace the magic value ~(u32)0 with a named constant. This value is used as a synthetic svid when looking up lockowners for DOS share operations, which have no real process ID associated with them. Reviewed-by: Jeff Layton Signed-off-by: Chuck Lever

lockd: Relocate include/linux/lockd/lockd.h

2026-03-30T01:25:09+00:00

Headers placed in include/linux/ form part of the kernel's internal API and signal to subsystem maintainers that other parts of the kernel may depend on them. By moving lockd.h into fs/lockd/, lockd becomes a more self-contained module whose internal interfaces are clearly distinguished from its public contract with the rest of the kernel. This relocation addresses a long-standing XXX comment in the header itself that acknowledged the file's misplacement. Future changes to lockd internals can now proceed with confidence that external consumers are not inadvertently coupled to implementation details. Reviewed-by: Jeff Layton Signed-off-by: Chuck Lever

lockd: adapt to breakup of struct file_lock

2024-02-05T12:11:43+00:00

Most of the existing APIs have remained the same, but subsystems that access file_lock fields directly need to reach into struct file_lock_core now. Signed-off-by: Jeff Layton Link: https://lore.kernel.org/r/20240131-flsplit-v3-40-c6129007ee8d@kernel.org Reviewed-by: NeilBrown Signed-off-by: Christian Brauner

SUNRPC: Change return value type of .pc_encode

2021-10-13T15:34:49+00:00

Returning an undecorated integer is an age-old trope, but it's not clear (even to previous experts in this code) that the only valid return values are 1 and 0. These functions do not return a negative errno, rpc_stat value, or a positive length. Document there are only two valid return values by having .pc_encode return only true or false. Signed-off-by: Chuck Lever Signed-off-by: J. Bruce Fields

SUNRPC: Replace the "__be32 *p" parameter to .pc_encode

2021-10-13T15:34:49+00:00

The passed-in value of the "__be32 *p" parameter is now unused in every server-side XDR encoder, and can be removed. Note also that there is a line in each encoder that sets up a local pointer to a struct xdr_stream. Passing that pointer from the dispatcher instead saves one line per encoder function. Signed-off-by: Chuck Lever Signed-off-by: J. Bruce Fields

SUNRPC: Change return value type of .pc_decode

2021-10-13T14:29:41+00:00

Returning an undecorated integer is an age-old trope, but it's not clear (even to previous experts in this code) that the only valid return values are 1 and 0. These functions do not return a negative errno, rpc_stat value, or a positive length. Document there are only two valid return values by having .pc_decode return only true or false. Signed-off-by: Chuck Lever Signed-off-by: J. Bruce Fields

SUNRPC: Replace the "__be32 *p" parameter to .pc_decode

2021-10-13T14:29:41+00:00

The passed-in value of the "__be32 *p" parameter is now unused in every server-side XDR decoder, and can be removed. Note also that there is a line in each decoder that sets up a local pointer to a struct xdr_stream. Passing that pointer from the dispatcher instead saves one line per decoder function. Signed-off-by: Chuck Lever Signed-off-by: J. Bruce Fields

lockd: Update the NLMv1 SHARE results encoder to use struct xdr_stream

2021-07-07T00:14:43+00:00

Signed-off-by: Chuck Lever Signed-off-by: J. Bruce Fields

lockd: Update the NLMv1 nlm_res results encoder to use struct xdr_stream

2021-07-07T00:14:43+00:00

Signed-off-by: Chuck Lever Signed-off-by: J. Bruce Fields

lockd: Update the NLMv1 TEST results encoder to use struct xdr_stream

2021-07-07T00:14:43+00:00

Signed-off-by: Chuck Lever Signed-off-by: J. Bruce Fields