kernel/linux.git/fs/dlm/midcomms.c, branch linux-6.0.y

dlm: check required context while close

2022-04-06T19:03:01+00:00

This patch adds a WARN_ON() check to validate the right context while dlm_midcomms_close() is called. Even before commit 489d8e559c65 ("fs: dlm: add reliable connection if reconnect") in this context dlm_lowcomms_close() flushes all ongoing transmission triggered by dlm application stack. If we do that, it's required that no new message will be triggered by the dlm application stack. The function dlm_midcomms_close() is not called often so we can check if all lockspaces are in such context. Signed-off-by: Alexander Aring Signed-off-by: David Teigland

dlm: move conversion to compile time

2022-04-06T19:02:40+00:00

This patch is a cleanup to move the byte order conversion to compile time. In a simple comparison like this it's possible to move it to static values so the compiler will always convert those values at compile time. Signed-off-by: Alexander Aring Signed-off-by: David Teigland

dlm: use __le types for dlm header

2022-04-06T19:02:28+00:00

This patch changes to use __le types directly in the dlm header structure which is casted at the right dlm message buffer positions. The main goal what is reached here is to remove sparse warnings regarding to host to little byte order conversion or vice versa. Leaving those sparse issues ignored and always do it in out/in functionality tends to leave it unknown in which byte order the variable is being handled. Signed-off-by: Alexander Aring Signed-off-by: David Teigland

dlm: add CHECKER for false positives

2022-04-06T19:02:20+00:00

This patch will adds #ifndef __CHECKER__ for false positives warnings about an imbalance lock/unlock srcu handling. Which are shown by running sparse checks: fs/dlm/midcomms.c:1065:20: warning: context imbalance in 'dlm_midcomms_get_mhandle' - wrong count at exit Using __CHECKER__ will tell sparse to ignore these sections. Those imbalances are false positive because from upper layer it is always required to call a function in sequence, e.g. if dlm_midcomms_get_mhandle() is successful there must be a dlm_midcomms_commit_mhandle() call afterwards. Signed-off-by: Alexander Aring Signed-off-by: David Teigland

fs: dlm: memory cache for midcomms hotpath

2021-12-07T18:42:26+00:00

This patch will introduce a kmem cache for allocating message handles which are needed for midcomms layer to take track of lowcomms messages. Signed-off-by: Alexander Aring Signed-off-by: David Teigland

fs: dlm:Remove unneeded semicolon

2021-11-05T18:03:34+00:00

Eliminate the following coccinelle check warning: fs/dlm/midcomms.c:972:2-3 Reported-by: Zeal Robot Signed-off-by: Zhang Mingyu Signed-off-by: David Teigland

fs: dlm: add debugfs rawmsg send functionality

2021-11-02T19:39:20+00:00

This patch adds a dlm functionality to send a raw dlm message to a specific cluster node. This raw message can be build by user space and send out by writing the message to "rawmsg" dlm debugfs file. There is a in progress scapy dlm module which provides a easy build of DLM messages in user space. For example: DLM(h_cmd=3, o_nextcmd=1, h_nodeid=1, h_lockspace=0xe4f48a18, ...) The goal is to provide an easy reproducable state to crash DLM or to fuzz the DLM kernel stack if there are possible ways to crash it. Note: that if the sequence number is zero and dlm version is not set to 3.1 the kernel will automatic will set a right sequence number, otherwise DLM stack testing is not possible. Signed-off-by: Alexander Aring Signed-off-by: David Teigland

fs: dlm: let handle callback data as void

2021-11-02T19:39:20+00:00

This patch changes the dlm_lowcomms_new_msg() function pointer private data from "struct mhandle *" to "void *" to provide different structures than just "struct mhandle". Signed-off-by: Alexander Aring Signed-off-by: David Teigland

fs: dlm: move version conversion to compile time

2021-11-02T19:39:20+00:00

This patch moves version conversion to little endian from a runtime variable to compile time constant. Signed-off-by: Alexander Aring Signed-off-by: David Teigland

fs: dlm: debug improvements print nodeid

2021-11-02T19:39:20+00:00

This patch improves the debug output for midcomms layer by also printing out the nodeid where users counter belongs to. Signed-off-by: Alexander Aring Signed-off-by: David Teigland

kernel/linux.git/fs/dlm/midcomms.c, branch linux-6.0.y

dlm: check required context while close

dlm: move conversion to compile time

dlm: use __le types for dlm header

dlm: add __CHECKER__ for false positives

fs: dlm: memory cache for midcomms hotpath

fs: dlm:Remove unneeded semicolon

fs: dlm: add debugfs rawmsg send functionality

fs: dlm: let handle callback data as void

fs: dlm: move version conversion to compile time

fs: dlm: debug improvements print nodeid

dlm: add CHECKER for false positives