kernel/linux.git/fs/btrfs/sysfs.c, branch linux-4.4.y

btrfs: sysfs: don't leak memory when failing add fsid

2019-06-11T10:23:52+00:00

commit e32773357d5cc271b1d23550b3ed026eb5c2a468 upstream. A failed call to kobject_init_and_add() must be followed by a call to kobject_put(). Currently in the error path when adding fs_devices we are missing this call. This could be fixed by calling btrfs_sysfs_remove_fsid() if btrfs_sysfs_add_fsid() returns an error or by adding a call to kobject_put() directly in btrfs_sysfs_add_fsid(). Here we choose the second option because it prevents the slightly unusual error path handling requirements of kobject from leaking out into btrfs functions. Add a call to kobject_put() in the error path of kobject_add_and_init(). This causes the release method to be called if kobject_init_and_add() fails. open_tree() is the function that calls btrfs_sysfs_add_fsid() and the error code in this function is already written with the assumption that the release method is called during the error path of open_tree() (as seen by the call to btrfs_sysfs_remove_fsid() under the fail_fsdev_sysfs label). Cc: stable@vger.kernel.org # v4.4+ Reviewed-by: Greg Kroah-Hartman Signed-off-by: Tobin C. Harding Reviewed-by: David Sterba Signed-off-by: David Sterba Signed-off-by: Greg Kroah-Hartman

Btrfs: rename super_kobj to fsid_kobj

2015-09-29T14:29:59+00:00

Signed-off-by: Anand Jain Signed-off-by: David Sterba

Btrfs: rename btrfs_kobj_rm_device to btrfs_sysfs_rm_device_link

2015-09-29T14:29:59+00:00

Signed-off-by: Anand Jain Signed-off-by: David Sterba

Btrfs: rename btrfs_kobj_add_device to btrfs_sysfs_add_device_link

2015-09-29T14:29:59+00:00

Signed-off-by: Anand Jain Signed-off-by: David Sterba

Btrfs: rename btrfs_sysfs_remove_one to btrfs_sysfs_remove_mounted

2015-09-29T14:29:58+00:00

Signed-off-by: Anand Jain Signed-off-by: David Sterba

Btrfs: rename btrfs_sysfs_add_one to btrfs_sysfs_add_mounted

2015-09-29T14:29:57+00:00

Signed-off-by: Anand Jain Signed-off-by: David Sterba

Btrfs: Check if kobject is initialized before put

2015-06-22T12:43:31+00:00

Signed-off-by: Anand Jain Tested-by: David Sterba Signed-off-by: David Sterba

Btrfs: sysfs: add support to add parent for fsid

2015-05-27T10:27:22+00:00

To support seed sysfs layout and represent seed fsid under the sprout we need the facility to create fsid under the specified parent. Signed-off-by: Anand Jain Signed-off-by: David Sterba

Btrfs: sysfs: separate kobject and attribute creation

2015-05-27T10:27:22+00:00

Signed-off-by: Anand Jain Signed-off-by: David Sterba

Btrfs: sysfs: btrfs_sysfs_remove_fsid() make it non static

2015-05-27T10:27:22+00:00

Signed-off-by: Anand Jain Signed-off-by: David Sterba