Linux kernel stable tree (mirror) https://git.radix-linux.su/kernel/linux.git/atom?h=v6.12.80 2024-10-05T00:25:31+00:00 2024-10-05T00:25:31+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-10-04T19:05:40+00:00 urn:sha1:658c82f41e8075e18b98b8705ed0cc34346f35c2 Newly generated keys, in the transaction commit path or write path, should not be AUTOFIX; those indicate bugs that we need to fail fast for. Fixes: 5612daafb764 ("bcachefs: Fix fsck warnings from bkey validation") Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 2024-09-28T01:46:35+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-09-26T20:51:19+00:00 urn:sha1:5612daafb76420c6793dc48ce6d0c20f36cc7981 __bch2_fsck_err() warns if the current task has a btree_trans object and it wasn't passed in, because if it has to prompt for user input it has to be able to unlock it. But plumbing the btree_trans through bkey_validate(), as well as transaction restarts, is problematic - so instead make bkey fsck errors FSCK_AUTOFIX, which doesn't need to warn. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 2024-08-14T03:00:50+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-08-13T01:31:25+00:00 urn:sha1:d97de0d017cde0d442c3d144b4f969f43064cc0f bkey_fsck_err() was added as an interface that looks like fsck_err(), but previously all it did was ensure that the appropriate error counter was incremented in the superblock. This is a cleanup and bugfix patch that converts it to a wrapper around fsck_err(). This is needed to fix an issue with the upgrade path to disk_accounting_v3, where the "silent fix" error list now includes bkey_fsck errors; fsck_err() handles this in a unified way, and since we need to change printing of bkey fsck errors from the caller to the inner bkey_fsck_err() calls, this ends up being a pretty big change. Als,, rename .invalid() methods to .validate(), for clarity, while we're changing the function signature anyways (to drop the printbuf argument). Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 2024-07-14T23:00:14+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-02-09T02:10:32+00:00 urn:sha1:a850bde6498b46d6e3143d8847f9aa9598491f9f fsck_err() now optionally takes a btree_trans; if the current thread has one, it is required that it be passed. The next patch will use this to unlock when waiting for user input. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 2024-07-14T23:00:12+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-06-07T20:35:42+00:00 urn:sha1:e76a2b65b0565f55ea668ec46d54f6a00b8ea9fc Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 2024-06-20T13:13:09+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-06-19T13:55:48+00:00 urn:sha1:33dfafa90285c0873a24d633877d505ab8e3fc20 i.e. the start of automatic self healing: If errors=continue or fix_safe, we now automatically fix simple errors without user intervention. New error action option: fix_safe This replaces the existing errors=ro option, which gets a new slot, i.e. existing errors=ro users now get errors=fix_safe. This is currently only enabled for a limited set of errors - initially just disk accounting; errors we would never not want to fix, and we don't want to require user intervention (i.e. to make sure a bug report gets filed). Errors will still be counted in the superblock, so we (developers) will still know they've been occuring if a bug report gets filed (as bug reports typically include the errors superblock section). Eventually we'll be enabling this for a much wider set of errors, after we've done thorough error injection testing. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 2024-04-01T00:36:11+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-03-23T23:29:19+00:00 urn:sha1:79032b078173f87a13f8618cdab710798be67314 Consolidate bch2_gc_check_topology() and btree_node_interior_verify(), and replace them with an improved version, bch2_btree_node_check_topology(). This checks that children of an interior node correctly span the full range of the parent node with no overlaps. Also, ensure that topology repairs at runtime are always a fatal error; in particular, this adds a check in btree_iter_down() - if we don't find a key while walking down the btree that's indicative of a topology error and should be flagged as such, not a null ptr deref. Some checks in btree_update_interior.c remaining BUG_ONS(), because we already checked the node for topology errors when starting the update, and the assertions indicate that we _just_ corrupted the btree node - i.e. the problem can't be that existing on disk corruption, they indicate an actual algorithmic bug. In the future, we'll be annotating the fsck errors list with which recovery pass corrects them; the open coded "run explicit recovery pass or fatal error" in bch2_btree_node_check_topology() will in the future be done for every fsck_err() call. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 2024-03-18T04:24:24+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-03-18T01:51:19+00:00 urn:sha1:3ed94062e3801e3fd9924ccd54b607abf58cc223 error messages should always include __func__ Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 2024-03-14T01:22:23+00:00 Kent Overstreet kent.overstreet@linux.dev 2024-02-06T22:24:18+00:00 urn:sha1:52946d828aac5bc8e20665a8434f87740fad03e3 This converts -EIOs related to btree node errors to private error codes, which will help with some ongoing debugging by giving us better error messages. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> 2023-12-20T00:01:52+00:00 Kent Overstreet kent.overstreet@linux.dev 2023-12-13T05:44:34+00:00 urn:sha1:b0c279ff6cc97a34d8caaf28381e72bb111b5e16 Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>