kernel/linux.git/fs/bcachefs/error.c, branch v6.12.80

bcachefs: Fix __bch2_fsck_err() warning

2024-10-20T20:50:14+00:00

We only warn about having a btree_trans that wasn't passed in if we'll be prompting. Signed-off-by: Kent Overstreet

bcachefs: Make sure we print error that causes fsck to bail out

2024-10-05T00:25:31+00:00

Signed-off-by: Kent Overstreet

bcachefs: bkey errors are only AUTOFIX during read

2024-10-05T00:25:31+00:00

Newly generated keys, in the transaction commit path or write path, should not be AUTOFIX; those indicate bugs that we need to fail fast for. Fixes: 5612daafb764 ("bcachefs: Fix fsck warnings from bkey validation") Signed-off-by: Kent Overstreet

bcachefs: Fix fsck warnings from bkey validation

2024-09-28T01:46:35+00:00

__bch2_fsck_err() warns if the current task has a btree_trans object and it wasn't passed in, because if it has to prompt for user input it has to be able to unlock it. But plumbing the btree_trans through bkey_validate(), as well as transaction restarts, is problematic - so instead make bkey fsck errors FSCK_AUTOFIX, which doesn't need to warn. Signed-off-by: Kent Overstreet

bcachefs: Make bkey_fsck_err() a wrapper around fsck_err()

2024-08-14T03:00:50+00:00

bkey_fsck_err() was added as an interface that looks like fsck_err(), but previously all it did was ensure that the appropriate error counter was incremented in the superblock. This is a cleanup and bugfix patch that converts it to a wrapper around fsck_err(). This is needed to fix an issue with the upgrade path to disk_accounting_v3, where the "silent fix" error list now includes bkey_fsck errors; fsck_err() handles this in a unified way, and since we need to change printing of bkey fsck errors from the caller to the inner bkey_fsck_err() calls, this ends up being a pretty big change. Als,, rename .invalid() methods to .validate(), for clarity, while we're changing the function signature anyways (to drop the printbuf argument). Signed-off-by: Kent Overstreet

bcachefs: Unlock trans when waiting for user input in fsck

2024-07-14T23:00:14+00:00

We can't hold locks while waiting for user input, that's a deadlock. Signed-off-by: Kent Overstreet

bcachefs: twf: convert bch2_stdio_redirect_readline() to darray

2024-07-14T23:00:14+00:00

We now read the line from the buffer atomically, which means we have to allow the buffer to grow past STDIO_REDIRECT_BUFSIZE if we're waiting for a full line - this behaviour is necessary for stdio_redirect_readline_timeout() in the next patch. Signed-off-by: Kent Overstreet

bcachefs: fsck_err() may now take a btree_trans

2024-07-14T23:00:14+00:00

fsck_err() now optionally takes a btree_trans; if the current thread has one, it is required that it be passed. The next patch will use this to unlock when waiting for user input. Signed-off-by: Kent Overstreet

bcachefs: add might_sleep() annotations for fsck_err()

2024-07-14T23:00:12+00:00

Signed-off-by: Kent Overstreet

bcachefs: Fix safe errors by default

2024-06-20T13:13:09+00:00

i.e. the start of automatic self healing: If errors=continue or fix_safe, we now automatically fix simple errors without user intervention. New error action option: fix_safe This replaces the existing errors=ro option, which gets a new slot, i.e. existing errors=ro users now get errors=fix_safe. This is currently only enabled for a limited set of errors - initially just disk accounting; errors we would never not want to fix, and we don't want to require user intervention (i.e. to make sure a bug report gets filed). Errors will still be counted in the superblock, so we (developers) will still know they've been occuring if a bug report gets filed (as bug reports typically include the errors superblock section). Eventually we'll be enabling this for a much wider set of errors, after we've done thorough error injection testing. Signed-off-by: Kent Overstreet