kernel/linux.git/fs/bcachefs/debug.c, branch v6.12.80

bcachefs: Convert for_each_btree_node() to lockrestart_do()

2024-08-14T02:56:50+00:00

for_each_btree_node() now works similarly to for_each_btree_key(), where the loop body is passed as an argument to be passed to lockrestart_do(). This now calls trans_begin() on every loop iteration - which fixes an SRCU warning in backpointers fsck. Signed-off-by: Kent Overstreet

bcachefs: Fix loop restart in bch2_btree_transactions_read()

2024-06-29T01:08:48+00:00

Accidental infinite loop; also fix btree_deadlock_to_text() Signed-off-by: Kent Overstreet

bcachefs: Fix btree_trans list ordering

2024-06-23T04:57:21+00:00

The debug code relies on btree_trans_list being ordered so that it can resume on subsequent calls or lock restarts. However, it was using trans->locknig_wait.task.pid, which is incorrect since btree_trans objects are cached and reused - typically by different tasks. Fix this by switching to pointer order, and also sort them lazily when required - speeding up the btree_trans_get() fastpath. Signed-off-by: Kent Overstreet

bcachefs: Fix race between trans_put() and btree_transactions_read()

2024-06-23T04:57:21+00:00

debug.c was using closure_get() on a different thread's closure where the we don't know if the object being refcounted is alive. We keep btree_trans objects on a list so they can be printed by debug code, and because it is cost prohibitive to touch the btree_trans list every time we allocate and free btree_trans objects, cached objects are also on this list. However, we do not want the debug code to see cached but not in use btree_trans objects - critically because the btree_paths array will have been freed (if it was reallocated). closure_get() is also incorrect to use when that get may race with it hitting zero, i.e. we must already have a ref on the object or know the ref can't currently hit 0 for other reasons (as used in the cycle detector). to fix this, use the previously introduced closure_get_not_zero(), closure_return_sync(), and closure_init_stack_release(); the debug code now can only take a ref on a trans object if it's alive and in use. Signed-off-by: Kent Overstreet

bcachefs: Make btree_deadlock_to_text() clearer

2024-06-23T04:57:21+00:00

btree_deadlock_to_text() searches the list of btree transactions to find a deadlock - when it finds one it's done; it's not like other *_read() functions that's printing each object. Factor out btree_deadlock_to_text() to make this clearer. Signed-off-by: Kent Overstreet

bcachefs: fix seqmutex_relock()

2024-06-23T04:57:21+00:00

We were grabbing the sequence number before unlock incremented it - fix this by moving the increment to seqmutex_lock() (so the seqmutex_relock() failure path skips the mutex_trylock()), and returning the sequence number from unlock(), to make the API simpler and safer. Signed-off-by: Kent Overstreet

bcachefs: bch2_dev_get_ioref() checks for device not present

2024-05-09T20:23:36+00:00

Signed-off-by: Kent Overstreet

bcachefs: bch2_dev_get_ioref2(); debug.c

2024-05-09T20:23:35+00:00

Signed-off-by: Kent Overstreet

bcachefs: member helper cleanups

2024-05-08T21:29:19+00:00

Some renaming for better consistency bch2_member_exists -> bch2_member_alive bch2_dev_exists -> bch2_member_exists bch2_dev_exsits2 -> bch2_dev_exists bch_dev_locked -> bch2_dev_locked bch_dev_bkey_exists -> bch2_dev_bkey_exists new helper - bch2_dev_safe Signed-off-by: Kent Overstreet

bcachefs: iter/update/trigger/str_hash flag cleanup

2024-05-08T21:29:18+00:00

Combine iter/update/trigger/str_hash flags into a single enum, and x-macroize them for a to_text() function later. These flags are all for a specific iter/key/update context, so it makes sense to group them together - iter/update/trigger flags were already given distinct bits, this cleans up and unifies that handling. Signed-off-by: Kent Overstreet