kernel/linux.git/fs/bcachefs/btree_write_buffer.c, branch v6.12.80

bcachefs: bch2_btree_write_buffer_flush_going_ro()

2024-11-08T04:31:11+00:00

The write buffer needs to be specifically flushed when going RO: keys in the journal that haven't yet been moved to the write buffer don't have a journal pin yet. This fixes numerous syzbot bugs, all with symptoms of still doing writes after we've got RO. Signed-off-by: Kent Overstreet

bcachefs: silence silly kdoc warning

2024-07-18T22:33:30+00:00

Signed-off-by: Kent Overstreet

bcachefs: Eytzinger accumulation for accounting keys

2024-07-14T23:00:14+00:00

The btree write buffer takes as input keys from the journal, sorts them, deduplicates them, and flushes them back to the btree in sorted order. The disk space accounting rewrite is moving accounting to normal btree keys, with update (in this case deltas) accumulated in the write buffer and then flushed to the btree; but this is going to increase the number of keys handled by the write buffer by perhaps as much as a factor of 3x-5x. The overhead from copying around and sorting this many keys would cause a significant performance regression, but: there is huge locality in updates to accounting keys that we can take advantage of. Instead of appending accounting keys to the list of keys to be sorted, this patch adds an eytzinger search tree of recently seen accounting keys. We look up the accounting key in the eytzinger search tree and apply the delta directly, adding it if it doesn't exist, and periodically prune the eytzinger tree of unused entries. Signed-off-by: Kent Overstreet

bcachefs: btree write buffer knows how to accumulate bch_accounting keys

2024-07-14T23:00:13+00:00

Teach the btree write buffer how to accumulate accounting keys - instead of having the newer key overwrite the older key as we do with other updates, we need to add them together. Also, add a flag so that write buffer flush knows when journal replay is finished flushing accounting, and teach it to hold accounting keys until that flag is set. Signed-off-by: Kent Overstreet

bcachefs: bch2_btree_write_buffer_maybe_flush()

2024-06-29T22:34:52+00:00

Add a new helper for checking references to write buffer btrees, where we need a flush before we definitively know we have an inconsistency. Signed-off-by: Kent Overstreet

bcachefs: iter/update/trigger/str_hash flag cleanup

2024-05-08T21:29:18+00:00

Combine iter/update/trigger/str_hash flags into a single enum, and x-macroize them for a to_text() function later. These flags are all for a specific iter/key/update context, so it makes sense to group them together - iter/update/trigger flags were already given distinct bits, this cleans up and unifies that handling. Signed-off-by: Kent Overstreet

bcachefs: Fix btree node merging on write buffer btrees

2024-04-14T02:49:25+00:00

The btree write buffer flush fastpath that avoids the main transaction commit path had the unfortunate side effect of not doing btree node merging. Signed-off-by: Kent Overstreet

bcachefs: Fix journal pins in btree write buffer

2024-04-01T00:36:10+00:00

btree write buffer flush has two phases - in natural key order, which is more efficient but may fail - then in journal order The journal order flush was assuming that keys were still correctly ordered by journal sequence number - but due to coalescing by the previous phase, we need an additional sort. Signed-off-by: Kent Overstreet

bcachefs: Improve bch2_fatal_error()

2024-03-18T04:24:24+00:00

error messages should always include __func__ Signed-off-by: Kent Overstreet

bcachefs: jset_entry for loops declare loop iter

2024-03-14T01:22:25+00:00

Signed-off-by: Kent Overstreet