kernel/linux.git/fs/bcachefs/backpointers.c, branch v6.12.80

bcachefs: Allow for unknown key types in backpointers fsck

2024-11-11T05:37:19+00:00

We can't assume that btrees only contain keys of a given type - even if they only have a single key type listed in the allowed key types for that btree; this is a forwards compatibility issue. Reported-by: syzbot+a27c3aaa3640dd3e1dfb@syzkaller.appspotmail.com Signed-off-by: Kent Overstreet

bcachefs: Fix missing validation for bch_backpointer.level

2024-11-08T05:05:53+00:00

This fixes an assertion pop where we try to navigate to the target of the backpointer, and the path level isn't what we expect. Reported-by: syzbot+b17df21b4d370f2dc330@syzkaller.appspotmail.com Signed-off-by: Kent Overstreet

bcachefs: rename version -> bversion

2024-09-28T01:46:35+00:00

give bversions a more distinct name, to aid in grepping Signed-off-by: Kent Overstreet

bcachefs: Remove duplicated include in backpointers.c

2024-09-21T15:39:49+00:00

The header files bbpos.h is included twice in backpointers.c, so one inclusion of each can be removed. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=10783 Signed-off-by: Yang Li Signed-off-by: Kent Overstreet

bcachefs: Rework btree node pinning

2024-09-21T15:39:48+00:00

In backpointers fsck, we do a seqential scan of one btree, and check references to another: extents <-> backpointers Checking references generates random lookups, so we want to pin that btree in memory (or only a range, if it doesn't fit in ram). Previously, this was done with a simple check in the shrinker - "if btree node is in range being pinned, don't free it" - but this generated OOMs, as our shrinker wasn't well behaved if there was less memory available than expected. Instead, we now have two different shrinkers and lru lists; the second shrinker being for pinned nodes, with seeks set much higher than normal - so they can still be freed if necessary, but we'll prefer not to. Signed-off-by: Kent Overstreet

bcachefs: bch2_dev_rcu_noerror()

2024-09-21T15:39:48+00:00

bch2_dev_rcu() now properly errors if the device is invalid Signed-off-by: Kent Overstreet

bcachefs: Progress indicator for extents_to_backpointers

2024-09-21T15:39:48+00:00

Signed-off-by: Kent Overstreet

bcachefs: Make bkey_fsck_err() a wrapper around fsck_err()

2024-08-14T03:00:50+00:00

bkey_fsck_err() was added as an interface that looks like fsck_err(), but previously all it did was ensure that the appropriate error counter was incremented in the superblock. This is a cleanup and bugfix patch that converts it to a wrapper around fsck_err(). This is needed to fix an issue with the upgrade path to disk_accounting_v3, where the "silent fix" error list now includes bkey_fsck errors; fsck_err() handles this in a unified way, and since we need to change printing of bkey fsck errors from the caller to the inner bkey_fsck_err() calls, this ends up being a pretty big change. Als,, rename .invalid() methods to .validate(), for clarity, while we're changing the function signature anyways (to drop the printbuf argument). Signed-off-by: Kent Overstreet

bcachefs: Convert for_each_btree_node() to lockrestart_do()

2024-08-14T02:56:50+00:00

for_each_btree_node() now works similarly to for_each_btree_key(), where the loop body is passed as an argument to be passed to lockrestart_do(). This now calls trans_begin() on every loop iteration - which fixes an SRCU warning in backpointers fsck. Signed-off-by: Kent Overstreet

bcachefs: fsck_err() may now take a btree_trans

2024-07-14T23:00:14+00:00

fsck_err() now optionally takes a btree_trans; if the current thread has one, it is required that it be passed. The next patch will use this to unlock when waiting for user input. Signed-off-by: Kent Overstreet