kernel/linux.git/fs/bcachefs/alloc_background.h, branch v6.12.80

bcachefs: fix shift oob in alloc_lru_idx_fragmentation

2024-10-24T21:41:43+00:00

The size of a.data_type is set abnormally large, causing shift-out-of-bounds. To fix this, we need to add validation on a.data_type in alloc_lru_idx_fragmentation(). Reported-by: syzbot+7f45fa9805c40db3f108@syzkaller.appspotmail.com Fixes: 260af1562ec1 ("bcachefs: Kill alloc_v4.fragmentation_lru") Signed-off-by: Jeongjun Park Signed-off-by: Kent Overstreet

bcachefs: bch2_dev_rcu_noerror()

2024-09-21T15:39:48+00:00

bch2_dev_rcu() now properly errors if the device is invalid Signed-off-by: Kent Overstreet

bcachefs: bch2_dev_remove_alloc() -> alloc_background.c

2024-09-21T15:39:48+00:00

Signed-off-by: Kent Overstreet

bcachefs: avoid overflowing LRU_TIME_BITS for cached data lru

2024-08-16T16:46:40+00:00

Reported-by: syzbot+510b0b28f8e6de64d307@syzkaller.appspotmail.com Signed-off-by: Kent Overstreet

bcachefs: Make bkey_fsck_err() a wrapper around fsck_err()

2024-08-14T03:00:50+00:00

bkey_fsck_err() was added as an interface that looks like fsck_err(), but previously all it did was ensure that the appropriate error counter was incremented in the superblock. This is a cleanup and bugfix patch that converts it to a wrapper around fsck_err(). This is needed to fix an issue with the upgrade path to disk_accounting_v3, where the "silent fix" error list now includes bkey_fsck errors; fsck_err() handles this in a unified way, and since we need to change printing of bkey fsck errors from the caller to the inner bkey_fsck_err() calls, this ends up being a pretty big change. Als,, rename .invalid() methods to .validate(), for clarity, while we're changing the function signature anyways (to drop the printbuf argument). Signed-off-by: Kent Overstreet

bcachefs: Add a comment for bucket helper types

2024-08-07T12:31:10+00:00

We've had bugs in the past with incorrect integer conversions in disk accounting code, which is why bucket helpers now always return s64s; add a comment explaining this. Signed-off-by: Kent Overstreet

bcachefs: Don't rely on implicit unsigned -> signed integer conversion

2024-08-07T12:31:10+00:00

implicit integer conversion is a fertile source of bugs, and we really would rather not have the min()/max() macros doing it implicitly. bcachefs appears to be the only place in the kernel where this happens, so let's fix it. Signed-off-by: Kent Overstreet

bcachefs: Fix missing BTREE_TRIGGER_bucket_invalidate flag

2024-07-14T23:00:16+00:00

This fixes an accounting mismatch for cached data. Signed-off-by: Kent Overstreet

bcachefs: Disk space accounting rewrite

2024-07-14T23:00:13+00:00

Main part of the disk accounting rewrite. This is a wholesale rewrite of the existing disk space accounting, which relies on percepu counters that are sharded by journal buffer, and rolled up and added to each journal write. With the new scheme, every set of counters is a distinct key in the accounting btree; this fixes scaling limitations of the old scheme, where counters took up space in each journal entry and required multiple percpu counters. Now, in memory accounting requires a single set of percpu counters - not multiple for each in flight journal buffer - and in the future we'll probably also have counters that don't use in memory percpu counters, they're not strictly required. An accounting update is now a normal btree update, using the btree write buffer path. At transaction commit time, we apply accounting updates to the in memory counters, which are percpu counters indexed in an eytzinger tree by the accounting key. Signed-off-by: Kent Overstreet

bcachefs: BCH_DATA_unstriped

2024-07-14T23:00:12+00:00

Add a new pseudo data type, to track buckets that are members of a stripe, but have unstriped data in them. Signed-off-by: Kent Overstreet