kernel/linux.git/fs/adfs/dir.c, branch v6.18.22

fs/adfs: mostly divorse inode number from indirect disc address

2020-01-21T01:12:42+00:00

Avoid using the inode number as the indirect disc address, even though these currently have the same value. Signed-off-by: Russell King Signed-off-by: Al Viro

fs/adfs: dir: remove debug in adfs_dir_update()

2020-01-21T01:12:42+00:00

Remove the noisy debug in adfs_dir_update(). Signed-off-by: Russell King Signed-off-by: Al Viro

fs/adfs: newdir: split out directory commit from update

2020-01-21T01:12:42+00:00

After changing a directory, we need to update the sequence numbers and calculate the new check byte before the directory is scheduled to be written back to the media. Since this needs to happen for any change to the directory, move this into a separate method. Signed-off-by: Russell King Signed-off-by: Al Viro

fs/adfs: dir: add more efficient iterate() per-format method

2020-01-21T01:12:41+00:00

Rather than using setpos + getnext to iterate through the directory entries, pass iterate() down to the dir format code to populate the dirents. Signed-off-by: Russell King Signed-off-by: Al Viro

fs/adfs: dir: switch to iterate_shared method

2020-01-21T01:12:41+00:00

There is nothing in our readdir (aka iterate) method that relies on the directory inode being exclusively locked, so switch to using the iterate_shared() hook rather than iterate(). Signed-off-by: Russell King Signed-off-by: Al Viro

fs/adfs: dir: improve compiler coverage in adfs_dir_update

2020-01-21T01:12:41+00:00

Get rid of the ifdef, using IS_ENABLED() instead to detect whether the code should be callable. This allows the compiler to always parse the following code, reducing the chances of errors being missed. Signed-off-by: Russell King Signed-off-by: Al Viro

fs/adfs: dir: improve update failure handling

2020-01-21T01:12:41+00:00

When we update a directory, a number of errors may happen. If we failed to find the entry to update, we can just release the directory buffers as normal. However, if we have some other error, we may have partially updated the buffers, resulting in an invalid directory. In this case, we need to discard the buffers to avoid writing the contents back to the media, and later re-read the directory from the media. Signed-off-by: Russell King Signed-off-by: Al Viro

fs/adfs: dir: update directory locking

2020-01-21T01:12:41+00:00

Update directory locking such that it covers the validation of the directory, which could fail if another thread is concurrently writing to the same directory. Since we may sleep, we need to use a rwsem rather than a rw spinlock. Signed-off-by: Russell King Signed-off-by: Al Viro

fs/adfs: dir: add helper to mark directory buffers dirty

2020-01-21T01:12:41+00:00

Provide a helper for marking directory buffers dirty so they get written back to disk. Signed-off-by: Russell King Signed-off-by: Al Viro

fs/adfs: dir: add helper to read directory using inode

2020-01-21T01:12:41+00:00

Add a helper to read a directory using the inode, which we do in two places. Signed-off-by: Russell King Signed-off-by: Al Viro