kernel/linux.git/drivers/watchdog/i6300esb.c, branch linux-4.16.y

watchdog: i6300esb: remove info message and version number

2017-12-28T19:45:18+00:00

The initial info message (early in the esb_probe() function) is not very useful and we already have a message on successful probe, which includes device identification. If the probe fails (e.g. PCI related errors), additional messages are printed anyway. The version number was only used in the initial info message. Other than that, it serves no useful purpose and it ran out of favor upstream anyway. Signed-off-by: Radu Rendec Reviewed-by: Guenter Roeck Signed-off-by: Guenter Roeck Signed-off-by: Wim Van Sebroeck

watchdog: i6300esb: do not hardcode heartbeat limits

2017-12-28T19:45:18+00:00

The minimum, maximum and default values for the watchdog heartbeat (timeout) were hardcoded in several places (including module parameter description and warning message for invalid module parameter value). This patch adds macros for the aforementioned values and replaces all occurences of hardcoded values by these macros. Signed-off-by: Radu Rendec Reviewed-by: Guenter Roeck Signed-off-by: Guenter Roeck Signed-off-by: Wim Van Sebroeck

watchdog: i6300esb: support multiple devices

2017-12-28T19:45:17+00:00

Support multiple i6300esb devices simultaneously, by removing the single device restriction in the original design and leveraging the multiple device support of the watchdog subsystem. This patch replaces the global definitions of watchdog device data with a dynamically allocated structure. This structure is allocated during device probe, so multiple independent structures can be allocated if multiple devices are probed. Signed-off-by: Radu Rendec Reviewed-by: Guenter Roeck Signed-off-by: Guenter Roeck Signed-off-by: Wim Van Sebroeck

watchdog: i6300esb: use the watchdog subsystem

2017-12-28T19:45:17+00:00

Change the i6300esb driver to use the watchdog subsystem instead of the legacy watchdog API. This is mainly just getting rid of the "write" and "ioctl" methods and part of the watchdog control logic (which are all implemented by the watchdog subsystem). Even though the watchdog subsystem supports registering and handling multiple watchdog devices at the same time, the i6300esb driver still has a limitation of only one i6300esb device due to some global variable usage that comes from the original design. However, the driver can now coexist with other watchdog devices (supported by different drivers). Signed-off-by: Radu Rendec Reviewed-by: Guenter Roeck Signed-off-by: Guenter Roeck Signed-off-by: Wim Van Sebroeck

watchdog: delete non-required instances of include

2014-03-31T11:22:45+00:00

None of these files are actually using any __init type directives and hence don't need to include . Most are just a left over from __devinit and __cpuinit removal, or simply due to code getting copied from one driver to the next. Signed-off-by: Paul Gortmaker Reviewed-by: Guenter Roeck Signed-off-by: Wim Van Sebroeck Cc: linux-watchdog@vger.kernel.org

watchdog: remove DEFINE_PCI_DEVICE_TABLE macro

2014-01-28T18:07:07+00:00

Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred. Signed-off-by: Jingoo Han Reviewed-by: Guenter Roeck Signed-off-by: Wim Van Sebroeck

watchdog: Get rid of MODULE_ALIAS_MISCDEV statements

2013-11-17T18:38:13+00:00

I just can't find any value in MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR) and MODULE_ALIAS_MISCDEV(TEMP_MINOR) statements. Either the device is enumerated and the driver already has a module alias (e.g. PCI, USB etc.) that will get the right driver loaded automatically. Or the device is not enumerated and loading its driver will lead to more or less intrusive hardware poking. Such hardware poking should be limited to a bare minimum, so the user should really decide which drivers should be tried and in what order. Trying them all in arbitrary order can't do any good. On top of that, loading that many drivers at once bloats the kernel log. Also many drivers will stay loaded afterward, bloating the output of "lsmod" and wasting memory. Some modules (cs5535_mfgpt which gets loaded as a dependency) can't even be unloaded! If defining char-major-10-130 is needed then it should happen in user-space. Signed-off-by: Jean Delvare Acked-by: Guenter Roeck Signed-off-by: Wim Van Sebroeck Cc: Stephen Warren Cc: Mike Frysinger Cc: Wan ZongShun Cc: Ben Dooks Cc: Kukjin Kim Cc: Zwane Mwaikambo Cc: Jim Cromie

watchdog: remove use of __devexit

2012-11-28T20:00:24+00:00

CONFIG_HOTPLUG is going away as an option so __devexit is no longer needed. Signed-off-by: Bill Pemberton Cc: Wim Van Sebroeck Cc: Wan ZongShun Cc: Ben Dooks Cc: Kukjin Kim Acked-by: Mark Brown Signed-off-by: Greg Kroah-Hartman

watchdog: remove use of __devinit

2012-11-28T20:00:24+00:00

CONFIG_HOTPLUG is going away as an option so __devinit is no longer needed. Signed-off-by: Bill Pemberton Cc: Wim Van Sebroeck Cc: Wan ZongShun Cc: Ben Dooks Cc: Kukjin Kim Acked-by: Mark Brown Signed-off-by: Greg Kroah-Hartman

watchdog: remove use of __devexit_p

2012-11-28T20:00:24+00:00

CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer needed. Signed-off-by: Bill Pemberton Cc: Wim Van Sebroeck Cc: Wan ZongShun Cc: Ben Dooks Cc: Kukjin Kim Acked-by: Mark Brown Signed-off-by: Greg Kroah-Hartman