kernel/linux.git/drivers/video/fbdev/udlfb.c, branch v4.14.217

video: udlfb: Fix read EDID timeout

2017-12-20T09:10:23+00:00

[ Upstream commit c98769475575c8a585f5b3952f4b5f90266f699b ] While usb_control_msg function expects timeout in miliseconds, a value of HZ is used. Replace it with USB_CTRL_GET_TIMEOUT and also fix error message which looks like: udlfb: Read EDID byte 78 failed err ffffff92 as error is either negative errno or number of bytes transferred use %d format specifier. Returned EDID is in second byte, so return error when less than two bytes are received. Fixes: 18dffdf8913a ("staging: udlfb: enhance EDID and mode handling support") Signed-off-by: Ladislav Michl Cc: Bernie Thompson Signed-off-by: Bartlomiej Zolnierkiewicz Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman

video: fbdev: udlfb: Fix use after free on dlfb_usb_probe error path

2017-08-21T14:49:58+00:00

If dlfb_usb_probe drops to error path then there is only one kref_init() call and no kref_get(), so second kref_put() leads to use after free. The patch removes superfluous kref_put on dlfb_usb_probe error path. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Anton Vasilyev Cc: Bernie Thompson Signed-off-by: Bartlomiej Zolnierkiewicz

video: fbdev: udlfb: constify usb_device_id.

2017-08-21T14:49:57+00:00

usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav Cc: Steve Glendinning Cc: Bernie Thompson Signed-off-by: Bartlomiej Zolnierkiewicz

video: fbdev: add const to bin_attribute structures

2017-08-18T17:56:40+00:00

Add const to bin_attribute structures as they are only passed to the functions sysfs_{remove/create}_bin_file or device_{remove/create}_bin_file. The corresponding arguments are of type const, so declare the structures to be const. Signed-off-by: Bhumika Goyal Cc: Julia Lawall Cc: Bernie Thompson Signed-off-by: Bartlomiej Zolnierkiewicz

video: fbdev: udlfb: drop log level for blanking

2017-06-14T10:40:36+00:00

Drop log level for blanking from info to debug. Xorg likes to habitually unblank when already unblanked and this can fill up logs over a long period of time. Signed-off-by: Mike Gerow Cc: bernie@plugable.com Signed-off-by: Bartlomiej Zolnierkiewicz

video: fbdev: add missing USB-descriptor endianness conversions

2017-06-14T10:40:36+00:00

Add the missing endianness conversions when printing the USB device-descriptor idVendor, idProduct and bcdDevice fields during probe. Signed-off-by: Johan Hovold Cc: Steve Glendinning Cc: Bernie Thompson Signed-off-by: Bartlomiej Zolnierkiewicz

video: fbdev: udlfb: Fix buffer on stack

2017-05-02T11:47:53+00:00

Allocate buffers on HEAP instead of STACK for local array that is to be sent using usb_control_msg(). Signed-off-by: Maksim Salau Cc: Bernie Thompson Cc: Geert Uytterhoeven Signed-off-by: Bartlomiej Zolnierkiewicz

fbdev: udlfb: remove unneeded initialization in few places

2015-08-20T07:32:40+00:00

Small minor cleanup. This patch removes unneeded initializations of variables in few places in different functions and one empty line. Signed-off-by: Alexey Klimov Signed-off-by: Tomi Valkeinen

video: udlfb: Deletion of unnecessary checks before the function call "vfree"

2014-12-04T14:16:01+00:00

The vfree() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Tomi Valkeinen

video: fbdev: use %*ph specifier to dump small buffers

2014-09-09T11:03:34+00:00

Instead of dereference each byte let's use %*ph specifier in the printk() calls. Signed-off-by: Andy Shevchenko Signed-off-by: Tomi Valkeinen