kernel/linux.git/drivers/video/fbdev/pxafb.c, branch linux-4.20.y

video: fbdev: pxafb: Fix "WARNING: invalid free of devm_ allocated data"

2019-01-13T08:24:08+00:00

commit 2607391882fca37463187e7f2a9c76dec286947e upstream. 'info->modes' got allocated with devm_kcalloc in of_get_pxafb_display. This gives this error message: ./drivers/video/fbdev/pxafb.c:2238:2-7: WARNING: invalid free of devm_ allocated data Fixes: c8f96304ec8b4 ("video: fbdev: pxafb: switch to devm_* API") Cc: stable@kernel.org [v4.19+] Signed-off-by: YueHaibing Reviewed-by: Daniel Mack Cc: Robert Jarzmik Signed-off-by: Bartlomiej Zolnierkiewicz Signed-off-by: Greg Kroah-Hartman

video: fbdev: pxafb: Add support for lcd-supply regulator

2018-07-24T17:11:26+00:00

Optionally obtain a lcd-supply regulator during probe and use it in __pxafb_lcd_power() to switch the power supply of LCD panels. This helps boards booted from DT to control such voltages without callbacks. Signed-off-by: Daniel Mack Reviewed-by: Robert Jarzmik Signed-off-by: Bartlomiej Zolnierkiewicz

video: fbdev: pxafb: handle errors from pxafb_init_fbinfo() correctly

2018-07-24T17:11:25+00:00

pxafb_init_fbinfo() can not only report errors caused by failed allocations but also when the clock can't be found. To fix this, return an error pointer instead of NULL in case of errors, and up-chain the result. Signed-off-by: Daniel Mack Reviewed-by: Robert Jarzmik Signed-off-by: Bartlomiej Zolnierkiewicz

video: fbdev: pxafb: switch to devm_* API

2018-07-24T17:11:25+00:00

This helps us clean up the probe() and remove() implementations. Signed-off-by: Daniel Mack Reviewed-by: Robert Jarzmik Signed-off-by: Bartlomiej Zolnierkiewicz

video: fbdev: pxafb: clear allocated memory for video modes

2018-07-24T17:11:25+00:00

When parsing the video modes from DT properties, make sure to zero out memory before using it. This is important because not all fields in the mode struct are explicitly initialized, even though they are used later on. Fixes: 420a488278e86 ("video: fbdev: pxafb: initial devicetree conversion") Reviewed-by: Robert Jarzmik Signed-off-by: Daniel Mack Signed-off-by: Bartlomiej Zolnierkiewicz

video: fbdev: pxafb: match_string() conversion fixup

2018-05-15T16:03:23+00:00

"unknown" lcd_types[] entry is needed for proper operation of the driver, add it back. Fixes: 6d09dfe70f8f ("video: fbdev: pxafb: Convert to use match_string() helper") Reported-by: Andy Shevchenko Cc: Arvind Yadav Signed-off-by: Bartlomiej Zolnierkiewicz

video: fbdev: pxafb: Convert to use match_string() helper

2018-05-15T10:41:10+00:00

The new helper returns index of the matching string in an array. We are going to use it here. Signed-off-by: Andy Shevchenko Cc: Arvind Yadav Signed-off-by: Bartlomiej Zolnierkiewicz

video: fbdev: pxafb: Handle return value of clk_prepare_enable

2017-06-14T15:40:56+00:00

clk_prepare_enable() can fail here and we must check its return value. Signed-off-by: Arvind Yadav Signed-off-by: Bartlomiej Zolnierkiewicz

drivers/video: Convert remaining uses of pr_warning to pr_warn

2017-03-21T15:13:10+00:00

To enable eventual removal of pr_warning This makes pr_warn use consistent for drivers/video Prior to this patch, there were 6 uses of pr_warning and 25 uses of pr_warn in drivers/video Signed-off-by: Joe Perches Cc: Benjamin Herrenschmidt Signed-off-by: Bartlomiej Zolnierkiewicz

video: fbdev: pxafb: add missing of_node_put() in of_get_pxafb_mode_info()

2016-08-30T09:04:16+00:00

This node pointer is returned by of_graph_get_next_endpoint() with refcount incremented in this function. of_node_put() on it before exitting this function. Found by Coccinelle. Signed-off-by: Wei Yongjun Acked-by: Robert Jarzmik Signed-off-by: Tomi Valkeinen