kernel/linux.git/drivers/video/fbdev/imxfb.c, branch v6.12.80Linux kernel stable tree (mirror)https://git.radix-linux.su/kernel/linux.git/atom?h=v6.12.802025-08-15T10:13:57+00:00fbdev: imxfb: Check fb_add_videomode to prevent null-ptr-deref2025-08-15T10:13:57+00:00Chenyuan Yangchenyuan0y@gmail.com2025-07-24T03:25:34+00:00urn:sha1:40f0a51f6c54d46a94b9f1180339ede7ca7ee190
[ Upstream commit da11e6a30e0bb8e911288bdc443b3dc8f6a7cac7 ]
fb_add_videomode() can fail with -ENOMEM when its internal kmalloc() cannot
allocate a struct fb_modelist. If that happens, the modelist stays empty but
the driver continues to register. Add a check for its return value to prevent
poteintial null-ptr-deref, which is similar to the commit 17186f1f90d3 ("fbdev:
Fix do_register_framebuffer to prevent null-ptr-deref in fb_videomode_to_var").
Fixes: 1b6c79361ba5 ("video: imxfb: Add DT support")
Signed-off-by: Chenyuan Yang <chenyuan0y@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fbdev: Switch back to struct platform_driver::remove()2024-10-08T19:47:18+00:00Uwe Kleine-Königu.kleine-koenig@baylibre.com2024-10-07T16:35:17+00:00urn:sha1:01ecc142ef7c8c5081a39be81c1d8ab7c10dd7b8
After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
return void") .remove() is (again) the right callback to implement for
platform drivers.
Convert all platform drivers below drivers/video/fbdev to use .remove(),
with the eventual goal to drop struct platform_driver::remove_new(). As
.remove() and .remove_new() have the same prototypes, conversion is done
by just changing the structure member name in the driver initializer.
While touching these files, make indention of the struct initializer
consistent in several files.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Helge Deller <deller@gmx.de>
fbdev: imx: Constify lcd_ops2024-05-03T09:45:46+00:00Krzysztof Kozlowskikrzk@kernel.org2024-04-24T06:33:43+00:00urn:sha1:8b2d4564eca41581950ee113d41e180db7ea77b9
'struct lcd_ops' is not modified by core backlight code, so it can be
made const for increased code safety.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
Link: https://lore.kernel.org/r/20240424-video-backlight-lcd-ops-v2-17-1aaa82b07bc6@kernel.org
Signed-off-by: Lee Jones <lee@kernel.org>
fbdev: imxfb: add '*/' on a separate line in block comment2024-01-11T16:09:01+00:00Dario Binacchidario.binacchi@amarulasolutions.com2023-11-11T10:41:59+00:00urn:sha1:d6dfcdaa4e6e1a7fa99dc068f47f6b7b8c5bb634
Linux kernel coding style uses '*/' on a separate line at the end of
multi line comments.
Fix block comments by moving '*/' at the end of block comments on a
separate line as reported by checkpatch:
WARNING: Block comments use a trailing */ on a separate line
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Signed-off-by: Helge Deller <deller@gmx.de>
fbdev: imxfb: use __func__ for function name2024-01-11T16:09:01+00:00Dario Binacchidario.binacchi@amarulasolutions.com2023-11-11T10:41:58+00:00urn:sha1:cb892e5dfed3044974c4f10addbc297966224fe8
Resolve the following warning reported by checkpatch:
WARNING: Prefer using '"%s...", __func__' to using 'imxfb_blank', this function's name, in a string
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Signed-off-by: Helge Deller <deller@gmx.de>
fbdev: imxfb: Fix style warnings relating to printk()2024-01-11T16:09:01+00:00Dario Binacchidario.binacchi@amarulasolutions.com2023-11-11T10:41:57+00:00urn:sha1:77bf5df43348c45eddf40e06e9a1d417f1d755ef
Resolve the following warning reported by checkpatch:
WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...
This made it necessary to move the 'fbi->pdev = pdev' setting to the
beginning of the driver's probing.
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Signed-off-by: Helge Deller <deller@gmx.de>
fbdev: imxfb: add missing spaces after ','2024-01-11T16:09:01+00:00Dario Binacchidario.binacchi@amarulasolutions.com2023-11-11T10:41:56+00:00urn:sha1:62c82a47cbf8f183db24382bd5fc6e3067cd54c4
Fix the following checkpatch error:
ERROR: space required after that ',' (ctx:VxV)
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Signed-off-by: Helge Deller <deller@gmx.de>
fbdev: imxfb: drop ftrace-like logging2024-01-11T16:09:01+00:00Dario Binacchidario.binacchi@amarulasolutions.com2023-11-11T10:41:55+00:00urn:sha1:f11025059b59fe84880b48b2c3e7cf6894677b93
Resolve the following warning reported by checkpatch:
WARNING: Unnecessary ftrace-like logging - prefer using ftrace
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Signed-off-by: Helge Deller <deller@gmx.de>
fbdev: imxfb: add missing SPDX tag2024-01-11T16:09:01+00:00Dario Binacchidario.binacchi@amarulasolutions.com2023-11-11T10:41:54+00:00urn:sha1:df937b8bb6044f1763945e00a5c0b29b8cc51ba4
Resolve the following warning reported by checkpatch.pl:
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
The patch also removes some license info made redundant by the addition
of the SPDX tag.
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Signed-off-by: Helge Deller <deller@gmx.de>
fbdev: imxfb: replace some magic numbers with constants2024-01-11T16:09:01+00:00Dario Binacchidario.binacchi@amarulasolutions.com2023-11-11T10:41:53+00:00urn:sha1:da119a074d776e95a29d5891cf50248553064749
The patch gets rid of magic numbers replacing them with appropriate
macros.
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Signed-off-by: Helge Deller <deller@gmx.de>