kernel/linux.git/drivers/video/fbdev/au1100fb.c, branch linux-7.0.y

fbdev: au1100fb: Fix build on MIPS64

2026-03-05T16:35:12+00:00

Fix an error reported by the kernel test robot: au1100fb.c: error: implicit declaration of function 'KSEG1ADDR'; did you mean 'CKSEG1ADDR'? arch/mips/include/asm/addrspace.h defines KSEG1ADDR only for 32 bit configurations. So provide its compile-test stub also for 64bit mips builds. Fixes: 6f366e86481a ("fbdev: au1100fb: Make driver compilable on non-mips platforms") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202603042127.PT6LuKqi-lkp@intel.com/ Signed-off-by: Helge Deller Acked-by: Uwe Kleine-König

fbdev: au1100fb: Replace license boilerplate by SPDX header

2026-02-19T16:38:17+00:00

This also gets rid of an old address of the FSF. Signed-off-by: Uwe Kleine-König Signed-off-by: Helge Deller

fbdev: au1100fb: Fold au1100fb.h into its only user

2026-02-19T16:38:17+00:00

This gets rid of a header that is only used once. The copyrights and license specifications are all already covered in the au1100fb.c file. Signed-off-by: Uwe Kleine-König Signed-off-by: Helge Deller

fbdev: au1100fb: Replace custom printk wrappers by pr_*

2026-02-19T16:38:17+00:00

The global wrappers also have the advantage to do stricter format checking, so the pr_devel formats are also checked if DEBUG is not defined. The global variants only check for DEBUG being defined and not its actual value, so the #define to zero is dropped, too. There is only a slight semantic change as the (by default disabled) debug output doesn't contain __FILE__ any more. Signed-off-by: Uwe Kleine-König Signed-off-by: Helge Deller

fbdev: au1100fb: Make driver compilable on non-mips platforms

2026-02-19T16:38:17+00:00

The header asm/mach-au1x00/au1000.h is unused apart from pulling in (for mdelay()) and (for KSEG1ADDR()). Then the only platform specific part in the driver is the usage of the KSEG1ADDR macro, which for the non-mips case can be stubbed. Signed-off-by: Uwe Kleine-König Signed-off-by: Helge Deller

fbdev: au1100fb: Use proper conversion specifiers in printk formats

2026-02-19T16:38:17+00:00

%zu is the dedicated type for size_t. %d only works on 32bit architectures where size_t is typedef'd to be unsigned int. (And then the signedness doesn't fit, but `gcc -Wformat` doesn't stumble over this. Also the size of dma_addr_t is architecture dependent and it should be printkd using %pad (and the value passed by reference). This prepares allowing this driver to be compiled on non-mips platforms. Signed-off-by: Uwe Kleine-König Signed-off-by: Helge Deller

fbdev: au1100fb: Mark several local functions as static

2026-02-19T16:38:17+00:00

This fixes several (fatal) compiler warnings à la drivers/video/fbdev/au1100fb.c:530:6: error: no previous prototype for ‘au1100fb_drv_remove’ [-Werror=missing-prototypes] 523 | void au1100fb_drv_remove(struct platform_device *dev) | ^~~~~~~~~~~~~~~~~~~ Signed-off-by: Uwe Kleine-König Signed-off-by: Helge Deller

fbdev: au1100fb: Don't store device specific data in global variables

2026-02-19T16:38:16+00:00

Using global data to store device specific data is a bad pattern that breaks if there is more than one device. So expand driver data and drop the global variables. While there is probably no machine that has two or more au1100fb devices, this makes the driver a better template for new drivers and saves some memory if there is no such bound device. bloat-o-meter reports (for ARCH=arm allmodconfig + CONFIG_FB_AU1100=y and ignoring the rename of the init function): add/remove: 1/4 grow/shrink: 2/2 up/down: 1360/-4800 (-3440) Function old new delta au1100fb_drv_probe 2648 3328 +680 $a 12808 13484 +676 au1100fb_drv_resume 404 400 -4 au1100fb_fix 68 - -68 au1100fb_var 160 - -160 fbregs 2048 - -2048 $d 9525 7009 -2516 Total: Before=38664, After=35224, chg -8.90% Signed-off-by: Uwe Kleine-König Signed-off-by: Helge Deller

fbdev: au1100fb: Check return value of clk_enable() in .resume()

2026-02-14T10:09:47+00:00

Check the return value of clk_enable() in au1100fb_drv_resume() and return the error on failure. This ensures the system is aware of the resume failure and can track its state accurately. Signed-off-by: Chen Ni Acked-by: Uwe Kleine-König Signed-off-by: Helge Deller

fbdev: au1100fb: Move a variable assignment behind a null pointer check

2025-03-26T21:39:20+00:00

The address of a data structure member was determined before a corresponding null pointer check in the implementation of the function “au1100fb_setmode”. This issue was detected by using the Coccinelle software. Fixes: 3b495f2bb749 ("Au1100 FB driver uplift for 2.6.") Signed-off-by: Markus Elfring Acked-by: Uwe Kleine-König Signed-off-by: Helge Deller