kernel/linux.git/drivers/video/fbdev/atafb.c, branch v6.12.80

fbdev/atafb: Initialize fb_ops to fbdev I/O-memory helpers

2023-10-19T10:54:38+00:00

Initialize the instance of struct fb_ops with fbdev initializer macros for framebuffers in I/O address space. Set the read/write, draw and mmap callbacks to the correct implementation and avoid implicit defaults. Also select the necessary I/O helpers in Kconfig. Fbdev drivers sometimes rely on the callbacks being NULL for a default implementation to be invoked; hence requiring the I/O helpers to be built in any case. Setting all callbacks in all drivers explicitly will allow to make the I/O helpers optional. This benefits systems that do not use these functions. No functional changes. Signed-off-by: Thomas Zimmermann Acked-by: Javier Martinez Canillas Link: https://patchwork.freedesktop.org/patch/msgid/20230927074722.6197-7-tzimmermann@suse.de

fbdev/atafb: Remove flag FBINFO_FLAG_DEFAULT

2023-07-24T14:50:39+00:00

The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by a static declaration. So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v2: * fix commit message (Miguel) Signed-off-by: Thomas Zimmermann Acked-by: Sam Ravnborg Cc: Helge Deller Link: https://patchwork.freedesktop.org/patch/msgid/20230715185343.7193-16-tzimmermann@suse.de

video: fbdev: atari: Remove backward bug-compatibility

2022-07-18T05:56:18+00:00

As of v2.1.0, falcon_decode_var() contains a quirk to fix a rounding error, as explained by Günther Kelleter on Fri, 30 Aug 1996: This diff removes the now obsolete Falcon video option "pwrsave", and fixes a rounding error that is triggered by the resolution switching X server (those who use the pixel clock value 39722 in their /etc/fb.modes should change it to 39721). However, this causes the modified video mode returned by falcon_decode_var() to not match the video mode returned by falcon_encode_var(). Fix this by dropping the quirk. Unfortunately /etc/fb.modes in fbset was never updated, so the "640x480-60" mode still contains the wrong pixclock. Hence this change may introduce a regression. Signed-off-by: Geert Uytterhoeven Tested-by: Michael Schmitz Signed-off-by: Helge Deller

video: fbdev: atari: Remove unused definitions and variables

2022-07-18T05:56:18+00:00

Several definitions and variables are unused. Some variables are set but further unused. Remove them. Signed-off-by: Geert Uytterhoeven Tested-by: Michael Schmitz Signed-off-by: Helge Deller

video: fbdev: atari: Fix VGA modes

2022-07-18T05:56:18+00:00

The pixclock values in the vga and vga70 modes are wrong, as they should use the 25.175 MHz clock instead of the 32 MHz clock. Swap the left and right margins to match f25.{right,left} (struct pixel_clock declares them in a different order), and update the hsync lengths to match what the driver programs by default. Correct the (wrong) floating-point vrefresh value for the vga mode. Signed-off-by: Geert Uytterhoeven Tested-by: Michael Schmitz Signed-off-by: Helge Deller

video: fbdev: atari: Fix TT High video mode vertical refresh

2022-07-18T05:56:18+00:00

The vertical refresh rate for the TT High video mode (1280x960) is wrong. Fortunately this field is not really used. Signed-off-by: Geert Uytterhoeven Tested-by: Michael Schmitz Signed-off-by: Helge Deller

video: fbdev: atari: Remove unneeded casts to void *

2022-07-18T05:56:18+00:00

Arbitrary pointers can be passed to functions accepting "void *" without casting. Remove the casts, as they make it impossible to validate types. Signed-off-by: Geert Uytterhoeven Tested-by: Michael Schmitz Signed-off-by: Helge Deller

video: fbdev: atari: Remove unneeded casts from void *

2022-07-18T05:56:18+00:00

There is no need to cast fb_info.par to "struct atafb_par *", as the former has type "void *". Remove the casts, as they make it impossible to validate types. Signed-off-by: Geert Uytterhoeven Tested-by: Michael Schmitz Signed-off-by: Helge Deller

video: fbdev: atari: Fix ext_setcolreg()

2022-07-18T05:56:18+00:00

The red, green, and blue color values are 16-bit, while the external graphics hardware registers are 8-bit. Add the missing conversion from 16-bit to 8-bit. Signed-off-by: Geert Uytterhoeven Tested-by: Michael Schmitz Signed-off-by: Helge Deller

video: fbdev: atari: Fix inverse handling

2022-07-18T05:56:17+00:00

Currently, the "inverse" option does not do anything, as it just sets a flag, which is further unused. Fix this by calling fb_invert_cmaps() instead, like other drivers do. As this only affects the console colormap, this does not affect X. Update the documentation to match the actual behavior. Signed-off-by: Geert Uytterhoeven Tested-by: Michael Schmitz Signed-off-by: Helge Deller