kernel/linux.git/drivers/usb/usbip/vudc_dev.c, branch v4.9.331Linux kernel stable tree (mirror)https://git.radix-linux.su/kernel/linux.git/atom?h=v4.9.3312021-04-28T10:07:16+00:00usbip: vudc synchronize sysfs code paths2021-04-28T10:07:16+00:00Shuah Khanskhan@linuxfoundation.org2021-04-16T20:53:18+00:00urn:sha1:94b9c4c583758491e3ec9d5bb95eb31898855fa6
commit bd8b82042269a95db48074b8bb400678dbac1815 upstream.
Fuzzing uncovered race condition between sysfs code paths in usbip
drivers. Device connect/disconnect code paths initiated through
sysfs interface are prone to races if disconnect happens during
connect and vice versa.
Use sysfs_lock to protect sysfs paths in vudc.
Cc: stable@vger.kernel.org # 4.9.x # 4.14.x
Reported-and-tested-by: syzbot+a93fba6d384346a761e3@syzkaller.appspotmail.com
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Link: https://lore.kernel.org/r/caabcf3fc87bdae970509b5ff32d05bb7ce2fb15.1616807117.git.skhan@linuxfoundation.org
Signed-off-by: Tom Seewald <tseewald@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
usbip: vudc: Fix apparent cut-n-paste error2016-08-30T17:06:43+00:00Dave Jonesdavej@codemonkey.org.uk2016-05-31T15:25:09+00:00urn:sha1:1328f7b928e3fc41e019903a56d7253b04d7e4de
Coverity picked up that this looks like a cut-n-paste from an almost
identical sequence below that didn't get its variable renamed.
Signed-off-by: Dave Jones <davej@codemonkey.org.uk>
Reviewed-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
usb: usbip: vudc: Rename find_endpoint() to vudc_find_endpoint()2016-04-28T19:28:08+00:00Krzysztof Opasiakk.opasiak@samsung.com2016-04-27T18:02:07+00:00urn:sha1:0255cf9e52a73ba0d5ca393c93c5fb458fea4532
As find_endpoint() is a global funcion rename it to vudc_find_endpoint()
to clearly mark where does it come from.
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
usb: usbip: vudc: Fix WARN_ON() usage pattern2016-04-28T19:28:08+00:00Krzysztof Opasiakk.opasiak@samsung.com2016-04-27T18:00:26+00:00urn:sha1:2bdf6ea51ce8dcd98f4f394d7203dbace01f5cbc
Fix WARN_ON() macro usage as suggested by Felipe.
Instead of using:
if (cond) {
WARN_ON(1);
do_stuff();
}
Use a better pattern with WARN_ON() placed in if condition:
if (WARN_ON(cond))
do_stuff();
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
usbip: vudc: Add UDC specific ops2016-04-26T22:19:50+00:00Igor Kotrasinskii.kotrasinsk@samsung.com2016-03-08T20:49:02+00:00urn:sha1:b6a0ca11186759ad7045d68a5447b1e89f658384
Add endpoints definitions and ops for both endpoints and gadget.
Add also a suitable platform driver and functions for handling
usbip events.
This commit is a result of cooperation between Samsung R&D Institute
Poland and Open Operating Systems Student Society at University
of Warsaw (O2S3@UW) consisting of:
Igor Kotrasinski <ikotrasinsk@gmail.com>
Karol Kosik <karo9@interia.eu>
Ewelina Kosmider <3w3lfin@gmail.com>
Dawid Lazarczyk <lazarczyk.dawid@gmail.com>
Piotr Szulc <ps347277@students.mimuw.edu.pl>
Tutor and project owner:
Krzysztof Opasiak <k.opasiak@samsung.com>
Signed-off-by: Igor Kotrasinski <i.kotrasinsk@samsung.com>
Signed-off-by: Karol Kosik <karo9@interia.eu>
[Various bug fixes, improvements and commit msg update]
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>