kernel/linux.git/drivers/usb/serial/symbolserial.c, branch v4.9.331

USB: symbolserial: Correct transferred data size

2015-08-18T17:06:22+00:00

The scanner (here DS3508) always returns 64 bytes per urb buffer. The first byte indicates the data length used in the current buffer. There even was a comment describing this. But the comment also said that we'll send everything in the buffer to the tty layer. That means sending the actual barcode data and lots of trailing zeroes. This patch lets the driver only send the real data. Signed-off-by: Philipp Hachtmann Acked-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman

USB: symbolserial: Use usb_get_serial_port_data

2015-08-18T17:06:22+00:00

The driver used usb_get_serial_data(port->serial) which compiled but resulted in a NULL pointer being returned (and subsequently used). I did not go deeper into this but I guess this is a regression. Signed-off-by: Philipp Hachtmann Fixes: a85796ee5149 ("USB: symbolserial: move private-data allocation to port_probe") Cc: stable # v3.10 Acked-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman

USB: serial: add missing newlines to dev_ messages.

2014-03-12T19:44:50+00:00

Add missing newlines to dev_ messages. Also make some messages less verbose where appropriate. Signed-off-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman

usb: delete non-required instances of include

2014-01-08T23:01:39+00:00

None of these files are actually using any __init type directives and hence don't need to include . Most are just a left over from __devinit and __cpuinit removal, or simply due to code getting copied from one driver to the next. Signed-off-by: Paul Gortmaker Signed-off-by: Greg Kroah-Hartman

USB: symbolserial: move private-data allocation to port_probe

2013-04-17T17:05:35+00:00

Allocate port-private data in port-probe rather than in attach. Signed-off-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman

USB: symbolserial: remove unused private data

2013-04-17T17:05:35+00:00

Use port device for debug messages in interrupt-urb callback and remove unused private data. Signed-off-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman

USB: symbolserial: use port interrupt-in urb

2013-04-17T17:05:35+00:00

Use the port interrupt-in urb rather managing a private one. Signed-off-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman

TTY: switch tty_flip_buffer_push

2013-01-16T06:30:15+00:00

Now, we start converting tty buffer functions to actually use tty_port. This will allow us to get rid of the need of tty in many call sites. Only tty_port will needed and hence no more tty_port_tty_get in those paths. Now, the one where most of tty_port_tty_get gets removed: tty_flip_buffer_push. IOW we also closed all the races in drivers not using tty_port_tty_get at all yet. Also we move tty_flip_buffer_push declaration from include/linux/tty.h to include/linux/tty_flip.h to all others while we are changing it anyway. Signed-off-by: Jiri Slaby Signed-off-by: Greg Kroah-Hartman

TTY: switch tty_insert_flip_string

2013-01-16T06:22:35+00:00

USB: Serial: symbolserial.c: remove debug module parameter

2012-09-18T09:16:20+00:00

Now that all usb-serial modules are only using dev_dbg() the debug module parameter does not do anything at all, so remove it to reduce any confusion if someone were to try to use it. CC: Rusty Russell CC: Johan Hovold CC: Alan Stern CC: Mauro Carvalho Chehab Signed-off-by: Greg Kroah-Hartman