kernel/linux.git/drivers/usb/host/isp1362.h, branch v4.9.331

USB: isp1362: move debug files from proc to debugfs

2013-07-24T21:43:05+00:00

Drivers should not be putting debug files in /proc/ that is what debugfs is for, so move the isp1362 driver's debug file to debugfs. Reviewed-by: Felipe Balbi Signed-off-by: Greg Kroah-Hartman

USB: isp1362: remove CONFIG_USB_DEBUG dependency

2013-07-23T23:35:17+00:00

Now that the debugging macros are cleaned up, just rely on the dynamic debug code in the kernel to do the debug messages for the driver. This lets debugging be enabled without having to rebuild the driver, an important thing for users that can not do it. Acked-by: Felipe Balbi Signed-off-by: Greg Kroah-Hartman

USB: isp1362: remove _DBG() usage

2013-07-23T23:35:17+00:00

If you want a debug call, just make it, so move to using the already-there DBG() call. No need to make things more complex than they really need to be. Acked-by: Felipe Balbi Signed-off-by: Greg Kroah-Hartman

USB: isp1362: remove unused _WARN_ON() calls

2013-07-23T23:35:17+00:00

Like _BUG_ON(), _WARN_ON() wasn't ever being used, so just delete it, as obviously things are working properly now (if not, we have bigger problems...) Acked-by: Felipe Balbi Signed-off-by: Greg Kroah-Hartman

USB: isp1362: remove unused _BUG_ON() calls

2013-07-23T23:35:17+00:00

We shouldn't ever panic in a driver, and these calls were never being used, so just delete them, as obviously the driver is working properly now (right?) Acked-by: Felipe Balbi Signed-off-by: Greg Kroah-Hartman

USB: host: Remove dead CONFIG_ARCH_KARO

2010-08-10T21:35:40+00:00

CONFIG_ARCH_KARO doesn't exist in Kconfig and is never defined anywhere else, therefore removing all references for it from the source code. Signed-off-by: Christian Dietrich Acked-by: Ryan Mallon Signed-off-by: Greg Kroah-Hartman

USB: isp1362: fix inw warning on Blackfin systems

2010-06-04T20:16:18+00:00

The Blackfin code is incorrectly casting the argument to inw() to a pointer. Signed-off-by: Mike Frysinger Signed-off-by: Greg Kroah-Hartman

USB: FIX bitfield istl_flip:1, make it unsigned.

2009-12-11T19:55:20+00:00

istl_flip is a signed bitfield of one bit so it can be -1 or 0. However in drivers/usb/host/isp1362-hcd.c:1103: finish_iso_transfers(isp1362_hcd, &isp1362_hcd->istl_queue[isp1362_hcd->istl_flip]); So if isp1362_hcd->istl_flip is set, the 2nd argument becomes &isp1362_hcd->istl_queue[-1], which is invalid. Signed-off-by: Roel Kluin Acked-by: Mike Frysinger Signed-off-by: Greg Kroah-Hartman

USB: isp1362: fix build warnings on 64-bit systems

2009-10-09T20:52:07+00:00

A bunch of places assumed pointers were 32-bits in size (bit checking and debug output), but none of these affected runtime functionality. Signed-off-by: Mike Frysinger Signed-off-by: Greg Kroah-Hartman

USB: isp1362: fix pulldown register defines and conf logic

2009-09-23T13:46:33+00:00

HCHWCFG_PULLDOWN_DS2 and HCHWCFG_PULLDOWN_DS1 were swapped. Incorrect operator precedence in isp1362_hc_start() hid part of the problem. This fixes a problem where Port 1 in Host mode fails to see disconnects. Signed-Off-By: Ken MacLeod Signed-off-by: Greg Kroah-Hartman