kernel/linux.git/drivers/usb/dwc3/debugfs.c, branch v5.4.151

usb: dwc3: debugfs: Add and remove endpoint dirs dynamically

2021-06-23T12:41:31+00:00

commit 8d396bb0a5b62b326f6be7594d8bd46b088296bd upstream. The DWC3 DebugFS directory and files are currently created once during probe. This includes creation of subdirectories for each of the gadget's endpoints. This works fine for peripheral-only controllers, as dwc3_core_init_mode() calls dwc3_gadget_init() just prior to calling dwc3_debugfs_init(). However, for dual-role controllers, dwc3_core_init_mode() will instead call dwc3_drd_init() which is problematic in a few ways. First, the initial state must be determined, then dwc3_set_mode() will have to schedule drd_work and by then dwc3_debugfs_init() could have already been invoked. Even if the initial mode is peripheral, dwc3_gadget_init() happens after the DebugFS files are created, and worse so if the initial state is host and the controller switches to peripheral much later. And secondly, even if the gadget endpoints' debug entries were successfully created, if the controller exits peripheral mode, its dwc3_eps are freed so the debug files would now hold stale references. So it is best if the DebugFS endpoint entries are created and removed dynamically at the same time the underlying dwc3_eps are. Do this by calling dwc3_debugfs_create_endpoint_dir() as each endpoint is created, and conversely remove the DebugFS entry when the endpoint is freed. Fixes: 41ce1456e1db ("usb: dwc3: core: make dwc3_set_mode() work properly") Cc: stable Reviewed-by: Peter Chen Signed-off-by: Jack Pham Link: https://lore.kernel.org/r/20210529192932.22912-1-jackp@codeaurora.org Signed-off-by: Greg Kroah-Hartman

usb: dwc3: debugfs: Print/set link state for peripheral mode

2018-11-26T07:06:31+00:00

Current implementation only prints/sets the link state for peripheral mode only. Check and prevent printing bogus link state if the current mode of operation is not peripheral. Signed-off-by: Thinh Nguyen Signed-off-by: Felipe Balbi

usb: dwc3: debugfs: Properly print/set link state for HS

2018-11-26T07:06:31+00:00

Highspeed device and below has different state names than superspeed and higher. Add proper checks and printouts of link states for highspeed and below. Signed-off-by: Thinh Nguyen Signed-off-by: Felipe Balbi

usb: dwc3: debugfs: Dump internal LSP and ep registers

2018-11-26T07:06:31+00:00

To dump internal LSP and endpoint state debug registers, we must write to GDBGLSPMUX register. This patch correctly dump LSP and endpoint states from the debug registers. If the controller is in device mode, all LSP and endpoint state registers will be dumped via the debugfs attribute "lsp_dump". In host mode, the user has to write the LSP number to "lsp_dump" to dump a specific LSP selection. Fixes: 80b776340c78 ("usb: dwc3: Dump LSP and BMU debug info") Signed-off-by: Thinh Nguyen Signed-off-by: Felipe Balbi

usb: dwc3: debugfs: Print eps Tx/RxFIFO in bytes

2018-11-26T07:06:31+00:00

TxFIFO and RxFIFO from GDBGFIFOSPACE are fifo depths in MDWIDTH. Convert them into bytes for easier read. Signed-off-by: Thinh Nguyen Signed-off-by: Felipe Balbi

usb: dwc3: debugfs: Properly name Tx/RxFIFO

2018-11-26T07:06:31+00:00

The Tx/RxFIFO types in the GDBGFIFOSPACE.FIFO_QUEUE_SELECT are not queue. Properly rename them. Signed-off-by: Thinh Nguyen Signed-off-by: Felipe Balbi

USB: dwc3: no need to check return value of debugfs_create functions

2018-05-31T10:54:22+00:00

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Felipe Balbi Signed-off-by: Greg Kroah-Hartman

usb: dwc3: Dump LSP and BMU debug info

2018-03-22T08:49:02+00:00

Dump LSP and BMU debug info. Signed-off-by: Thinh Nguyen Signed-off-by: Felipe Balbi

usb: dwc3: debugfs: Re-use DEFINE_SHOW_ATTRIBUTE() macro

2018-03-08T13:12:00+00:00

...instead of open coding file operations followed by custom ->open() callbacks per each attribute. Reviewed-by: Andy Shevchenko Signed-off-by: Felipe Balbi

USB: dwc3: Remove redundant license text

2017-11-07T14:45:01+00:00

Now that the SPDX tag is in all USB files, that identifies the license in a specific and legally-defined manner. So the extra GPL text wording can be removed as it is no longer needed at all. This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL license text. And there's unneeded stuff like the address (sometimes incorrect) for the FSF which is never needed. No copyright headers or other non-license-description text was removed. Cc: Kukjin Kim Cc: Krzysztof Kozlowski Cc: Patrice Chotard Acked-by: Felipe Balbi Signed-off-by: Greg Kroah-Hartman