kernel/linux.git/drivers/usb/core/devio.c, branch linux-2.6.35.y

usb: core: fix information leak to userland

2010-12-14T22:40:13+00:00

commit 886ccd4520064408ce5876cfe00554ce52ecf4a7 upstream. Structure usbdevfs_connectinfo is copied to userland with padding byted after "slow" field uninitialized. It leads to leaking of contents of kernel stack memory. Signed-off-by: Vasiliy Kulikov Signed-off-by: Greg Kroah-Hartman Signed-off-by: Andi Kleen

USB: make hcd.h public (drivers dependency)

2010-05-20T20:21:30+00:00

The usbcore headers: hcd.h and hub.h are shared between usbcore, HCDs and a couple of other drivers (e.g. USBIP modules). So, it makes sense to move them into a more public location and to cleanup dependency of those modules on kernel internal headers. This patch moves hcd.h from drivers/usb/core into include/linux/usb/ Signed-of-by: Eric Lescouet Cc: Alan Stern Signed-off-by: Greg Kroah-Hartman

USB: fix usbfs regression

2010-03-19T14:24:02+00:00

This patch (as1352) fixes a bug in the way isochronous input data is returned to userspace for usbfs transfers. The entire buffer must be copied, not just the first actual_length bytes, because the individual packets will be discontiguous if any of them are short. Reported-by: Markus Rechberger Signed-off-by: Alan Stern CC: stable Signed-off-by: Greg Kroah-Hartman

USB: usbfs_snoop: add data logging back in

2010-03-02T22:54:37+00:00

Uses the new snoop function from commit 4c6e8971cbe0148085, but includes the buffer data where appropriate, as before. Signed-off-by: Chris Frey Signed-off-by: Greg Kroah-Hartman

USB: BKL removal from ioctl path of usbfs

2010-03-02T22:54:32+00:00

Total removal from the ioctl code path except for the outcall to external modules. Locking is ensured by the normal locks of usbfs. Signed-off-by: Oliver Neukum Cc: Alan Stern Signed-off-by: Greg Kroah-Hartman

USB: Reduce scope of BKL in usb ioctl handling

2010-03-02T22:54:24+00:00

This pushes BKL down in ioctl handling and drops it for some important ioctls Signed-off-by: Oliver Neukum Signed-off-by: Greg Kroah-Hartman

USB: Remove BKL from lseek implementations

2010-03-02T22:54:23+00:00

Replace it by mutex_lock(&file->f_dentry->d_inode->i_mutex); following the example of the generic method Signed-off-by: Oliver Neukum Signed-off-by: Greg Kroah-Hartman

USB: Remove BKL from usbdev_open()

2010-03-02T22:54:22+00:00

Locking had long been changed making BKL redundant. Simply remove it. Signed-off-by: Oliver Neukum Cc: Alan Stern Signed-off-by: Greg Kroah-Hartman

USB: change locking for device-level autosuspend

2010-03-02T22:54:08+00:00

This patch (as1323) changes the locking requirements for usb_autosuspend_device(), usb_autoresume_device(), and usb_try_autosuspend_device(). This isn't a very important change; mainly it's meant to make the locking more uniform. The most tricky part of the patch involves changes to usbdev_open(). To avoid an ABBA locking problem, it was necessary to reduce the region protected by usbfs_mutex. Since that mutex now protects only against simultaneous open and remove, this posed no difficulty -- its scope was larger than necessary. And it turns out that usbfs_mutex is no longer needed in usbdev_release() at all. The list of usbfs "ps" structures is now protected by the device lock instead of by usbfs_mutex. Signed-off-by: Alan Stern Signed-off-by: Greg Kroah-Hartman

USB: check the endpoint type against the pipe type

2010-03-02T22:53:07+00:00

This patch (as1316) adds some error checking to usb_submit_urb(). It's conditional on CONFIG_USB_DEBUG, so it won't affect normal users. The new check makes sure that the actual type of the endpoint described by urb->pipe agrees with the type encoded in the pipe value. The USB error code documentation is updated to include the code returned by the new check, and the usbfs SUBMITURB handler is updated to use the correct pipe type when legacy user code tries to submit a bulk transfer to an interrupt endpoint. Signed-off-by: Alan Stern Signed-off-by: Greg Kroah-Hartman