kernel/linux.git/drivers/tty/serial/xilinx_uartps.c, branch linux-4.4.y

serial: uartps: console_setup() can't be placed to init section

2019-04-27T07:33:58+00:00

[ Upstream commit 4bb1ce2350a598502b23088b169e16b43d4bc639 ] When console device is rebinded, console_setup() is called again. But marking it as __init means that function will be clear after boot is complete. If console device is binded again console_setup() is not found and error "Unable to handle kernel paging request at virtual address" is reported. Signed-off-by: Michal Simek Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin

serial: xuartps: Fix out-of-bounds access through DT alias

2018-05-30T05:49:14+00:00

[ Upstream commit e7d75e18d0fc3f7193b65282b651f980c778d935 ] The cdns_uart_port[] array is indexed using a value derived from the "serialN" alias in DT, which may lead to an out-of-bounds access. Fix this by adding a range check. Fixes: 928e9263492069ee ("tty: xuartps: Initialize ports according to aliases") Signed-off-by: Geert Uytterhoeven Reviewed-by: Michal Simek Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman

serial: xuartps: add __init to earlycon write method

2015-05-10T17:10:08+00:00

Early console functions are only used during the early boot stage. This change just saves a small amount of memory footprint. Signed-off-by: Masahiro Yamada Signed-off-by: Greg Kroah-Hartman

serial: xilinx: Use platform_get_irq to get irq description structure

2015-04-28T12:26:21+00:00

For systems with CONFIG_SERIAL_OF_PLATFORM=y and device_type = "serial"; property in DT of_serial.c driver maps and unmaps IRQ (because driver probe fails). Then a driver is called but irq mapping is not created that's why driver is failing again in again on request_irq(). Based on this use platform_get_irq() instead of platform_get_resource() which is doing irq_desc allocation and driver itself can request IRQ. Fix both xilinx serial drivers in the tree. Signed-off-by: Michal Simek CC: Signed-off-by: Greg Kroah-Hartman

serial: xuartps: Fix check in console_setup().

2015-03-26T21:55:18+00:00

cdns_uart_console_setup() checks port->mapbase != 0, but the port may not be initialized yet even if this condition is met [e.g., ioremap() may have failed]. Check port->membase != NULL instead, similar to cdns_early_console_setup(). Signed-off-by: Thomas Betker Reviewed-by: Michal Simek Signed-off-by: Greg Kroah-Hartman

serial: xuartps: Get rid of register access macros.

2015-03-26T21:54:07+00:00

Get rid of cdns_uart_readl() and cdns_uart_writel() and just call readl() and writel() directly. Most of the patch was created by search-and-replace (I had to convert a few lines manually, and break some lines longer than 80 columns): * s/cdns_uart_readl(/readl(port->membase + /g * s/cdns_uart_writel(\([^,]*\),/writel(\1, port->membase +/g Signed-off-by: Thomas Betker Acked-by: Sören Brinkmann Signed-off-by: Greg Kroah-Hartman

serial: xuartps: Fix iobase use.

2015-03-26T21:52:30+00:00

cdns_uart_get_port() sets port->iobase = 1 to "mark port in use", but this "in use" condition is not checked anywhere else in the code. So remove the line, keeping port->iobase = 0 (which also makes more sense). Signed-off-by: Thomas Betker Signed-off-by: Greg Kroah-Hartman

serial: xuartps: Fix cdns_uart_port[] definition.

2015-03-26T21:52:29+00:00

The code assumes that the array cdns_uart_port[] has dimension CDNS_UART_NR_PORTS, so let us define it this way. Signed-off-by: Thomas Betker Reviewed-by: Michal Simek Signed-off-by: Greg Kroah-Hartman

serial: xuartps: Fix register space size.

2015-03-26T21:52:29+00:00

The register space size is 0x1000, and this value [not 0xfff] should be provided to request_mem_region(), ioremap(), etc. Signed-off-by: Thomas Betker Reviewed-by: Michal Simek Signed-off-by: Greg Kroah-Hartman

tty: constify of_device_id array

2015-03-26T21:49:10+00:00

of_device_id is always used as const. (See driver.of_match_table and open firmware functions) Signed-off-by: Fabian Frederick Acked-by: Peter Korsgaard Acked-by: Timur Tabi Acked-by: Patrice Chotard Signed-off-by: Greg Kroah-Hartman