kernel/linux.git/drivers/tty/serial/uartlite.c, branch v4.14.286

serial: uartlite: fix exit path null pointer

2019-10-17T20:43:29+00:00

commit a553add0846f355a28ed4e81134012e4a1e280c2 upstream. Call uart_unregister_driver() conditionally instead of unconditionally, only if it has been previously registered. This uses driver.state, just as the sh-sci.c driver does. Fixes this null pointer dereference in tty_unregister_driver(), since the 'driver' argument is null: general protection fault: 0000 [#1] PREEMPT SMP KASAN PTI RIP: 0010:tty_unregister_driver+0x25/0x1d0 Fixes: 238b8721a554 ("[PATCH] serial uartlite driver") Signed-off-by: Randy Dunlap Cc: stable Cc: Peter Korsgaard Link: https://lore.kernel.org/r/9c8e6581-6fcc-a595-0897-4d90f5d710df@infradead.org Signed-off-by: Greg Kroah-Hartman

uartlite: Adding a kernel parameter for the number of uartlites

2017-03-17T05:14:30+00:00

The number of uartlites should be set by a kernel parameter instead of using a #define. This allows the user to set the number of uartlites using only kconfig and not modifying kernel source. The uartlite is used by FPGAs that support a basically unlimited number of uarts so limiting it at 16 dosn't make sense as users might need more than that. Signed-off-by: Sam Povilus Signed-off-by: Greg Kroah-Hartman

serial-uartlite: constify uart_ops structures

2016-09-02T13:01:16+00:00

Check for uart_ops structures that are only stored in the ops field of a uart_port structure. This field is declared const, so uart_ops structures that have this property can be declared as const also. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @r disable optional_qualifier@ identifier i; position p; @@ static struct uart_ops i@p = { ... }; @ok@ identifier r.i; struct uart_port e; position p; @@ e.ops = &i@p; @bad@ position p != {r.p,ok.p}; identifier r.i; struct uart_ops e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct uart_ops i = { ... }; // Signed-off-by: Julia Lawall Signed-off-by: Greg Kroah-Hartman

serial-uartlite: Constify uartlite_be/uartlite_le

2016-04-30T16:26:55+00:00

Made uartlite_be and uartlite_le constants. Signed-off-by: Maarten Brock Signed-off-by: Greg Kroah-Hartman

Revert "serial-uartlite: Constify uartlite_be/uartlite_le"

2016-04-19T06:15:38+00:00

This reverts commit 2905697a82eaf20606ced164d853b52d1b94aaa8. The commit introduced two build warnings: drivers/tty/serial/uartlite.c: In function ‘ulite_request_port’: drivers/tty/serial/uartlite.c:348:21: warning: assignment discards ‘const’ qualifier from pointer target type port->private_data = &uartlite_be; ^ drivers/tty/serial/uartlite.c:354:22: warning: assignment discards ‘const’ qualifier from pointer target type port->private_data = &uartlite_le; ^ Signed-off-by: Sudip Mukherjee Cc: Maarten Brock Cc: Arnd Bergmann Signed-off-by: Greg Kroah-Hartman

serial-uartlite: Configure for rising edge irq trigger.

2016-03-08T00:11:14+00:00

This device generates a short rising pulse on the interrupt request line. Signed-off-by: Maarten Brock Signed-off-by: Greg Kroah-Hartman

serial-uartlite: Spinlock inside the loop.

2016-03-08T00:11:14+00:00

Better to hold the spinlock as short as possible. Signed-off-by: Maarten Brock Signed-off-by: Greg Kroah-Hartman

serial-uartlite: Constify uartlite_be/uartlite_le

2016-03-08T00:11:14+00:00

Made uartlite_be and uartlite_le constants. Signed-off-by: Maarten Brock Signed-off-by: Greg Kroah-Hartman

serial-uartlite: Enlarge maximum nr of devices to 16.

2016-03-08T00:11:14+00:00

This device is ideal to use when you need a lot of uarts in your FPGA. Try not to force all those users to patch their kernel. Signed-off-by: Maarten Brock Signed-off-by: Greg Kroah-Hartman

serial-uartlite: fix missing locking in isr

2016-02-07T06:56:43+00:00

The uartlite driver suffers from missing/duplicate/corrupted character data when the interrupt handler runs concurrently with access to the device from another cpu. Take the port spinlock to exclude concurrent access. Signed-off-by: Rich Felker Signed-off-by: Greg Kroah-Hartman