Linux kernel stable tree (mirror) https://git.radix-linux.su/kernel/linux.git/atom?h=v4.4.239 2017-10-21T15:09:06+00:00 2017-10-21T15:09:06+00:00 Greg Kroah-Hartman gregkh@linuxfoundation.org 2017-10-19T13:28:08+00:00 urn:sha1:401231d063c5b362428b80739896a5ee8513d8c5 This reverts commit 01b3db29ba1edd79b9c3e7cd294739b70257d278 which is commit 1a5c2d1de7d35f5eb9793266237903348989502b upstream. Ben writes: This fixes a bug introduced in 4.6 by commit 465893e18878 "tty: goldfish: support platform_device with id -1". For earlier kernel versions, it *introduces* a bug. So let's drop it. Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk> Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Cc: Sasha Levin <alexander.levin@verizon.com> Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org 2017-10-08T08:14:17+00:00 Christophe JAILLET christophe.jaillet@wanadoo.fr 2017-01-09T00:26:37+00:00 urn:sha1:01b3db29ba1edd79b9c3e7cd294739b70257d278 [ Upstream commit 1a5c2d1de7d35f5eb9793266237903348989502b ] 'request_irq()' and 'free_irq()' should be called with the same dev_id. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Sasha Levin <alexander.levin@verizon.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 2015-05-31T02:40:14+00:00 Peter Senna Tschudin peter.senna@gmail.com 2015-05-19T09:44:46+00:00 urn:sha1:07d783fd830a49008f3b2764ae7b6033ee1bf329 As the first argument of gf_write64() was of type unsigned long, and as some calls to gf_write64() were casting the first argument from void * to u64 the compiler and/or sparse were printing warnings for casts of wrong sizes when compiling for i386. This patch changes the type of the first argument of gf_write64() to const void *, and update calls to the function. This change fixed the warnings and allowed to remove casts from 3 calls to gf_write64(). In addition gf_write64() was renamed to gf_write_ptr() as the name was misleading because it only writes 32 bits on 32 bit systems. gf_write_dma_addr() was added to handle dma_addr_t values which is used at drivers/staging/goldfish/goldfish_audio.c. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 2015-04-14T16:50:27+00:00 Linus Torvalds torvalds@linux-foundation.org 2015-04-14T16:50:27+00:00 urn:sha1:d0bbe0dd353af9521e9d8bc5236308c677b6f62a Pull trivial tree from Jiri Kosina: "Usual trivial tree updates. Nothing outstanding -- mostly printk() and comment fixes and unused identifier removals" * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: goldfish: goldfish_tty_probe() is not using 'i' any more powerpc: Fix comment in smu.h qla2xxx: Fix printks in ql_log message lib: correct link to the original source for div64_u64 si2168, tda10071, m88ds3103: Fix firmware wording usb: storage: Fix printk in isd200_log_config() qla2xxx: Fix printk in qla25xx_setup_mode init/main: fix reset_device comment ipwireless: missing assignment goldfish: remove unreachable line of code coredump: Fix do_coredump() comment stacktrace.h: remove duplicate declaration task_struct smpboot.h: Remove unused function prototype treewide: Fix typo in printk messages treewide: Fix typo in printk messages mod_devicetable: fix comment for match_flags 2015-03-10T09:45:30+00:00 Jiri Kosina jkosina@suse.cz 2015-03-10T09:45:30+00:00 urn:sha1:0e4f93e5017d9d8080bbd34db17836e090eb46fe The only place where 'i' has been used was a dead code that got removed by 2a2483685a9de ("goldfish: remove unreachable line of code"). Remove the last reference to the variable as well. Fixes: 2a2483685a9de ("goldfish: remove unreachable line of code") Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Jiri Kosina <jkosina@suse.cz> 2015-03-06T22:11:32+00:00 Alan gnomes@lxorguk.ukuu.org.uk 2015-02-19T21:11:13+00:00 urn:sha1:2a2483685a9decd0af60f1dc9e49f46f9e65891b Signed-off-by: Alan Cox <alan@linux.intel.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz> 2014-11-06T00:12:45+00:00 Dan Carpenter dan.carpenter@oracle.com 2014-10-29T08:43:25+00:00 urn:sha1:fda2b418a1945bebd5c8f670768fe75c515816ec The goldfish_ttys[] array has "goldfish_tty_line_count" number of elements. It's allocated in goldfish_tty_create_driver(). This test should be >= instead of >. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Alan Cox <alan@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 2014-11-06T00:12:05+00:00 Fabian Frederick fabf@skynet.be 2014-09-28T18:10:17+00:00 urn:sha1:a4dc923640418120fe7bbdfac149397bc761a249 drivers/tty/goldfish.c:160:46: warning: Using plain integer as NULL pointer drivers/tty/goldfish.c:320:22: warning: Using plain integer as NULL pointer Signed-off-by: Fabian Frederick <fabf@skynet.be> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 2014-05-15T20:20:42+00:00 Alan alan@linux.intel.com 2014-05-12T15:57:14+00:00 urn:sha1:d78055dc9c786b392ce7b593c479bb9a3e1da61d Mostly spacing changes, also making the operations structure const Signed-off-by: Alan Cox <alan@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 2014-05-15T20:20:42+00:00 Alan alan@acox1-desk.ger.corp.intel.com 2014-05-12T15:57:05+00:00 urn:sha1:e0f682e05f51c9eff68e61ce2350155895cd739e Use the helper we now have available. Signed-off-by: Alan Cox <alan@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>