kernel/linux.git/drivers/thunderbolt/usb4.c, branch linux-5.9.y

thunderbolt: Ensure left shift of 512 does not overflow a 32 bit int

2020-07-01T10:46:47+00:00

The 32 bit int value 512 is being left shifted and then used in a context that expects the expression to be a larger unsigned long. There may be a potential integer overflow, so make 512 a UL before shift to avoid any such issues. Addresses-Coverity: ("Uninintentional integer overflow") Fixes: 3b1d8d577ca8 ("thunderbolt: Implement USB3 bandwidth negotiation routines") Signed-off-by: Colin Ian King Signed-off-by: Mika Westerberg

thunderbolt: Implement USB4 port sideband operations for retimer access

2020-06-22T16:58:32+00:00

USB4 spec specifies standard set of sideband operations that are send over the low speed link to access either retimers on the link or the link parter (the other router). The USB4 retimer spec extends these and adds operations for retimer NVM upgrade. This implements the retimer access and NVM upgrade USB4 port sideband operations which we need for retimer support in the patch that follows. Signed-off-by: Rajmohan Mani Co-developed-by: Mika Westerberg Signed-off-by: Mika Westerberg

thunderbolt: Retry USB4 block read operation

2020-06-22T16:58:32+00:00

Especially when accessing retimers over USB4 sideband operations the possibility to get read errors seems to be higher so make the usb4_do_read_data() retry a couple of times if it sees any other error than -ENODEV (device is gone). We can only do this for read side because it carries the offset as part of metadata (as opposed to writes). Signed-off-by: Mika Westerberg

thunderbolt: Generalize usb4_switch_do_[read|write]_data()

2020-06-22T16:58:32+00:00

Currently these functions operate on struct tb_switch but we are going to need the same functionality with retimers as well so make the two functions work with an arbitrary object that gets passed as parameter to the callbacks. Signed-off-by: Mika Westerberg

thunderbolt: Implement USB3 bandwidth negotiation routines

2020-06-22T16:58:20+00:00

Each host router USB3 downstream adapter has a set of registers that are used to negotiate bandwidth between the connection manager and the internal xHCI controller. These registers allow dynamic bandwidth management for USB3 isochronous traffic based on what is actually consumed vs. allocated at any given time. Implement these USB3 bandwidth negotiation routines to allow the software connection manager take advantage of these. Signed-off-by: Mika Westerberg

thunderbolt: Make usb4_switch_map_pcie_down() also return enabled ports

2020-06-22T16:58:20+00:00

Just for symmetry with the usb4_switch_map_usb3_down() make this one also return ports that are enabled. Signed-off-by: Mika Westerberg

thunderbolt: Make usb4_switch_map_usb3_down() also return enabled ports

2020-06-22T16:58:20+00:00

We need to call this on enabled ports in order to find the mapping from host router USB4 port to a USB 3.x downstream adapter, so make the function return enabled ports as well. While there fix parameter alignment in tb_find_usb3_down(). Signed-off-by: Mika Westerberg

thunderbolt: Do not tunnel USB3 if link is not USB4

2020-06-22T16:58:20+00:00

USB3 tunneling is possible only over USB4 link so don't create USB3 tunnels if that's not the case. Signed-off-by: Mika Westerberg

thunderbolt: Check return value of tb_sw_read() in usb4_switch_op()

2020-04-28T17:00:59+00:00

The function misses checking return value of tb_sw_read() before it accesses the value that was read. Fix this by checking the return value first. Fixes: b04079837b20 ("thunderbolt: Add initial support for USB4") Signed-off-by: Mika Westerberg Reviewed-by: Yehezkel Bernat Cc: stable Signed-off-by: Greg Kroah-Hartman

thunderbolt: Add missing kernel-doc parameter descriptions

2020-02-14T16:38:15+00:00

Two functions that were added for USB4 support miss kernel-doc parameter descriptions so add them now. Signed-off-by: Mika Westerberg Link: https://lore.kernel.org/r/20200214121638.75589-1-mika.westerberg@linux.intel.com Signed-off-by: Greg Kroah-Hartman