kernel/linux.git/drivers/thunderbolt/eeprom.c, branch v7.0.10Linux kernel stable tree (mirror)https://git.radix-linux.su/kernel/linux.git/atom?h=v7.0.102025-10-20T06:17:36+00:00thunderbolt: Fix typo in tb_eeprom_ctl_read documentation2025-10-20T06:17:36+00:00Dominik Karol Piątkowskidominik.karol.piatkowski@protonmail.com2025-10-02T17:35:33+00:00urn:sha1:56bcf64b613127cbccae91d55becf5e5da235cbd
Fix presumed copy-paste typo of tb_eeprom_ctl_read documentation
referring to tb_eeprom_ctl_write.
Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
thunderbolt: Update eeprom.c function documentation2025-09-17T05:32:59+00:00Alan Borzeszkowskialan.borzeszkowski@linux.intel.com2025-08-27T11:56:28+00:00urn:sha1:728ab0e4a0ca78f550ca59d9267e0b2835f523fa
Make eeprom.c function documentation compliant with current kernel-doc
standards. No functional changes.
Signed-off-by: Alan Borzeszkowski <alan.borzeszkowski@linux.intel.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
lib/crc32: standardize on crc32c() name for Castagnoli CRC322025-02-09T04:06:30+00:00Eric Biggersebiggers@google.com2025-02-08T02:49:09+00:00urn:sha1:8df36829045a133d558421cc3cf2384a6d9e47cc
For historical reasons, the Castagnoli CRC32 is available under 3 names:
crc32c(), crc32c_le(), and __crc32c_le(). Most callers use crc32c().
The more verbose versions are not really warranted; there is no "_be"
version that the "_le" version needs to be differentiated from, and the
leading underscores are pointless.
Therefore, let's standardize on just crc32c(). Remove the other two
names, and update callers accordingly.
Specifically, the new crc32c() comes from what was previously
__crc32c_le(), so compared to the old crc32c() it now takes a size_t
length rather than unsigned int, and it's now in linux/crc32.h instead
of just linux/crc32c.h (which includes linux/crc32.h).
Later patches will also rename __crc32c_le_combine(), crc32c_le_base(),
and crc32c_le_arch().
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
Link: https://lore.kernel.org/r/20250208024911.14936-5-ebiggers@kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com>
thunderbolt: Expose router DROM through debugfs2025-01-05T08:35:03+00:00Mika Westerbergmika.westerberg@linux.intel.com2024-12-21T12:52:43+00:00urn:sha1:43d84701d2aa147eab39b529919ffaf35f724bbb
Router DROM contains information that might be usable for development
and debugging purposes. For example when new entries are added to the
USB4 spec it is useful to be able to look for them without need to
change the kernel.
For this reason expose the DROM through debugfs.
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
thunderbolt: Ignore data CRC mismatch for USB4 routers2023-06-16T06:53:27+00:00Mika Westerbergmika.westerberg@linux.intel.com2022-12-16T11:41:12+00:00urn:sha1:4796efdd16a8066919a3ff479e0bbc14bac816ff
This is also something not always updated after the DROM contents itself
so issue warning but continue parsing it as we do for pre-USB4 DROMs
too.
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
thunderbolt: Refactor DROM reading2023-03-14T14:15:45+00:00Mario Limonciellomario.limonciello@amd.com2023-02-23T21:07:43+00:00urn:sha1:ebde5ba27c640e08e92c83fe30be0d9fa224eea9
The NVM reading code has a series of gotos that potentially introduce
unexpected behaviors with retries if something unexpected has failed
to parse.
Refactor the code to remove the gotos and drop the retry logic.
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
[mw: renamed root switch to host router, split device handling too]
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
thunderbolt: use `tb_eeprom_get_drom_offset` to discover DROM offset2023-03-14T13:54:49+00:00Mario Limonciellomario.limonciello@amd.com2023-02-23T21:07:42+00:00urn:sha1:c8325b3227508459fab42f4f48fb232bc687f1ba
The static function `tb_eeprom_get_drom_offset` has more safety guards
for the DROM offset fetching. Use this instead of just `tb_sw_read`
No intended functional changes.
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
thunderbolt: Rename EEPROM handling bits to match USB4 spec2022-03-04T14:10:36+00:00Mario Limonciellomario.limonciello@amd.com2022-03-03T13:13:28+00:00urn:sha1:144c4a77a3e1e520daba85eafd28999af22e1aa5
The structure `tb_eeprom_ctl` is used to show the bits accessed when
reading/writing EEPROM.
As this structure is specified in the USB4 spec as `VSC_CS_4` update
the names and use of members to match the specification. This should not
change anything functionally.
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
thunderbolt: Retry DROM reads for more failure scenarios2022-03-04T14:10:36+00:00Mario Limonciellomario.limonciello@amd.com2022-03-03T13:13:24+00:00urn:sha1:e87491a9fd4e33eaf18ef69d8295bb07b31452b2
Currently DROM reads are only retried in the case that parsing failed.
However if the size or CRC fails, then there should also be a retry.
This helps with reading the DROM on TBT3 devices connected to AMD
Yellow Carp which will sometimes fail on the first attempt.
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
thunderbolt: Fix DROM handling for USB4 DROM2021-06-15T10:51:07+00:00Gil Finegil.fine@intel.com2021-06-14T13:52:10+00:00urn:sha1:b18f901382fdb74a138a0bf30458c54a023a1d86
DROM for USB4 host/device has a shorter header than Thunderbolt DROM
header. This patch addresses host/device with USB4 DROM (According to spec:
Universal Serial Bus 4 (USB4) Device ROM Specification, Rev 1.0, Feb-2021).
While there correct the data_len field to be 12 bits and rename
__unknown1 to reserved following the spec.
Signed-off-by: Gil Fine <gil.fine@intel.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>