kernel/linux.git/drivers/thermal/broadcom, branch v6.18.21Linux kernel stable tree (mirror)https://git.radix-linux.su/kernel/linux.git/atom?h=v6.18.212025-05-16T10:50:00+00:00thermal/drivers/bcm2835: Use %pC instead of %pCn2025-05-16T10:50:00+00:00Luca Ceresoliluca.ceresoli@bootlin.com2025-03-11T09:21:22+00:00urn:sha1:b0d71cb44ab676ba7ede46083cdfd4ac92b2fbea
The %pC and %pCn printk format specifiers produce the exact same string. In
preparation for removing %pCn, use %pC.
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Link: https://lore.kernel.org/r/20250311-vsprintf-pcn-v2-1-0af40fc7dee4@bootlin.com
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
thermal/drivers/brcmstb_thermal: Add support for BCM741102025-03-25T19:52:04+00:00Florian Fainelliflorian.fainelli@broadcom.com2025-01-16T19:38:42+00:00urn:sha1:09daf8f0d4204ccfdb59116daa7fe2badb7683bc
BCM74110 uses a different process node compared to previous chips that
requires a different equation, account for that.
Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
Link: https://lore.kernel.org/r/20250116193842.758788-3-florian.fainelli@broadcom.com
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
thermal: Switch back to struct platform_driver::remove()2024-11-13T15:17:57+00:00Uwe Kleine-Königu.kleine-koenig@baylibre.com2024-10-19T16:34:11+00:00urn:sha1:dd64594ca2c5b952570c3b885763b93ebe26fe9a
After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
return void") .remove() is (again) the right callback to implement for
platform drivers.
Convert all platform drivers below drivers/thermal to use .remove(), with
the eventual goal to drop struct platform_driver::remove_new(). As
.remove() and .remove_new() have the same prototypes, conversion is done
by just changing the structure member name in the driver initializer.
On the way make a few whitespace changes to make indention consistent.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Link: https://lore.kernel.org/r/20241019163412.304422-2-u.kleine-koenig@baylibre.com
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
thermal/drivers/brcmstb_thermal: Simplify with dev_err_probe()2024-09-02T11:09:49+00:00Yan Zhenyanzhen@vivo.com2024-08-30T10:39:18+00:00urn:sha1:b779bbb9df180e2ab5c89c666e01fe03eef7dc49
dev_err_probe() is used to log an error message during the probe process
of a device.
It can simplify the error path and unify a message template.
Using this helper is totally fine even if err is known to never
be -EPROBE_DEFER.
The benefit compared to a normal dev_err() is the standardized format
of the error code, it being emitted symbolically and the fact that
the error code is returned which allows more compact error paths.
Signed-off-by: Yan Zhen <yanzhen@vivo.com>
Link: https://lore.kernel.org/r/20240830103918.501234-1-yanzhen@vivo.com
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
thermal: broadcom: Use thermal_zone_get_crit_temp() in bcm2835_thermal_probe()2024-08-02T11:32:09+00:00Rafael J. Wysockirafael.j.wysocki@intel.com2024-07-29T15:53:59+00:00urn:sha1:5df9809c424fb889eb4ad44f856196d86aa389f7
Modify the bcm2835 thermal driver to use thermal_zone_get_crit_temp() in
bcm2835_thermal_probe() instead of relying on the assumption that the
critical trip index will always be 0.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
Link: https://patch.msgid.link/3322893.aeNJFYEL58@rjwysocki.net
thermal/drivers/broadcom: Simplify with dev_err_probe()2024-07-15T11:31:40+00:00Krzysztof Kozlowskikrzysztof.kozlowski@linaro.org2024-07-09T12:59:33+00:00urn:sha1:9d55cb3ba36e218839ca04c55e977ab6faac1707
Error handling in probe() can be a bit simpler with dev_err_probe().
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20240709-thermal-probe-v1-3-241644e2b6e0@linaro.org
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
thermal/drivers/broadcom: Simplify probe() with local dev variable2024-07-15T11:31:40+00:00Krzysztof Kozlowskikrzysztof.kozlowski@linaro.org2024-07-09T12:59:32+00:00urn:sha1:fd972a17451f9cd4f6c99415b5a9dcf856d93433
Simplify the probe() function by using local 'dev' instead of
&pdev->dev.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20240709-thermal-probe-v1-2-241644e2b6e0@linaro.org
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
thermal/drivers/broadcom: Fix race between removal and clock disable2024-07-15T11:31:40+00:00Krzysztof Kozlowskikrzysztof.kozlowski@linaro.org2024-07-09T12:59:31+00:00urn:sha1:e90c369cc2ffcf7145a46448de101f715a1f5584
During the probe, driver enables clocks necessary to access registers
(in get_temp()) and then registers thermal zone with managed-resources
(devm) interface. Removal of device is not done in reversed order,
because:
1. Clock will be disabled in driver remove() callback - thermal zone is
still registered and accessible to users,
2. devm interface will unregister thermal zone.
This leaves short window between (1) and (2) for accessing the
get_temp() callback with disabled clock.
Fix this by enabling clock also via devm-interface, so entire cleanup
path will be in proper, reversed order.
Fixes: 8454c8c09c77 ("thermal/drivers/bcm2835: Remove buggy call to thermal_of_zone_unregister")
Cc: stable@vger.kernel.org
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20240709-thermal-probe-v1-1-241644e2b6e0@linaro.org
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
thermal: ns: Convert to platform remove callback returning void2023-09-29T10:34:16+00:00Uwe Kleine-Königu.kleine-koenig@pengutronix.de2023-09-27T19:37:09+00:00urn:sha1:aa599650d26f6588723bc4c903704a7fa3df6c1e
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
thermal: bcm2835: Convert to platform remove callback returning void2023-09-29T10:34:16+00:00Uwe Kleine-Königu.kleine-koenig@pengutronix.de2023-09-27T19:37:08+00:00urn:sha1:f29ecd3748a28d0b52512afc81b3c13fd4a00c9b
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>