kernel/linux.git/drivers/staging/vt6655, branch v4.19.16

staging: vt6655: remove some redundant variables

2018-07-11T12:47:08+00:00

Variables rx_sts, sq, frame and is_pspoll are being assigned but are never used hence they are redundant and can be removed. Cleans up clang warnings: warning: variable 'sq' set but not used [-Wunused-but-set-variable] warning: variable 'rx_sts' set but not used [-Wunused-but-set-variable] warning: variable 'frame' set but not used [-Wunused-but-set-variable] warning: variable 'is_pspoll' set but not used [-Wunused-but-set-variable] Signed-off-by: Colin Ian King Signed-off-by: Greg Kroah-Hartman

staging: vt6655: remove unnecessary line breaks in function definition.

2018-04-23T13:23:36+00:00

This patch corrects the function definition style of CARDvSafeResetRx. Issue found by checkpatch. CHECK: Lines should not end with a '(' Signed-off-by: Danilo Alves Signed-off-by: Greg Kroah-Hartman

staging: vt6655: add handling memory leak on vnt_start()

2018-04-23T13:23:36+00:00

There was no code for handling memory leaks of device_init_rings() and request_irq(). It needs to free allocated memory in the device_init_rings() , when request_irq() would be failed. Add freeing sequences of irq and device init rings. Signed-off-by: Ji-Hun Kim Reviewed-by: Dan Carpenter Signed-off-by: Greg Kroah-Hartman

staging: vt6655: check for memory allocation failures

2018-04-23T13:23:36+00:00

There are no null pointer checking on rd_info and td_info values which are allocated by kzalloc. It has potential null pointer dereferencing issues. Implement error handling code on device_init_rd*, device_init_td* and vnt_start for the allocation failures. Signed-off-by: Ji-Hun Kim Reviewed-by: Dan Carpenter Signed-off-by: Greg Kroah-Hartman

staging: vt6655: Delete unused typedef enum _chip_type

2018-03-28T11:57:44+00:00

Delete unused typedef enum _chip_type. Signed-off-by: Nishka Dasgupta Acked-by: Julia Lawall Signed-off-by: Greg Kroah-Hartman

staging: vt6655: Delete unused typedef struct _version

2018-03-28T11:57:44+00:00

Delete unused typedef struct _version. Signed-off-by: Nishka Dasgupta Acked-by: Julia Lawall Signed-off-by: Greg Kroah-Hartman

staging: vt6655: Delete unused typedef enum _CARD_STATUS_TYPE

2018-03-28T11:57:43+00:00

Delete unused typedef enum _CARD_STATUS_TYPE. Signed-off-by: Nishka Dasgupta Acked-by: Julia Lawall Signed-off-by: Greg Kroah-Hartman

staging: vt6655: Delete unused enum CARD_PKT_TYPE

2018-03-28T11:57:43+00:00

Delete unused enum CARD_PKT_TYPE. Signed-off-by: Nishka Dasgupta Acked-by: Julia Lawall Signed-off-by: Greg Kroah-Hartman

staging: vt6655: Change typedef enum to enum

2018-03-22T17:27:42+00:00

Change typedef enum to enum. Issue found with checkpatch. Signed-off-by: Nishka Dasgupta Signed-off-by: Greg Kroah-Hartman

staging: vt6655: Fix style violation for line ending in '('

2018-03-06T12:01:11+00:00

Replace line ending with '(' with function parameters to resolve style issue found by checkpath. Signed-off-by: Rinkle Jain Acked-by: Julia Lawall Signed-off-by: Greg Kroah-Hartman