kernel/linux.git/drivers/staging/pi433, branch v4.14.286

staging: pi433: fix potential null dereference

2019-02-12T18:46:00+00:00

[ Upstream commit 64c4c4ca6c129a4191e8e1e91b2d5d9b8d08c518 ] Add a test for successful call to cdev_alloc() to avoid potential null dereference. Issue reported by smatch. Signed-off-by: Michael Straube Fixes: 874bcba65f9a ("staging: pi433: New driver") Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin

staging: pi433: Move limit check to switch default to kill warning

2017-09-18T10:25:31+00:00

With gcc-4.1.2: drivers/staging/pi433/rf69.c: In function ‘rf69_set_dio_mapping’: drivers/staging/pi433/rf69.c:566: warning: ‘regaddr’ may be used uninitialized in this function drivers/staging/pi433/rf69.c:565: warning: ‘shift’ may be used uninitialized in this function drivers/staging/pi433/rf69.c:564: warning: ‘mask’ may be used uninitialized in this function While this is a false positive, it can easily be fixed by moving the limit check into the "default" case of the switch statement. Signed-off-by: Geert Uytterhoeven Signed-off-by: Greg Kroah-Hartman

Staging: Pi433: style fix - tabs and spaces

2017-08-31T16:28:34+00:00

Fixed checkpatch errors, spaces before tabs. Found using checkpatch. Signed-off-by: Derek Robson Signed-off-by: Greg Kroah-Hartman

staging: pi433: fix spelling mistake: "preample" -> "preamble"

2017-08-31T16:28:34+00:00

Trivial fix to spelling mistake in dev_dbg message Signed-off-by: Colin Ian King Signed-off-by: Greg Kroah-Hartman

staging: pi433: fix interrupt handler signatures

2017-08-28T08:27:29+00:00

Remove "struct pt_regs *" parameter from interrupt handlers, since it is no longer passed to interrupt handlers. Also, convert return types to irqreturn_t. Additionally, move DIO_irq_handler variable into the setup_GPIO function, as it's not used outside of this function. Signed-off-by: Cihangir Akturk Signed-off-by: Greg Kroah-Hartman

staging: pi433: fixed coding style issues

2017-08-20T18:08:41+00:00

space required before the open parenthesis, open brace should be on previous line. Signed-off-by: Xiangyang Zhang Signed-off-by: Greg Kroah-Hartman

staging: pi433: replace INVALID_PARAM macro with inline code

2017-08-18T22:57:15+00:00

The following macro: \#define INVALID_PARAM { \ dev_dbg(&spi->dev, "set: illegal input param"); \ return -EINVAL; \ } affects control flow by having return statement. This is against Linux Kernel Coding Style and should be avoided and therefore this macro is replaced by inline code. Additionally following 3 minor issues: ERROR: code indent should use tabs where possible ERROR: spaces required around that '!=' (ctx:VxV) ERROR: space prohibited before that close parenthesis ')' were fiexed inline. Signed-off-by: Marcin Ciupak Signed-off-by: Greg Kroah-Hartman

staging: pi433: replace logical not with bitwise

2017-08-18T22:57:15+00:00

sparse reports the following warning "warning: dubious: x & !y". Replaced te logical not with bitwise to resolve the warning Signed-off-by: Quentin Swain Signed-off-by: Greg Kroah-Hartman

staging: pi433: rf69.c style fix - spaces open brace

2017-08-15T00:55:49+00:00

This patch fixes the following checkpatch.pl error: ERROR: space required before the open brace '{' in rf69.c file as requested by TODO file. Signed-off-by: Marcin Ciupak Signed-off-by: Greg Kroah-Hartman

staging: pi433: rf69.c style fix - else close brace

2017-08-15T00:55:48+00:00

This patch fixes the following checkpatch.pl error: ERROR: else should follow close brace '}' in rf69.c file as requested by TODO file. Signed-off-by: Marcin Ciupak Signed-off-by: Greg Kroah-Hartman