kernel/linux.git/drivers/staging/nvec, branch v3.18.100

staging: nvec: remove duplicated const

2017-10-08T08:11:22+00:00

commit 716baa7b430c66187a41e4d41eedf5de01343b21 upstream. Sparse checking warning: "drivers/staging/nvec/nvec_ps2.c:172:14: warning: duplicate const". Remove the duplicated const to fix the warning. Signed-off-by: Peng Fan Acked-by: Marc Dietrich Signed-off-by: Greg Kroah-Hartman

Revert "staging: nvec: ps2: change serio type to passthrough"

2017-04-18T05:55:47+00:00

commit 17c1c9ba15b238ef79b51cf40d855c05b58d5934 upstream. This reverts commit 36b30d6138f4677514aca35ab76c20c1604baaad. This is necessary to detect paz00 (ac100) touchpad properly as one speaking ETPS/2 protocol. Without it X.org's synaptics driver doesn't work as the touchpad is detected as an ImPS/2 mouse instead. Commit ec6184b1c717b8768122e25fe6d312f609cc1bb4 changed the way auto-detection is performed on ports marked as pass through and made the issue apparent. A pass through port is an additional PS/2 port used to connect a slave device to a master device that is using PS/2 to communicate with the host (so slave's PS/2 communication is tunneled over master's PS/2 link). "Synaptics PS/2 TouchPad Interfacing Guide" describes such a setup (PS/2 PASS-THROUGH OPTION section). Since paz00's embedded controller is not connected to a PS/2 port itself, the PS/2 interface it exposes is not a pass-through one. Signed-off-by: Paul Fertser Acked-by: Marc Dietrich Fixes: 36b30d6138f4 ("staging: nvec: ps2: change serio type to passthrough") Signed-off-by: Greg Kroah-Hartman Signed-off-by: Greg Kroah-Hartman

drivers: staging: nvec: remove bogus reset command for PS/2 interface

2017-04-18T05:55:47+00:00

commit d8f8a74d5fece355d2234e1731231d1aebc66b38 upstream. This command was sent behind serio's back and the answer to it was confusing atkbd probe function which lead to the elantech touchpad getting detected as a keyboard. To prevent this from happening just let every party do its part of the job. Signed-off-by: Paul Fertser Acked-by: Marc Dietrich Signed-off-by: Greg Kroah-Hartman

staging/nvec: Use platform_get_irq()

2014-07-31T00:18:47+00:00

As opposed to platform_get_resource(), the platform_get_irq() function has special code to handle driver probe deferral when booting using DT and where an interrupt provider hasn't been registered yet. While this is unlikely to become an issue for nvec, platform_get_irq() is the recommended way to get at interrupts. Signed-off-by: Thierry Reding Acked-by: Marc Dietrich Signed-off-by: Greg Kroah-Hartman

staging/nvec: Do not pass resource to mfd_add_devices()

2014-07-31T00:18:47+00:00

The mfd_add_devices() function takes a struct resource * as fifth argument, but the nvec driver passes in a void __iomem *. The driver gets away with it because none of the subdevices ever directly access the registers. Since subdevices never need to access the registers we can simply pass NULL instead. Signed-off-by: Thierry Reding Acked-by: Marc Dietrich Signed-off-by: Greg Kroah-Hartman

staging/nvec: Remove double const qualifier

2014-07-21T21:20:50+00:00

The SIMPLE_DEV_PM_OPS macro already uses the const qualifier, so there's no need to repeat it. Signed-off-by: Thierry Reding Acked-by: Marc Dietrich Signed-off-by: Greg Kroah-Hartman

staging: nvec: remove unneccessary 'out of memory' message

2014-07-09T19:14:06+00:00

Fix the following warning reported by checkpatch.pl: WARNING: Possible unnecessary 'out of memory' message 811: FILE: drivers/staging/nvec/nvec.c:811 Signed-off-by: Pawel Lebioda Acked-by: Marc Dietrich Reviewed-by: Thierry Reding Signed-off-by: Greg Kroah-Hartman

staging: nvec: remove unnecessary 'else' after 'return' statement

2014-07-09T19:14:06+00:00

Fix the following warning reported by checkpatch.pl: WARNING: else is not generally useful after a break or return 235: FILE: drivers/staging/nvec/nvec.c:235 Signed-off-by: Pawel Lebioda Acked-by: Marc Dietrich Reviewed-by: Thierry Reding Signed-off-by: Greg Kroah-Hartman

staging: nvec: insert blank lines after declarations

2014-07-09T19:14:06+00:00

This patch fixes coding style warnings reported by checkpatch.pl: "Missing a blank line after declarations". Signed-off-by: Pawel Lebioda Acked-by: Marc Dietrich Signed-off-by: Greg Kroah-Hartman

staging:nvec: Introduce the use of the managed version of kzalloc

2014-03-07T23:19:36+00:00

This patch moves shared private data kzalloc to managed devm_kzalloc. There are no kfree statements associated with this data, so using devm adds the possibility of the data being freed, if the proble function fails (if that is possible) or if the remove function succeeds. Signed-off-by: Himangi Saraogi Signed-off-by: Greg Kroah-Hartman