kernel/linux.git/drivers/staging/most, branch v4.4.235

staging: most: net: fix buffer overflow

2020-02-05T13:03:32+00:00

commit 4d1356ac12f4d5180d0df345d85ff0ee42b89c72 upstream. If the length of the socket buffer is 0xFFFFFFFF (max size for an unsigned int), then payload_len becomes 0xFFFFFFF1 after subtracting 14 (ETH_HLEN). Then, mdp_len is set to payload_len + 16 (MDP_HDR_LEN) which overflows and results in a value of 2. These values for payload_len and mdp_len will pass current buffer size checks. This patch checks if derived from skb->len sum may overflow. The check is based on the following idea: For any `unsigned V1, V2` and derived `unsigned SUM = V1 + V2`, `V1 + V2` overflows iif `SUM < V1`. Reported-by: Greg Kroah-Hartman Signed-off-by: Andrey Shvetsov Cc: stable Link: https://lore.kernel.org/r/20200116172238.6046-1-andrey.shvetsov@microchip.com Signed-off-by: Greg Kroah-Hartman

staging: most: remove exclusive wait_queue

2015-10-28T23:57:19+00:00

This patch removes the unnecessary wait_queue that has exclusively been used for the poll function and its poll_table. Instead, an already existing one is used. Signed-off-by: Christian Gromm Signed-off-by: Greg Kroah-Hartman

staging: most: hdm-dim2: use min_t()

2015-10-28T23:57:19+00:00

This patch replaces the usage of min() by min_t(). Signed-off-by: Christian Gromm Signed-off-by: Greg Kroah-Hartman

staging: most: hdm-usb: Use setup_timer

2015-10-25T02:09:03+00:00

Use the timer API function setup_timer instead of init_timer, removing the structure field assignments. @timer@ expression e1,e2,e3,fn_ptr; @@ -init_timer(&e1); +setup_timer(&e1, fn_ptr, e2); ... when != fn_ptr = e3 -e1.function = fn_ptr; -e1.data = e2; Signed-off-by: Muhammad Falak R Wani Signed-off-by: Greg Kroah-Hartman

staging: most: remove comparison to NULL

2015-10-25T02:08:20+00:00

Signed-off-by: Christian Gromm Signed-off-by: Greg Kroah-Hartman

staging: most: use preferred kzalloc parameters

2015-10-25T02:08:20+00:00

This patch uses the preferred call to kzalloc. It replaces kzalloc(sizeof(struct aim_fh)...) by kzalloc(sizeof(*fh)...). Signed-off-by: Christian Gromm Signed-off-by: Greg Kroah-Hartman

staging: most: use preferred kernel types

2015-10-25T02:08:20+00:00

This patch makes use of the preferred kernel types such as u16, u32. Signed-off-by: Christian Gromm Signed-off-by: Greg Kroah-Hartman

staging: most: fix logical operator position

2015-10-25T02:08:20+00:00

This patch puts logical continuations on the previous line to meet coding style. Signed-off-by: Christian Gromm Signed-off-by: Greg Kroah-Hartman

staging: most: remove unnecessary parentheses

2015-10-25T02:08:20+00:00

This patch simply removes unnecessary parentheses. Signed-off-by: Christian Gromm Signed-off-by: Greg Kroah-Hartman

staging: most: use blank line after declarations

2015-10-25T02:08:16+00:00

This patch fixes style violation regarding blank lines after function/struct/union/enum declarations. Signed-off-by: Christian Gromm Signed-off-by: Greg Kroah-Hartman